)]}'
{"doc/source/api/large_objects.rst":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69209aea4373f8ed5159d38e598997920152c398","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       the segment objects in JSON format."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"   **Dynamic large objects**"},{"line_number":31,"context_line":"       The manifest object is supposed to have no content (as of today,"},{"line_number":32,"context_line":"       this if not enforced) but it has a ``X-Object-Manifest`` metadata"},{"line_number":33,"context_line":"       header. The value of this header is ``{container}/{prefix}``,"},{"line_number":34,"context_line":"       where ``{container}`` is the name of the container where the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_7a80be49","line":31,"updated":"2015-01-13 09:30:50.000000000","message":"How about simply stating:\n\n\"The manifest object has a ``X-Object-Manifest`` metadata  header. The value of this header is ``{container}/{prefix}``,\t the container where the segment objects are stored, and where ``{container}`` is the name of the container where the  ``{prefix}`` is a string that all segment objects have in common.\t       segment objects are stored, and ``{prefix}`` is a string that all segment objects have in common. The manifest object may have arbitrary content.\"\n\nThe last sentence could alternatively be:\n\n\"The manifest object should have no content (this is not enforced but may be in the future).\"\n\nBut for reasons stated earlier on this review I suspect it may never be enforced, so the first version may be more correct.","commit_id":"8bd64e1417a8747ddcbf9e35ee30d79ba7f4a4f4"},{"author":{"_account_id":8542,"name":"Prashanth Pai","email":"ppai@redhat.com","username":"pai"},"change_message_id":"13c67325e836b57a7910b7801e749558d0b18904","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"   **Dynamic large objects**"},{"line_number":31,"context_line":"       The manifest object is supposed to have no content (as of today,"},{"line_number":32,"context_line":"       this if not enforced) but it has a ``X-Object-Manifest`` metadata"},{"line_number":33,"context_line":"       header. The value of this header is ``{container}/{prefix}``,"},{"line_number":34,"context_line":"       where ``{container}`` is the name of the container where the"},{"line_number":35,"context_line":"       segment objects are stored, and ``{prefix}`` is a string that all"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_5ffcd4b5","line":32,"updated":"2015-01-13 08:50:00.000000000","message":"s/if/is","commit_id":"8bd64e1417a8747ddcbf9e35ee30d79ba7f4a4f4"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"524ff57ddb2cb09b8dc37b18c13cd1b527fe769c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       where ``{container}`` is the name of the container where the"},{"line_number":34,"context_line":"       segment objects are stored, and ``{prefix}`` is a string that all"},{"line_number":35,"context_line":"       segment objects have in common. The manifest object should have"},{"line_number":36,"context_line":"       have no content. However, this is not enforced."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Note"},{"line_number":39,"context_line":"~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_4ecc13bc","line":36,"updated":"2015-01-13 19:47:35.000000000","message":"you have \"have have\"","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"},{"author":{"_account_id":8542,"name":"Prashanth Pai","email":"ppai@redhat.com","username":"pai"},"change_message_id":"0139261fa87adcb82ee5402b4f19ac97ab6c87ee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       where ``{container}`` is the name of the container where the"},{"line_number":34,"context_line":"       segment objects are stored, and ``{prefix}`` is a string that all"},{"line_number":35,"context_line":"       segment objects have in common. The manifest object should have"},{"line_number":36,"context_line":"       have no content. However, this is not enforced."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Note"},{"line_number":39,"context_line":"~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_249a4d14","line":36,"in_reply_to":"3a961159_4ecc13bc","updated":"2015-01-15 05:20:39.000000000","message":"Done","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"}],"doc/source/overview_large_objects.rst":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"050b048fb39ee3513da46575763a563aab2e0f3a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    If the manifest path itself conforms to container/prefix (as shown in the"},{"line_number":93,"context_line":"    example below), and if manifest file has some content/data in it, it would"},{"line_number":94,"context_line":"    also be considered as segment and manifest\u0027s content will be part of the"},{"line_number":95,"context_line":"    concatenated GET response."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Here\u0027s an example using ``curl`` with tiny 1-byte segments::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_17069a85","line":95,"updated":"2015-01-13 20:45:40.000000000","message":"is this behavior desired? where is it concatenated? beginning or end of file? should it be specified here?","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"},{"author":{"_account_id":8542,"name":"Prashanth Pai","email":"ppai@redhat.com","username":"pai"},"change_message_id":"0139261fa87adcb82ee5402b4f19ac97ab6c87ee","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    If the manifest path itself conforms to container/prefix (as shown in the"},{"line_number":93,"context_line":"    example below), and if manifest file has some content/data in it, it would"},{"line_number":94,"context_line":"    also be considered as segment and manifest\u0027s content will be part of the"},{"line_number":95,"context_line":"    concatenated GET response."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Here\u0027s an example using ``curl`` with tiny 1-byte segments::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_a908d82d","line":95,"in_reply_to":"3a961159_17069a85","updated":"2015-01-15 05:20:39.000000000","message":"IMO, the behavior is not desired. However, from prior review comments, we decided to not break old clients/users who may rely on existing behavior.\n\nWhen manifest contains data and conforms to prefix specified in X-Object-Manifest,  the order of concatenation follows the normal DLO logic i.e the order in which segments are returned when passed to sort(). There is no deviation in behavior in terms of order. I\u0027ll include it, just to be extra clear.","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"461f2426f6f678c40aa04120c3dba11df180fe97","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The manifest file should have no content. However, this is not enforced."},{"line_number":92,"context_line":"    If the manifest path itself conforms to container/prefix (as shown in the"},{"line_number":93,"context_line":"    example below), and if manifest file has some content/data in it, it would"},{"line_number":94,"context_line":"    also be considered as segment and manifest\u0027s content will be part of the"},{"line_number":95,"context_line":"    concatenated GET response. The order of concatenation follows the usual DLO"},{"line_number":96,"context_line":"    logic which is - the order of concatenation adheres to order returned when"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_a1d45647","line":93,"updated":"2015-01-15 16:12:22.000000000","message":"so, in the example below, the manifest content would actually not be part of the \"full\" object and that\u0027s because of the extra \u0027/\u0027 at the end of the \u0027X-Object-Manifest\u0027 header, but if you remove that \u0027/\u0027 then it works as you have described.","commit_id":"14e7d53ac6d4c22dd325b61ee76a9ba34ed99b06"},{"author":{"_account_id":8542,"name":"Prashanth Pai","email":"ppai@redhat.com","username":"pai"},"change_message_id":"54f3409a985ac20b8612405d880d1b11f9aaa22a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The manifest file should have no content. However, this is not enforced."},{"line_number":92,"context_line":"    If the manifest path itself conforms to container/prefix (as shown in the"},{"line_number":93,"context_line":"    example below), and if manifest file has some content/data in it, it would"},{"line_number":94,"context_line":"    also be considered as segment and manifest\u0027s content will be part of the"},{"line_number":95,"context_line":"    concatenated GET response. The order of concatenation follows the usual DLO"},{"line_number":96,"context_line":"    logic which is - the order of concatenation adheres to order returned when"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_f42605b9","line":93,"in_reply_to":"3a961159_a1d45647","updated":"2015-01-16 04:54:09.000000000","message":"Nice catch. Thanks. I\u0027ll remove reference to below example.","commit_id":"14e7d53ac6d4c22dd325b61ee76a9ba34ed99b06"}],"test/functional/tests.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"524ff57ddb2cb09b8dc37b18c13cd1b527fe769c","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"            \"aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeeeeeeeeeeffffffffff\")"},{"line_number":1845,"context_line":"        # The copied object must not have X-Object-Manifest"},{"line_number":1846,"context_line":"        self.assertRaises(KeyError,"},{"line_number":1847,"context_line":"                          lambda: file_item.info()[\u0027x_object_manifest\u0027])"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"    def test_copy_account(self):"},{"line_number":1850,"context_line":"        # dlo use same account and same container only"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_f1ecbe94","line":1847,"updated":"2015-01-13 19:47:35.000000000","message":"I think this would be clearer:\n\n    \"x_object_manifest\" not in file_item.info()","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"},{"author":{"_account_id":8542,"name":"Prashanth Pai","email":"ppai@redhat.com","username":"pai"},"change_message_id":"0139261fa87adcb82ee5402b4f19ac97ab6c87ee","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"            \"aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeeeeeeeeeeffffffffff\")"},{"line_number":1845,"context_line":"        # The copied object must not have X-Object-Manifest"},{"line_number":1846,"context_line":"        self.assertRaises(KeyError,"},{"line_number":1847,"context_line":"                          lambda: file_item.info()[\u0027x_object_manifest\u0027])"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"    def test_copy_account(self):"},{"line_number":1850,"context_line":"        # dlo use same account and same container only"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_64a0d542","line":1847,"in_reply_to":"3a961159_f1ecbe94","updated":"2015-01-15 05:20:39.000000000","message":"Done","commit_id":"83d5598c4eba3df1805518fa005abba96c6c6e0e"}]}
