)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":13777,"name":"Nicolas Trangez","email":"ikke@nicolast.be","username":"nicolast"},"change_message_id":"b4a737f5fea70c24e440052bd78a597f3c118305","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\"Method for a file PUT connect\"\"\""},{"line_number":369,"context_line":"        self.app.logger.thread_locals \u003d logger_thread_locals"},{"line_number":370,"context_line":"        for node in nodes:"},{"line_number":371,"context_line":"            try:"},{"line_number":372,"context_line":"                # bypass if storing locally at we have the object server"},{"line_number":373,"context_line":"                if \u0027paco.object_server\u0027 in req.environ and \\"},{"line_number":374,"context_line":"                        node[\u0027port\u0027] \u003d\u003d int(req.environ[\u0027paco.bind_port\u0027]) \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_86fdfb3c","line":371,"updated":"2015-01-23 10:24:09.000000000","message":"It could be useful to pull this block out in a separate method or procedure for testing purposes and enhance readability.","commit_id":"2b2b1a078f52daecdf88abc14149b87c972c8963"},{"author":{"_account_id":13777,"name":"Nicolas Trangez","email":"ikke@nicolast.be","username":"nicolast"},"change_message_id":"b4a737f5fea70c24e440052bd78a597f3c118305","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        self.app.logger.thread_locals \u003d logger_thread_locals"},{"line_number":370,"context_line":"        for node in nodes:"},{"line_number":371,"context_line":"            try:"},{"line_number":372,"context_line":"                # bypass if storing locally at we have the object server"},{"line_number":373,"context_line":"                if \u0027paco.object_server\u0027 in req.environ and \\"},{"line_number":374,"context_line":"                        node[\u0027port\u0027] \u003d\u003d int(req.environ[\u0027paco.bind_port\u0027]) \\"},{"line_number":375,"context_line":"                        and node[\u0027ip\u0027] in [\u0027localhost\u0027, \u0027127.0.0.1\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_a6baf707","line":372,"updated":"2015-01-23 10:24:09.000000000","message":"\u0027as we are the object server\u0027?","commit_id":"2b2b1a078f52daecdf88abc14149b87c972c8963"},{"author":{"_account_id":13777,"name":"Nicolas Trangez","email":"ikke@nicolast.be","username":"nicolast"},"change_message_id":"b4a737f5fea70c24e440052bd78a597f3c118305","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"                    # hack in so that the object servers reads the data"},{"line_number":391,"context_line":"                    # directly from the queue"},{"line_number":392,"context_line":"                    class Dummy():"},{"line_number":393,"context_line":"                        pass"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"                    reader \u003d Dummy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_065cab7d","line":392,"updated":"2015-01-23 10:24:09.000000000","message":"It could be worthwhile to pull this out as a top-level class with a `reader` method, which permits writing some tests.","commit_id":"2b2b1a078f52daecdf88abc14149b87c972c8963"},{"author":{"_account_id":13777,"name":"Nicolas Trangez","email":"ikke@nicolast.be","username":"nicolast"},"change_message_id":"b4a737f5fea70c24e440052bd78a597f3c118305","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                        evt.wait()"},{"line_number":421,"context_line":"                        return conn.resp"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"                    conn.getresponse \u003d get_response"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"                    # spawn work on a separate thread"},{"line_number":426,"context_line":"                    spawn(process_request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_06eaeb74","line":423,"updated":"2015-01-23 10:24:09.000000000","message":"Instead of patching-in these methods, could they be implemented in `LocalConn`?","commit_id":"2b2b1a078f52daecdf88abc14149b87c972c8963"},{"author":{"_account_id":13777,"name":"Nicolas Trangez","email":"ikke@nicolast.be","username":"nicolast"},"change_message_id":"b4a737f5fea70c24e440052bd78a597f3c118305","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                    spawn(process_request)"},{"line_number":427,"context_line":"                    return conn"},{"line_number":428,"context_line":"            except Exception as ex:"},{"line_number":429,"context_line":"                self.app.logger.exception(\"exception: %s\" % ex.message)"},{"line_number":430,"context_line":"                raise ex"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_86ab3b1c","line":429,"updated":"2015-01-23 10:24:09.000000000","message":"A more elaborate log message could be useful.","commit_id":"2b2b1a078f52daecdf88abc14149b87c972c8963"}]}