)]}'
{"swift/common/base_storage_server.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"edaf29665c163eb529364d7b9806c958418c49f6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if replication_server is not None:"},{"line_number":31,"context_line":"            replication_server \u003d config_true_value(replication_server)"},{"line_number":32,"context_line":"        self.replication_server \u003d replication_server"},{"line_number":33,"context_line":"        self.server_type \u003d \u0027base-storage-server\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"},{"line_number":36,"context_line":"    def allowed_methods(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_791370b8","line":33,"updated":"2015-01-28 23:38:51.000000000","message":"How would you feel about a @property method that raises NotImplementedError here? It\u0027d be a little annoying if the string \"base-storage-server\" ever escaped onto the network, and a NotImplementedError tells you pretty clearly what to go implement to fix it.\n\nI\u0027m not saying it\u0027s required, just that it\u0027s something to consider.","commit_id":"6d76d8cc35513ec51470f9f0f967e70a7c1624a5"}]}