)]}'
{"test/unit/common/test_base_storage_server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4d5230432472847ec3863aa36a5cd01dfdcc7b86","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Test swift.common.base_storage_server\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        self.tmpdir \u003d mkdtemp()"},{"line_number":48,"context_line":"        self.testdir \u003d os.path.join(self.tmpdir,"},{"line_number":49,"context_line":"                                    \u0027tmp_test_base_storage_server\u0027)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1eebd813","line":47,"updated":"2015-02-04 18:12:03.000000000","message":"rm the tmp dir in a tearDown method to avoid leaving litter in /tmp","commit_id":"8ba0f31f12b309cd05a733090b57f0dda7ee636a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4d5230432472847ec3863aa36a5cd01dfdcc7b86","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        except NotImplementedError as e:"},{"line_number":58,"context_line":"            self.assertEquals(e.message, msg)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_allowed_methods(self):"},{"line_number":61,"context_line":"        conf \u003d {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027,"},{"line_number":62,"context_line":"                \u0027replication_server\u0027: \u0027false\u0027}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_bedbac7a","line":60,"updated":"2015-02-04 18:12:03.000000000","message":"expand to cover replication_server \u003d True and None","commit_id":"8ba0f31f12b309cd05a733090b57f0dda7ee636a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a31a1375e67c9b3345c41a898034a3bf29637dca","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # test that a subclass can add allowed methods"},{"line_number":86,"context_line":"        allowed_methods_test \u003d FakeANOTHER(conf).allowed_methods"},{"line_number":87,"context_line":"        self.assertEquals(allowed_methods_test, [])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        conf \u003d {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_7715d747","line":87,"updated":"2015-02-04 20:03:47.000000000","message":"ok but you are still not verifying that a method decorated with @public and @replication will be added to allowed_methods because there is no such method in FakeAnother, so line 49 in the base_storage_server.py is not covered","commit_id":"74563ece4782d16bf5a66db63d7c0c718a69db38"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a31a1375e67c9b3345c41a898034a3bf29637dca","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # test that a subclass can add allowed methods"},{"line_number":96,"context_line":"        allowed_methods_test \u003d FakeANOTHER(conf).allowed_methods"},{"line_number":97,"context_line":"        allowed_methods_test.sort()"},{"line_number":98,"context_line":"        self.assertEquals(allowed_methods_test, [\u0027ANOTHER\u0027, \u0027OPTIONS\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_OPTIONS_error(self):"},{"line_number":101,"context_line":"        msg \u003d \u0027Storage nodes have not implemented the Server type.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b23bddcf","line":98,"updated":"2015-02-04 20:03:47.000000000","message":"likewise you are not verifying that a method with both @public and @replication is *not* added in this case.","commit_id":"74563ece4782d16bf5a66db63d7c0c718a69db38"}]}
