)]}'
{"test/unit/proxy/controllers/test_base.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"30cc3c10937aac7aebbf96e6c088eaafd7b3387c","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                          lambda: (source2, node)):"},{"line_number":709,"context_line":"            client_chunks \u003d list(app_iter)"},{"line_number":710,"context_line":"        self.assertEqual(client_chunks, [\u0027abcd1234\u0027, \u0027efgh5678\u0027])"},{"line_number":711,"context_line":"        self.assertEqual(handler.backend_headers[\u0027Range\u0027], \u0027bytes\u003d8-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_443c88e1","line":711,"updated":"2015-02-19 01:50:13.000000000","message":"Now that you\u0027ve added client_chuck_size I don\u0027t see a specific test for the case when its set to None in this file.\n\nAlthough all the other tests pass, and anywhere else in code where GetOrHeadHandler is used wont be setting it... so in a way its tested, but a wonder if we need to be more specific, just so we have proper coverage?\n\nSomething simple like (unless I did a boy look and missed the test of course):\n\n    def test_client_chunk_size_none(self):\n\n        class TestSource(object):\n            def __init__(self, chunks):\n                self.chunks \u003d list(chunks)\n\n            def read(self, _read_size):\n                if self.chunks:\n                    return self.chunks.pop(0)\n                else:\n                    return \u0027\u0027\n\n        chunks \u003d [\u0027abcd\u0027, \u00271234\u0027, \u0027abc\u0027, \u0027d1\u0027, \u0027234abcd1234abcd1\u0027, \u00272\u0027]\n        source \u003d TestSource(chunks)\n        req \u003d Request.blank(\u0027/v1/a/c/o\u0027)\n        node \u003d {}\n        handler \u003d GetOrHeadHandler(self.app, req, None, None, None, None, {},\n                                   client_chunk_size\u003dNone)\n\n        app_iter \u003d handler._make_app_iter(req, node, source)\n        client_chunks \u003d list(app_iter)\n        self.assertEqual(client_chunks, chunks)","commit_id":"a77bdd12c59b57ee73ab0bd14cfa75d092379190"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"37006a7bb11bfb0c43be852bb8b1e38b1403b944","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                          lambda: (source2, node)):"},{"line_number":709,"context_line":"            client_chunks \u003d list(app_iter)"},{"line_number":710,"context_line":"        self.assertEqual(client_chunks, [\u0027abcd1234\u0027, \u0027efgh5678\u0027])"},{"line_number":711,"context_line":"        self.assertEqual(handler.backend_headers[\u0027Range\u0027], \u0027bytes\u003d8-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_8479b7fe","line":711,"in_reply_to":"da86d52c_443c88e1","updated":"2015-02-20 20:34:49.000000000","message":"I\u0027m not particularly worried about it; pretty much every GET or HEAD request that the proxy touches uses the no-chunk-size path, so if you break it, lots and lots of tests fail.","commit_id":"a77bdd12c59b57ee73ab0bd14cfa75d092379190"}]}
