)]}'
{"doc/source/overview_erasure_code.rst":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"4c3dc854f62b3403a8353ae7985e1b7b176faae6","unresolved":false,"context_lines":[{"line_number":294,"context_line":"System Metadata:  EC has a set of object level system metadata that it attaches to each of"},{"line_number":295,"context_line":"the EC archives.  The metadata is for internal use only:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* \u0027X-Object-Sysmeta-EC-Etag\u0027:  The Etag of the original object"},{"line_number":298,"context_line":"* \u0027X-Object-Sysmeta-EC-Content-Length\u0027: The content length of the original object"},{"line_number":299,"context_line":"* \u0027X-Object-Sysmeta-EC-Archive-Index\u0027: Also known as the \"fragment index\""},{"line_number":300,"context_line":"* \u0027X-Object-Sysmeta-EC-Scheme\u0027: Description of the EC policy used to encode the object"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_5f1a2818","line":297,"updated":"2015-02-20 21:12:34.000000000","message":"since I just finished the crypto spec, the question came up: This header would store the etag of the cyphertext, correct?","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"4c3dc854f62b3403a8353ae7985e1b7b176faae6","unresolved":false,"context_lines":[{"line_number":305,"context_line":"and each reconstructor only communicates with its closest neighbors on the ring."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"PyECLib Metadata:  PyECLib stores a small amount of metadata on a per fragment basis.  This"},{"line_number":308,"context_line":"metadata is not docuemnted here as it is opaque to Swift."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Database Updates"},{"line_number":311,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_3f6f3494","line":308,"updated":"2015-02-20 21:12:34.000000000","message":"nit: documented","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"4c3dc854f62b3403a8353ae7985e1b7b176faae6","unresolved":false,"context_lines":[{"line_number":311,"context_line":"----------------"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"As account and container rings are not associated with a Storage Policy, there is no"},{"line_number":314,"context_line":"change to how these database updates occur when using an EC policy."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"The Reconstructor"},{"line_number":317,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_3f79f42f","line":314,"updated":"2015-02-20 21:12:34.000000000","message":"since FA are treated like regular objects by the object-server, are they also added to the container database? what would the container listing look like? Does it make sense to call out here? maybe it\u0027s already specified else where...","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"}],"swift/common/storage_policy.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"567199e088a0a84af626e7f1af92795dd53c3126","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @property"},{"line_number":408,"context_line":"    def n_streams_for_decode(self):"},{"line_number":409,"context_line":"        return self._ec_ndata"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @property"},{"line_number":412,"context_line":"    def fragment_size(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_9afe8b6a","line":409,"updated":"2015-02-20 09:50:00.000000000","message":"Looks duplicated with ec_ndata property on L326...\n\nIs this for clarifying the meaning for decode?","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0c1483130cad15dd441fe76c99620eee4514b508","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @property"},{"line_number":408,"context_line":"    def n_streams_for_decode(self):"},{"line_number":409,"context_line":"        return self._ec_ndata"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @property"},{"line_number":412,"context_line":"    def fragment_size(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e4b0b3f6","line":409,"in_reply_to":"ba7be1f8_9afe8b6a","updated":"2015-02-20 20:30:38.000000000","message":"Yep, exactly. Also, I didn\u0027t want to have the proxy digging around in private instance variables.","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"23ae717c1ed0575ac1007e4b83b3d79eef5c1e53","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @property"},{"line_number":408,"context_line":"    def n_streams_for_decode(self):"},{"line_number":409,"context_line":"        return self._ec_ndata"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @property"},{"line_number":412,"context_line":"    def fragment_size(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_64bd8a68","line":409,"in_reply_to":"ba7be1f8_e4b0b3f6","updated":"2015-02-23 01:50:04.000000000","message":"I see. Thanks.","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"c1efb8ff67a44efead59c2ffa8f28a0e173ac670","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        NB: a fragment archive is a sequence of 0 or more max-length"},{"line_number":417,"context_line":"        fragments followed by one possibly-shorter fragment."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        if self._fragment_header_len is None:"},{"line_number":420,"context_line":"            # this header is a fixed size, so it\u0027s perfectly okay to learn"},{"line_number":421,"context_line":"            # it by encoding some dummy data"},{"line_number":422,"context_line":"            self._fragment_header_len \u003d len(self.pyeclib_driver.encode(\"\")[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_455bab21","line":419,"updated":"2015-02-18 22:03:34.000000000","message":"its probably worth going ahead and making a pyeclib call here (you already know this) so we don\u0027t have to circle back later.  From the pyeclib docs:\n\nGet EC Segment Info\n\nReturn a dict with the keys - segment_size, last_segment_size, fragment_size, last_fragment_size and num_segments:","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"567199e088a0a84af626e7f1af92795dd53c3126","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        NB: a fragment archive is a sequence of 0 or more max-length"},{"line_number":417,"context_line":"        fragments followed by one possibly-shorter fragment."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        if self._fragment_header_len is None:"},{"line_number":420,"context_line":"            # this header is a fixed size, so it\u0027s perfectly okay to learn"},{"line_number":421,"context_line":"            # it by encoding some dummy data"},{"line_number":422,"context_line":"            self._fragment_header_len \u003d len(self.pyeclib_driver.encode(\"\")[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_bdaa69d2","line":419,"in_reply_to":"da86d52c_455bab21","updated":"2015-02-20 09:50:00.000000000","message":"I agreed to Paul. fragment_size should be given from Pyeclib. However, current \"get_segment_info\" on PyECLib requires both content-length (whole length of content body) and segment_size so that I guess we need to add an API to PyECLib to enable to retrieve the fragment_size from just segment_size. (Or use get_segment_info with dummy content-length...)","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0c1483130cad15dd441fe76c99620eee4514b508","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        NB: a fragment archive is a sequence of 0 or more max-length"},{"line_number":417,"context_line":"        fragments followed by one possibly-shorter fragment."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        if self._fragment_header_len is None:"},{"line_number":420,"context_line":"            # this header is a fixed size, so it\u0027s perfectly okay to learn"},{"line_number":421,"context_line":"            # it by encoding some dummy data"},{"line_number":422,"context_line":"            self._fragment_header_len \u003d len(self.pyeclib_driver.encode(\"\")[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_d1c91d5b","line":419,"in_reply_to":"da86d52c_455bab21","updated":"2015-02-20 20:30:38.000000000","message":"I\u0027m gonna leave it like this for now because I think there\u0027s a bug in pyeclib.\n\nCheck this out:\n\n        swift@saio:~$ ipython\n    Python 2.7.3 (default, Feb 27 2014, 19:58:35) \n    Type \"copyright\", \"credits\" or \"license\" for more information.\n\n    IPython 0.12.1 -- An enhanced Interactive Python.\n    ?         -\u003e Introduction and overview of IPython\u0027s features.\n    %quickref -\u003e Quick reference.\n    help      -\u003e Python\u0027s own help system.\n    object?   -\u003e Details about \u0027object\u0027, use \u0027object??\u0027 for extra details.\n\n    In [1]: import pyeclib\n\n    In [2]: import pyeclib.ec_iface\n\n    In [3]: coder \u003d pyeclib.ec_iface.ECDriver(k\u003d4, m\u003d10, ec_type\u003d\"jerasure_rs_vand\")\n\n    In [4]: coder.get_segment_info(segment_size\u003d1048576, data_len\u003d100)\n    Out[4]: \n    {\u0027fragment_size\u0027: 58,\n     \u0027last_fragment_size\u0027: 58,\n     \u0027last_segment_size\u0027: 100,\n     \u0027num_segments\u0027: 1,\n     \u0027segment_size\u0027: 100}\n\n    In [5]: coder.get_segment_info(segment_size\u003d1048576, data_len\u003d50)\n    Out[5]: \n    {\u0027fragment_size\u0027: 46,\n     \u0027last_fragment_size\u0027: 46,\n     \u0027last_segment_size\u0027: 50,\n     \u0027num_segments\u0027: 1,\n     \u0027segment_size\u0027: 50}\n\n    In [6]: coder.get_segment_info(segment_size\u003d1048576, data_len\u003d1)\n    Out[6]: \n    {\u0027fragment_size\u0027: 34,\n     \u0027last_fragment_size\u0027: 34,\n     \u0027last_segment_size\u0027: 1,\n     \u0027num_segments\u0027: 1,\n     \u0027segment_size\u0027: 1}\n\n    In [7]: coder.get_segment_info(segment_size\u003d1048576, data_len\u003d0)\n    Out[7]: \n    {\u0027fragment_size\u0027: 262176,    # what\n     \u0027last_fragment_size\u0027: 262176,\n     \u0027last_segment_size\u0027: 1048576,\n     \u0027num_segments\u0027: 0,\n     \u0027segment_size\u0027: 1048576}\n\n    In [8]: \n\nSo, it looks like it\u0027s treating data_len\u003d0 as \"no data length specified\", not \"data length is specified and equal to 0\".\n\nI tried throwing a None in there, but that just blew up.\n\nYou know how to file a bug against pyeclib? Looks like the Bitbucket issue tracker is turned off for the project.","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"23ae717c1ed0575ac1007e4b83b3d79eef5c1e53","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        NB: a fragment archive is a sequence of 0 or more max-length"},{"line_number":417,"context_line":"        fragments followed by one possibly-shorter fragment."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        if self._fragment_header_len is None:"},{"line_number":420,"context_line":"            # this header is a fixed size, so it\u0027s perfectly okay to learn"},{"line_number":421,"context_line":"            # it by encoding some dummy data"},{"line_number":422,"context_line":"            self._fragment_header_len \u003d len(self.pyeclib_driver.encode(\"\")[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_844efe94","line":419,"in_reply_to":"da86d52c_d1c91d5b","updated":"2015-02-23 01:50:04.000000000","message":"Exactly, pyeclib\u0027s issue trucker is now closed but I don\u0027t know the reason. I would like to try to dig out the get_segment_info behavior and its code in this week (I could make a pull request according to the spec as above...perhaps...) so tentatively we could let keep this as it is, I guess.","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"c1efb8ff67a44efead59c2ffa8f28a0e173ac670","unresolved":false,"context_lines":[{"line_number":712,"context_line":"                if not chunk:"},{"line_number":713,"context_line":"                    if buf:"},{"line_number":714,"context_line":"                        with ChunkWriteTimeout(self.app.client_timeout):"},{"line_number":715,"context_line":"                            bytes_yielded_to_client +\u003d len(buf)"},{"line_number":716,"context_line":"                            yield buf"},{"line_number":717,"context_line":"                        buf \u003d \u0027\u0027"},{"line_number":718,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2572374a","line":715,"updated":"2015-02-18 22:03:34.000000000","message":"hmmm, how was this incremented before?","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0c1483130cad15dd441fe76c99620eee4514b508","unresolved":false,"context_lines":[{"line_number":712,"context_line":"                if not chunk:"},{"line_number":713,"context_line":"                    if buf:"},{"line_number":714,"context_line":"                        with ChunkWriteTimeout(self.app.client_timeout):"},{"line_number":715,"context_line":"                            bytes_yielded_to_client +\u003d len(buf)"},{"line_number":716,"context_line":"                            yield buf"},{"line_number":717,"context_line":"                        buf \u003d \u0027\u0027"},{"line_number":718,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_60189d84","line":715,"in_reply_to":"da86d52c_2572374a","updated":"2015-02-20 20:30:38.000000000","message":"poorly and inconsistently ;)\n\nIt didn\u0027t really matter before because of the break statement just a couple lines down, because once you hit \"if not chunk:\" you\u0027re done, but I was debugging some stuff at one point and the numbers weren\u0027t matching up and it confused me.\n\nIn fact, it still doesn\u0027t matter for the correctness of Swift. It\u0027s really only here to help us poor humans have a better grasp of things.","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"c1efb8ff67a44efead59c2ffa8f28a0e173ac670","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"                            queue.task_done()"},{"line_number":1261,"context_line":"                            fragments.append(fragment)"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"                        if not all(fragments):  # got a None; we\u0027re done"},{"line_number":1264,"context_line":"                            break"},{"line_number":1265,"context_line":"                        segment \u003d policy.decode_fragments(fragments)"},{"line_number":1266,"context_line":"                        yield segment"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e5881fc8","line":1263,"updated":"2015-02-18 22:03:34.000000000","message":"missing a lot of code coverage from here on down but some of it looks a little strange (the coverage report), haven\u0027t looked at test code yet... something to double check though","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0c1483130cad15dd441fe76c99620eee4514b508","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"                            queue.task_done()"},{"line_number":1261,"context_line":"                            fragments.append(fragment)"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"                        if not all(fragments):  # got a None; we\u0027re done"},{"line_number":1264,"context_line":"                            break"},{"line_number":1265,"context_line":"                        segment \u003d policy.decode_fragments(fragments)"},{"line_number":1266,"context_line":"                        yield segment"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_4159dafb","line":1263,"in_reply_to":"da86d52c_e5881fc8","updated":"2015-02-20 20:30:38.000000000","message":"coverage and eventlet don\u0027t always play nicely together, so not sure what\u0027s going on with that","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"c1efb8ff67a44efead59c2ffa8f28a0e173ac670","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"},{"line_number":1281,"context_line":"                resp.app_iter \u003d decoding_iterator("},{"line_number":1282,"context_line":"                    [r.app_iter for r in good_responses])"},{"line_number":1283,"context_line":"            elif bad_responses:"},{"line_number":1284,"context_line":"                resp \u003d self.best_response("},{"line_number":1285,"context_line":"                    req,"},{"line_number":1286,"context_line":"                    [r.status_int for r in bad_responses],"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a5b2a793","line":1283,"updated":"2015-02-18 22:03:34.000000000","message":"change this to else: to make clayg happy?","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0c1483130cad15dd441fe76c99620eee4514b508","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"},{"line_number":1281,"context_line":"                resp.app_iter \u003d decoding_iterator("},{"line_number":1282,"context_line":"                    [r.app_iter for r in good_responses])"},{"line_number":1283,"context_line":"            elif bad_responses:"},{"line_number":1284,"context_line":"                resp \u003d self.best_response("},{"line_number":1285,"context_line":"                    req,"},{"line_number":1286,"context_line":"                    [r.status_int for r in bad_responses],"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_848ff722","line":1283,"in_reply_to":"da86d52c_a5b2a793","updated":"2015-02-20 20:30:38.000000000","message":"Done","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"ea14d8b7771c09feef97f9f4abf0e175d7f61769","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"                        for queue in queues:"},{"line_number":1259,"context_line":"                            fragment \u003d queue.get()"},{"line_number":1260,"context_line":"                            queue.task_done()"},{"line_number":1261,"context_line":"                            fragments.append(fragment)"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"                        if not all(fragments):  # got a None; we\u0027re done"},{"line_number":1264,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_1036c1e7","line":1261,"updated":"2015-02-23 08:16:18.000000000","message":"Shouldn\u0027t line 1260 and 1261 reversed? I mean\n\n fragmens.append(fragment)\n queue.task_done()\n\nOtherwise the queue accepts the next fragment before the current one is appended. Just wondering, might be irrelevant.","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c98f8b147bf50950adbd7fe53609d5f8093b3556","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                        segment \u003d policy.decode_fragments(fragments)"},{"line_number":1266,"context_line":"                        yield segment"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"            responses \u003d list(pile)"},{"line_number":1269,"context_line":"            good_responses \u003d []"},{"line_number":1270,"context_line":"            bad_responses \u003d []"},{"line_number":1271,"context_line":"            for response in responses:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_2cb994e9","line":1268,"updated":"2015-02-24 00:15:42.000000000","message":"Isn\u0027t pile already an iterator? So there is no need to list() it.","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"4c3dc854f62b3403a8353ae7985e1b7b176faae6","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                else:"},{"line_number":1275,"context_line":"                    bad_responses.append(response)"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            if len(good_responses) \u003d\u003d policy.n_streams_for_decode:"},{"line_number":1278,"context_line":"                # we found enough pieces to decode the object, so now let\u0027s"},{"line_number":1279,"context_line":"                # decode the object"},{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5a907695","line":1277,"updated":"2015-02-20 21:12:34.000000000","message":"I guess I\u0027m still hung up on the issue Kota raised earlier, why not just use ec_ndata here?","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"26893ea5f06001ccc3901f353858acbca2cd5b33","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                else:"},{"line_number":1275,"context_line":"                    bad_responses.append(response)"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            if len(good_responses) \u003d\u003d policy.n_streams_for_decode:"},{"line_number":1278,"context_line":"                # we found enough pieces to decode the object, so now let\u0027s"},{"line_number":1279,"context_line":"                # decode the object"},{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_2ce36634","line":1277,"in_reply_to":"ba7be1f8_51e76d12","updated":"2015-02-23 20:16:04.000000000","message":"@Sam, just to clarify, I meant the property ec_ndata, defined here: http://git.io/AKTB","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"8ba3eac7056822d807c461779d0a2356bcb8a022","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                else:"},{"line_number":1275,"context_line":"                    bad_responses.append(response)"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            if len(good_responses) \u003d\u003d policy.n_streams_for_decode:"},{"line_number":1278,"context_line":"                # we found enough pieces to decode the object, so now let\u0027s"},{"line_number":1279,"context_line":"                # decode the object"},{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_51e76d12","line":1277,"in_reply_to":"ba7be1f8_5a0316b8","updated":"2015-02-21 23:26:06.000000000","message":"I\u0027m good either way :)","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"2eda2df423eb21c03cb2cbe31f9869155c64b2f4","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                else:"},{"line_number":1275,"context_line":"                    bad_responses.append(response)"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            if len(good_responses) \u003d\u003d policy.n_streams_for_decode:"},{"line_number":1278,"context_line":"                # we found enough pieces to decode the object, so now let\u0027s"},{"line_number":1279,"context_line":"                # decode the object"},{"line_number":1280,"context_line":"                resp \u003d good_responses[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5a0316b8","line":1277,"in_reply_to":"ba7be1f8_5a907695","updated":"2015-02-20 21:20:34.000000000","message":"I could; I\u0027d just want to rename it to lose the leading underscore so it\u0027s not private(ish). I like the way the existing code reads better, but if others have a clear preference for ec_ndata, that\u0027s fine by me.","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"}],"swift/proxy/server.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"c1efb8ff67a44efead59c2ffa8f28a0e173ac670","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        if obj and container and account:"},{"line_number":260,"context_line":"            info \u003d get_container_info(req.environ, self)"},{"line_number":261,"context_line":"            storage_policy \u003d POLICIES.get_by_index(info[\u0027storage_policy\u0027])"},{"line_number":262,"context_line":"            if storage_policy.stores_objects_verbatim:"},{"line_number":263,"context_line":"                return ReplicatedObjectController, d"},{"line_number":264,"context_line":"            else:"},{"line_number":265,"context_line":"                return ECObjectController, d"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_0509b330","line":262,"updated":"2015-02-18 22:03:34.000000000","message":"so not a big deal obviously but I think a more appropriate check for this condition would be to look at policy type","commit_id":"76aafb4bf416389058d6f3bc28922307aa2362ac"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c98f8b147bf50950adbd7fe53609d5f8093b3556","unresolved":false,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        # default EC chunk size is 1 MiB, so this is multiple chunks"},{"line_number":1532,"context_line":"        obj \u003d \u0027a m\\xc3\\xb8\\xc3\\xb8se once bit my sister\u0027 * 64 * 1024"},{"line_number":1533,"context_line":"        obj \u003d \u0027a moose once bit my sister\u0027 * 64 * 1024"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        prolis \u003d _test_sockets[0]"},{"line_number":1536,"context_line":"        sock \u003d connect_tcp((\u0027localhost\u0027, prolis.getsockname()[1]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_0704a913","line":1533,"updated":"2015-02-24 00:15:42.000000000","message":"Nit: You are overwriting the unicode obj straight after defining it. Rather then using up memory defining obj, and then redefining, if you want to keep it for future updates of the test, want to comment it out for now, either that or use both?","commit_id":"2ecc376ba34e24d82228b444bf2840962051e2fe"}]}
