)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f1a82b06ba81c9d33d72556d028836b80007569","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"        NEW: 0, 0, 3, 3, 7, 7, 5, 5, 2, 2, 1, 1, ..."},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"        \"\"\""},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"        new_replica2part2dev \u003d []"},{"line_number":1335,"context_line":"        for replica in self._replica2part2dev:"},{"line_number":1336,"context_line":"            new_replica \u003d array(\u0027H\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_ba23ab56","line":1333,"updated":"2015-03-03 18:04:29.000000000","message":"before doing anything, should  check that self.part_power \u003c 32 :)","commit_id":"b9b24a9b7ea41d37518d2c1c52ed1f53d37156a2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f1a82b06ba81c9d33d72556d028836b80007569","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"        self._replica2part2dev \u003d new_replica2part2dev"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"        for device in self._iter_devs():"},{"line_number":1344,"context_line":"            device[\u0027parts\u0027] *\u003d 2"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"        # We need to update the time when a partition has been moved the last"},{"line_number":1347,"context_line":"        # time. Since this is an array of all partitions, we need to double it"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_40e2c0a0","line":1344,"updated":"2015-03-03 18:04:29.000000000","message":"hmmm, do we need to call self_set_parts_wanted() here since dev[\u0027parts\u0027] has changed? i\u0027m not sure yet!","commit_id":"b9b24a9b7ea41d37518d2c1c52ed1f53d37156a2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f1a82b06ba81c9d33d72556d028836b80007569","unresolved":false,"context_lines":[{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"        # We need to update the time when a partition has been moved the last"},{"line_number":1347,"context_line":"        # time. Since this is an array of all partitions, we need to double it"},{"line_number":1348,"context_line":"        # two"},{"line_number":1349,"context_line":"        new_last_part_moves \u003d []"},{"line_number":1350,"context_line":"        for partition in self._last_part_moves:"},{"line_number":1351,"context_line":"            new_last_part_moves.append(partition)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_1a703771","line":1348,"updated":"2015-03-03 18:04:29.000000000","message":"nit: did you mean \u0027too\u0027?","commit_id":"b9b24a9b7ea41d37518d2c1c52ed1f53d37156a2"}],"test/unit/common/ring/test_builder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"13cfc535dd1a1796ad52487659865b695c589d14","unresolved":false,"context_lines":[{"line_number":2468,"context_line":"                self.assertEqual(dev, next_dev)"},{"line_number":2469,"context_line":""},{"line_number":2470,"context_line":"        # same for last_part moves"},{"line_number":2471,"context_line":"        for part in range(0, len(replica), 2):"},{"line_number":2472,"context_line":"            this_last_moved \u003d rb._last_part_moves[part]"},{"line_number":2473,"context_line":"            next_last_moved \u003d rb._last_part_moves[part + 1]"},{"line_number":2474,"context_line":"            self.assertEqual(this_last_moved, next_last_moved)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_482c53ab","line":2471,"updated":"2016-03-08 20:32:23.000000000","message":"akward I think to leak \"replica\" from the above loop and use len here to get at the partition count?  Maybe better to use rb.parts?\n\n    diff --git a/test/unit/common/ring/test_builder.py b/test/unit/common/ring/test_builder.py\n    index 6213089..3f5cf6d 100644\n    --- a/test/unit/common/ring/test_builder.py\n    +++ b/test/unit/common/ring/test_builder.py\n    @@ -2468,7 +2468,7 @@ class TestRingBuilder(unittest.TestCase):\n                     self.assertEqual(dev, next_dev)\n     \n             # same for last_part moves\n    -        for part in range(0, len(replica), 2):\n    +        for part in range(0, rb.parts, 2):\n                 this_last_moved \u003d rb._last_part_moves[part]\n                 next_last_moved \u003d rb._last_part_moves[part + 1]\n                 self.assertEqual(this_last_moved, next_last_moved)","commit_id":"3ff94cb785867382ff6c37cb256d1b0f5381abaa"}]}