)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"2e14e6e7d615d74829ad54d7fd23bf3a16fdf2e0","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        # This happens when copying objects from different type of policy"},{"line_number":470,"context_line":"        # e.g., EC -\u003e Replication or Replication -\u003e EC"},{"line_number":471,"context_line":"        # We need to switch to the right controller"},{"line_number":472,"context_line":"        if policy.policy_type !\u003d self.obj_ctl_type:"},{"line_number":473,"context_line":"            if policy.policy_type \u003d\u003d \u0027erasure_coding\u0027:"},{"line_number":474,"context_line":"                ecod \u003d ECObjectController(self.app, self.account_name,"},{"line_number":475,"context_line":"                                          self.container_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_62474a20","line":472,"updated":"2015-03-23 19:50:48.000000000","message":"mm..not a big fan of this code atm because in the future we could have other ObjectControllers, then we are going to endup with a bunch of if/else statements...OTOH, when the server-side copy middleware lands, all this should go away...","commit_id":"c013244a9732e7469248a875d39fd5b20d1035c0"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"2e14e6e7d615d74829ad54d7fd23bf3a16fdf2e0","unresolved":false,"context_lines":[{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"class ReplicatedObjectController(BaseObjectController):"},{"line_number":1379,"context_line":"    obj_ctl_type \u003d \u0027replication\u0027"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    def _get_or_head_response(self, req, node_iter, partition, policy):"},{"line_number":1382,"context_line":"        resp \u003d self.GETorHEAD_base("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_62f90ae9","line":1379,"updated":"2015-03-23 19:50:48.000000000","message":"how about using storage_policy.REPL_POLICY and EC_POLICY ?","commit_id":"c013244a9732e7469248a875d39fd5b20d1035c0"}],"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"665f2f7bebad8cbe64d9b24df6c79275917086b1","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            with set_http_connect(*get_resp):"},{"line_number":791,"context_line":"                eccontroller.GETorHEAD(req)"},{"line_number":792,"context_line":"            self.assertEqual(len(mock_repo.mock_calls), 4)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"@patch_policies(["},{"line_number":796,"context_line":"    StoragePolicy.from_conf("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1c9680f0","line":793,"updated":"2015-03-13 13:11:12.000000000","message":"Could you add a second test from EC-\u003eReplication? Just to make sure there is no accidental regression in the future.\n\nInstead of calling eccontroller.GETorHEAD(req) you could also call eccontroller.GET(req), to ensure you always use the same method like in obj.py (even if .GET calls .GETorHEAD directly atm).","commit_id":"c013244a9732e7469248a875d39fd5b20d1035c0"},{"author":{"_account_id":5189,"name":"Yuan Zhou","email":"dunk007@gmail.com","username":"yuan-zhou"},"change_message_id":"87e321a0f1a099923f58a09122f9c17d6e2bd49d","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            with set_http_connect(*get_resp):"},{"line_number":791,"context_line":"                eccontroller.GETorHEAD(req)"},{"line_number":792,"context_line":"            self.assertEqual(len(mock_repo.mock_calls), 4)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"@patch_policies(["},{"line_number":796,"context_line":"    StoragePolicy.from_conf("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e4847cd4","line":793,"in_reply_to":"9a80dd14_1c9680f0","updated":"2015-03-16 06:39:38.000000000","message":"Thank you Christian, \n\ndo you mean adding one case like below changes(L896 - L911)?\ncalling controller.GET() is a more promising way!","commit_id":"c013244a9732e7469248a875d39fd5b20d1035c0"}]}