)]}'
{"swift/cli/info.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d6da9cebbe390a105416bc0163fb0aca26e6b42a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        if is_user_meta(\u0027Object\u0027, key):"},{"line_number":288,"context_line":"            user_metadata[key] \u003d value"},{"line_number":289,"context_line":"        elif is_sys_meta(\u0027Object\u0027, key):"},{"line_number":290,"context_line":"            sys_metadata[key] \u003d value"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    print \u0027User Metadata: \u0027"},{"line_number":293,"context_line":"    for item in user_metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_bf484bcd","line":290,"updated":"2015-03-18 12:27:11.000000000","message":"There is a subtle, possible loss of information output with this change: metadata with keys that are neither x-object-meta-* nor x-object-sysmeta-* are printed on master but will not be with this change (e.g. a X-Delete-At)\n\nMy suggestion is to iterate and build a dict of all sysmeta items, then when you print below, for \u0027User Metadata\u0027 print every k,v not in sys_metadata, then for System metadata print items in sys_metadata","commit_id":"b2e086b4b0a63eb009b70d940371bc3474866df8"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"be6bae86884ff853bbae1e32015b671ab951f0ca","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        if is_user_meta(\u0027Object\u0027, key):"},{"line_number":288,"context_line":"            user_metadata[key] \u003d value"},{"line_number":289,"context_line":"        elif is_sys_meta(\u0027Object\u0027, key):"},{"line_number":290,"context_line":"            sys_metadata[key] \u003d value"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    print \u0027User Metadata: \u0027"},{"line_number":293,"context_line":"    for item in user_metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_94e60943","line":290,"in_reply_to":"9a80dd14_7aafc12b","updated":"2015-03-18 13:31:54.000000000","message":"That would work. You could print under the heading \u0027Other metadata\u0027","commit_id":"b2e086b4b0a63eb009b70d940371bc3474866df8"},{"author":{"_account_id":13819,"name":"Ricardo Ferreira","email":"ricardo.sff@gmail.com","username":"rsff"},"change_message_id":"21115a83a21f50cb34a561a67171b60313c2434a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        if is_user_meta(\u0027Object\u0027, key):"},{"line_number":288,"context_line":"            user_metadata[key] \u003d value"},{"line_number":289,"context_line":"        elif is_sys_meta(\u0027Object\u0027, key):"},{"line_number":290,"context_line":"            sys_metadata[key] \u003d value"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    print \u0027User Metadata: \u0027"},{"line_number":293,"context_line":"    for item in user_metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_7aafc12b","line":290,"in_reply_to":"9a80dd14_bf484bcd","updated":"2015-03-18 13:29:20.000000000","message":"What about a else and add everything that doesn\u0027t fall into the previous categories into a dict and carry the usual flow(print)?","commit_id":"b2e086b4b0a63eb009b70d940371bc3474866df8"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"bfe368f94768b22d49841299a1182245b1104937","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            for item in items.iteritems():"},{"line_number":299,"context_line":"                print \u0027%s: %s\u0027 % item"},{"line_number":300,"context_line":"        else:"},{"line_number":301,"context_line":"            print \u0027Not found any metadata\u0027"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    print_metadata(\u0027System Metadata:\u0027, sys_metadata)"},{"line_number":304,"context_line":"    print_metadata(\u0027User Metadata:\u0027, user_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_7ac0a7e0","line":301,"updated":"2015-04-08 19:51:58.000000000","message":"If you stick with printing such a message, then I would change this to say something like \"No metadata found\". Same comment for all the occurrences in test/unit/cli/test_info.py.","commit_id":"abcdb9fbbbcbadd054affddd055a9edc382f6d4f"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"39c3ecd73e48633fa3bb29b97901eef3eb4a60a3","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            for item in items.iteritems():"},{"line_number":299,"context_line":"                print \u0027%s: %s\u0027 % item"},{"line_number":300,"context_line":"        else:"},{"line_number":301,"context_line":"            print \u0027Not found any metadata\u0027"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    print_metadata(\u0027System Metadata:\u0027, sys_metadata)"},{"line_number":304,"context_line":"    print_metadata(\u0027User Metadata:\u0027, user_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_9e1b51ca","line":301,"in_reply_to":"9aa53dc9_7ac0a7e0","updated":"2015-04-09 06:52:26.000000000","message":"That was the first version of message I wanted to put in here, have no idea why changed my mind. Done!","commit_id":"abcdb9fbbbcbadd054affddd055a9edc382f6d4f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"0e12ff5ebf511ad4d1f540098ee14a1422a992e2","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        print title"},{"line_number":297,"context_line":"        if items:"},{"line_number":298,"context_line":"            for meta_key in sorted(items):"},{"line_number":299,"context_line":"                print \u0027%s: %s\u0027 % (meta_key, items[meta_key])"},{"line_number":300,"context_line":"        else:"},{"line_number":301,"context_line":"            print \u0027No metadata found\u0027"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5aa745d1_9ace3c59","line":299,"updated":"2015-04-16 02:51:56.000000000","message":"Can we indent the metadata so the headers pop more in the output. Just use the same as the path breakdown above?\nE.G:\n\n  print \u0027  %s: %s\u0027 % (meta_key, items[meta_key])","commit_id":"5ae5fccd231eef336137228aa444b32c8c058ccd"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6867ffc1726dd7a1fd1a6405efa7be0b8d086225","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        print title"},{"line_number":297,"context_line":"        if items:"},{"line_number":298,"context_line":"            for meta_key in sorted(items):"},{"line_number":299,"context_line":"                print \u0027%s: %s\u0027 % (meta_key, items[meta_key])"},{"line_number":300,"context_line":"        else:"},{"line_number":301,"context_line":"            print \u0027No metadata found\u0027"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5aa745d1_eb3fafd4","line":299,"in_reply_to":"5aa745d1_9ace3c59","updated":"2015-04-16 07:18:57.000000000","message":"Done. Looks much more better now, thanks for the suggestion!","commit_id":"5ae5fccd231eef336137228aa444b32c8c058ccd"}]}
