)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                set_valid_fileset()"},{"line_number":1908,"context_line":"        elif ext \u003d\u003d \u0027.data\u0027 and have_valid_fileset():"},{"line_number":1909,"context_line":"            # must have a newer .ts (or (.durable and .data)),"},{"line_number":1910,"context_line":"            # discard older .data"},{"line_number":1911,"context_line":"            discard()"},{"line_number":1912,"context_line":"        elif ext \u003d\u003d \u0027.ts\u0027:"},{"line_number":1913,"context_line":"            if have_valid_fileset() or not accept_first():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_909c9e6b","line":1910,"updated":"2015-03-23 14:54:07.000000000","message":"This change to the comment is not accurate. This condition is only satisfied when have_valid_fileset is True because a .ts was found.\n\nIf a newer .durable has been found, then line 1892 is True.\nIf a newer .data has been found and have_valid_fileset is True there a .durable must have been found, so again line 1892 is True.","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                set_valid_fileset()"},{"line_number":1908,"context_line":"        elif ext \u003d\u003d \u0027.data\u0027 and have_valid_fileset():"},{"line_number":1909,"context_line":"            # must have a newer .ts (or (.durable and .data)),"},{"line_number":1910,"context_line":"            # discard older .data"},{"line_number":1911,"context_line":"            discard()"},{"line_number":1912,"context_line":"        elif ext \u003d\u003d \u0027.ts\u0027:"},{"line_number":1913,"context_line":"            if have_valid_fileset() or not accept_first():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_71238d05","line":1910,"in_reply_to":"1a6ced46_909c9e6b","updated":"2015-03-24 01:14:34.000000000","message":"Oh, I got misunderstanding. Exactly, when context has .durable it always goes the if condition starts from L1892.\n\nSo this condition means no .durable file exists but have_valid_fileset() is True... i.e. context has only .ts, yes, I got it.\n\nOk, I\u0027ll reconsider to note the condition, thanks!","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":2784,"context_line":"                actual \u003d mgr.ts_to_fname(ts, \u0027.data\u0027, frag_index\u003dfrag)"},{"line_number":2785,"context_line":"                self.assertEqual(expected, actual)"},{"line_number":2786,"context_line":"                self.assertRaises("},{"line_number":2787,"context_line":"                    InvalidFragmentIndex, mgr.ts_to_fname, ts, \u0027.data\u0027)"},{"line_number":2788,"context_line":""},{"line_number":2789,"context_line":"            for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2790,"context_line":"                expected \u003d \u0027%s%s\u0027 % (ts, ext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_5bac07ee","line":2787,"updated":"2015-03-23 14:54:07.000000000","message":"the assertRaises does not need to be in any of the loops","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":2784,"context_line":"                actual \u003d mgr.ts_to_fname(ts, \u0027.data\u0027, frag_index\u003dfrag)"},{"line_number":2785,"context_line":"                self.assertEqual(expected, actual)"},{"line_number":2786,"context_line":"                self.assertRaises("},{"line_number":2787,"context_line":"                    InvalidFragmentIndex, mgr.ts_to_fname, ts, \u0027.data\u0027)"},{"line_number":2788,"context_line":""},{"line_number":2789,"context_line":"            for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2790,"context_line":"                expected \u003d \u0027%s%s\u0027 % (ts, ext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_919f295f","line":2787,"in_reply_to":"1a6ced46_5bac07ee","updated":"2015-03-24 01:14:34.000000000","message":"Done","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":2802,"context_line":"                        Timestamp(\u00271234567890.99999\u0027, offset\u003d17).internal,"},{"line_number":2803,"context_line":"                        ts):"},{"line_number":2804,"context_line":"                f_2 \u003d mgr.ts_to_fname(ts, \u0027.durable\u0027)"},{"line_number":2805,"context_line":"                for fi in (0, 2, None):"},{"line_number":2806,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2807,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2808,"context_line":"                        self.assertFalse(mgr.is_obsolete(f_1, f_2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_d0361603","line":2805,"updated":"2015-03-23 14:54:07.000000000","message":"this loop is no longer required - \u0027fi\u0027 is not used","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":2802,"context_line":"                        Timestamp(\u00271234567890.99999\u0027, offset\u003d17).internal,"},{"line_number":2803,"context_line":"                        ts):"},{"line_number":2804,"context_line":"                f_2 \u003d mgr.ts_to_fname(ts, \u0027.durable\u0027)"},{"line_number":2805,"context_line":"                for fi in (0, 2, None):"},{"line_number":2806,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2807,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2808,"context_line":"                        self.assertFalse(mgr.is_obsolete(f_1, f_2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_51ddb16f","line":2805,"in_reply_to":"1a6ced46_d0361603","updated":"2015-03-24 01:14:34.000000000","message":"Done","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":2816,"context_line":"                for fi in (0, 2):"},{"line_number":2817,"context_line":"                    f_1 \u003d mgr.ts_to_fname(ts2, \u0027.data\u0027, frag_index\u003dfi)"},{"line_number":2818,"context_line":"                    self.assertTrue(mgr.is_obsolete(f_1, f_2),"},{"line_number":2819,"context_line":"                                    \u0027%s should not be w.r.t. %s\u0027 % (f_1, f_2))"},{"line_number":2820,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2821,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2822,"context_line":"                        self.assertTrue(mgr.is_obsolete(f_1, f_2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_70064222","line":2819,"updated":"2015-03-23 14:54:07.000000000","message":"type, should be:\n\n  \u0027%s should be obsolete w.r.t. %s\u0027","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":2816,"context_line":"                for fi in (0, 2):"},{"line_number":2817,"context_line":"                    f_1 \u003d mgr.ts_to_fname(ts2, \u0027.data\u0027, frag_index\u003dfi)"},{"line_number":2818,"context_line":"                    self.assertTrue(mgr.is_obsolete(f_1, f_2),"},{"line_number":2819,"context_line":"                                    \u0027%s should not be w.r.t. %s\u0027 % (f_1, f_2))"},{"line_number":2820,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2821,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2822,"context_line":"                        self.assertTrue(mgr.is_obsolete(f_1, f_2),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_d15e01e9","line":2819,"in_reply_to":"1a6ced46_70064222","updated":"2015-03-24 01:14:34.000000000","message":"Done","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2821,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2822,"context_line":"                        self.assertTrue(mgr.is_obsolete(f_1, f_2),"},{"line_number":2823,"context_line":"                                        \u0027%s should not be w.r.t. %s\u0027"},{"line_number":2824,"context_line":"                                        % (f_1, f_2))"},{"line_number":2825,"context_line":"                    self.assertRaises(InvalidFragmentIndex, mgr.ts_to_fname,"},{"line_number":2826,"context_line":"                                      ts2, ext, frag_index\u003dfi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_db047717","line":2823,"updated":"2015-03-23 14:54:07.000000000","message":"type, should be:\n\n  \u0027%s should be obsolete w.r.t. %s\u0027","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                    for ext in (\u0027.meta\u0027, \u0027.durable\u0027, \u0027.ts\u0027):"},{"line_number":2821,"context_line":"                        f_1 \u003d mgr.ts_to_fname(ts2, ext)"},{"line_number":2822,"context_line":"                        self.assertTrue(mgr.is_obsolete(f_1, f_2),"},{"line_number":2823,"context_line":"                                        \u0027%s should not be w.r.t. %s\u0027"},{"line_number":2824,"context_line":"                                        % (f_1, f_2))"},{"line_number":2825,"context_line":"                    self.assertRaises(InvalidFragmentIndex, mgr.ts_to_fname,"},{"line_number":2826,"context_line":"                                      ts2, ext, frag_index\u003dfi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_f163fdae","line":2823,"in_reply_to":"1a6ced46_db047717","updated":"2015-03-24 01:14:34.000000000","message":"Done","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c9223495e2aa2c99fb67f33bc41a6deca6ba5efe","unresolved":false,"context_lines":[{"line_number":2825,"context_line":"                    self.assertRaises(InvalidFragmentIndex, mgr.ts_to_fname,"},{"line_number":2826,"context_line":"                                      ts2, ext, frag_index\u003dfi)"},{"line_number":2827,"context_line":"                self.assertRaises("},{"line_number":2828,"context_line":"                    InvalidFragmentIndex, mgr.ts_to_fname, ts2, \u0027.data\u0027, None)"},{"line_number":2829,"context_line":""},{"line_number":2830,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":2831,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_dbee3722","line":2828,"updated":"2015-03-23 14:54:07.000000000","message":"This assertRaises is unnecessary here, it duplicates line 1786","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"24f9c843034cb0f75994afe0840cd23254e564c7","unresolved":false,"context_lines":[{"line_number":2825,"context_line":"                    self.assertRaises(InvalidFragmentIndex, mgr.ts_to_fname,"},{"line_number":2826,"context_line":"                                      ts2, ext, frag_index\u003dfi)"},{"line_number":2827,"context_line":"                self.assertRaises("},{"line_number":2828,"context_line":"                    InvalidFragmentIndex, mgr.ts_to_fname, ts2, \u0027.data\u0027, None)"},{"line_number":2829,"context_line":""},{"line_number":2830,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":2831,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_115979fe","line":2828,"in_reply_to":"1a6ced46_dbee3722","updated":"2015-03-24 01:14:34.000000000","message":"Done","commit_id":"d46c46567e4ce97e04013751a796a03c2cdbae5f"}]}
