)]}'
{"test/unit/proxy/test_server.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"545de609aeb512ee63611b19170904c5a2918d12","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        df \u003d df_mgr.get_diskfile(node[\u0027device\u0027], partition, \u0027a\u0027,"},{"line_number":1181,"context_line":"                                 \u0027c1\u0027, \u0027wrong-o\u0027, policy_idx\u003d2)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        self.assertRaises(DiskFileNotExist, df.open)"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    @unpatch_policies"},{"line_number":1186,"context_line":"    def test_GET_newest_large_file(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_9c837d04","line":1183,"updated":"2015-04-08 13:06:07.000000000","message":"Unfortunately this is not the same behaviour. DiskFileNotExist is also raised if the file never existed; only if the file was actually deleted the attribute timestamp is set.\nThis timestamp is determined by the metadata, and checking this timestamp is required to ensure that the deletion happened.\n\nYou could check if \"DiskFileDeleted\" is raised and the timestamp is greater than 0 or increase the timerange (thou this might be needed to ensure something else I\u0027m currently not aware of).\n\nHave a look for DiskFileDeleted in swift/common/exceptions.py.","commit_id":"0da83cc0184dc2fb0cd8267830cf2624349dcc9a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"161b8e0a49ae3db5a93a7413f2c5b849770836d0","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        df \u003d df_mgr.get_diskfile(node[\u0027device\u0027], partition, \u0027a\u0027,"},{"line_number":1181,"context_line":"                                 \u0027c1\u0027, \u0027wrong-o\u0027, policy_idx\u003d2)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        self.assertRaises(DiskFileNotExist, df.open)"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    @unpatch_policies"},{"line_number":1186,"context_line":"    def test_GET_newest_large_file(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_e8008303","line":1183,"in_reply_to":"9aa53dc9_9c837d04","updated":"2015-04-08 14:06:09.000000000","message":"Thanks for the explanation! I will fix it in a couple of minutes.","commit_id":"0da83cc0184dc2fb0cd8267830cf2624349dcc9a"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"a7f76ff37e82b77b8d6ec9d4fb9ec6757b3aa3e5","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        df \u003d df_mgr.get_diskfile(node[\u0027device\u0027], partition, \u0027a\u0027,"},{"line_number":1181,"context_line":"                                 \u0027c1\u0027, \u0027wrong-o\u0027, policy_idx\u003d2)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        with self.assertRaises(DiskFileNotExist) as cm:"},{"line_number":1184,"context_line":"            df.open()"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"        self.assertGreater(cm.exception.timestamp, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_1cce485a","line":1183,"updated":"2015-04-08 14:47:05.000000000","message":"Sorry to be the grumpy guy here...\n\nwith self.assertRaises is a context manager which is only supported in Python 2.7 and beyond. Swift still supports Python 2.6, thus you need a try...except block here.\n\nFor reference: https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises","commit_id":"e12889c47080050eca627b757b42989bbd4f672f"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e3e42bb396b99f8f02366c9f8d8f9c10781d4eca","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        df \u003d df_mgr.get_diskfile(node[\u0027device\u0027], partition, \u0027a\u0027,"},{"line_number":1181,"context_line":"                                 \u0027c1\u0027, \u0027wrong-o\u0027, policy_idx\u003d2)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        with self.assertRaises(DiskFileNotExist) as cm:"},{"line_number":1184,"context_line":"            df.open()"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"        self.assertGreater(cm.exception.timestamp, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_32fb75c3","line":1183,"in_reply_to":"9aa53dc9_1cce485a","updated":"2015-04-08 16:02:31.000000000","message":"Oh, I didn\u0027t noticed py2.6 in Jenkins, so decided to use context manager. But then I saw \"Python 2.6 should work, but it’s not actively tested. There is no current support for Python 3\" here http://docs.openstack.org/developer/swift/getting_started.html\n\nSo I have no other options but to abandon the idea of using cm. And btw assertGreater was introduced only in 2.7 too :(","commit_id":"e12889c47080050eca627b757b42989bbd4f672f"}]}