)]}'
{"id":"openstack%2Fswift~17166","triplet_id":"openstack%2Fswift~master~I8a67ccafe33dc70ef4f7794686a54fbc8581f4dc","project":"openstack/swift","branch":"master","topic":"badaccept","hashtags":[],"change_id":"I8a67ccafe33dc70ef4f7794686a54fbc8581f4dc","subject":"406 if we can\u0027t satisfy Accept","status":"MERGED","created":"2012-11-29 21:37:47.000000000","updated":"2012-12-03 23:20:11.000000000","submitted":"2012-12-03 23:20:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2fec7b3dddb0865f8b7a1dc7e3d20add9527c351","_number":17166,"virtual_id_number":17166,"owner":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":1,"date":"2012-12-03 20:15:42.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},{"value":0,"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":2,"date":"2012-12-03 23:20:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"all":[{"value":2,"date":"2012-12-03 22:34:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-12-03 21:32:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},{"value":2,"date":"2012-12-03 22:58:52.000000000","_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"all":[{"value":0,"date":"2012-12-03 22:34:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},{"value":1,"date":"2012-12-03 22:58:52.000000000","_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-03 20:15:42.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-12-03 21:32:20.000000000","updated_by":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"reviewer":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"state":"REVIEWER"},{"updated":"2012-12-03 22:34:48.000000000","updated_by":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"reviewer":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"state":"REVIEWER"},{"updated":"2012-12-03 22:58:52.000000000","updated_by":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"reviewer":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"state":"REVIEWER"},{"updated":"2012-12-03 23:20:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"aff44d2d558c4e0a1b83024bf8182d474bd82aa6","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-29 21:57:53.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/51712\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/51711\n","accounts_in_message":[],"_revision_number":1},{"id":"f0869d90a77738402bf106e6bd7fea4641b2c4c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-29 21:59:09.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17166/1/check/gate-swift-merge/1353 : SUCCESS\n- http://logs.openstack.org/17166/1/check/gate-swift-docs/977 : SUCCESS\n- http://logs.openstack.org/17166/1/check/gate-swift-pep8/1120 : SUCCESS\n- http://logs.openstack.org/17166/1/check/gate-swift-python26/1225 : SUCCESS\n- http://logs.openstack.org/17166/1/check/gate-swift-python27/1227 : SUCCESS\n- http://logs.openstack.org/17166/1/check/gate-tempest-devstack-vm/20569 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"7f8b0b0d380c810837765121b75cdc2a5c5f4bbf","author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"date":"2012-11-29 22:21:02.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nThis seems to be okay. But is the existing logic correct?\n\nFor example, in the container server code, before req.accept.best_match() is invoked, we first check for the format parameter and then override the accept object with that what appears to be a single string object pulled from the constraints module\u0027s FORMAT2CONTENT_TYPE dictionary. Is there a way in the code where those objects get turned into swob.Accept() objects?\n\nBeyond that, if we do always end up with an Accept() object for a req.accept field, is it valid to return a 406 response for what is specified by the format parameter? In that case, it would seem that a BadRequest is in order.\n\nMaybe it is not worth handling that nuance?","accounts_in_message":[],"_revision_number":1},{"id":"c6b8e8deed3c283d66f51b7863c23a299ba35c49","author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"date":"2012-11-29 22:35:54.000000000","message":"Patch Set 1: No score\n\n(7 inline comments)\n\nFurther review comments of code you did not change based on reviewing their operation for this commit.","accounts_in_message":[],"_revision_number":1},{"id":"c77292c26fb89462ba16befc6496aa299b75355b","author":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"date":"2012-11-29 22:40:44.000000000","message":"Patch Set 1: Work In Progress\n\nI\u0027m gonna hang on to this for a little more work, because we should probably be serving 406s instead of using default_type when none of the types in the Accept header can be served.","accounts_in_message":[],"_revision_number":1},{"id":"705a108fd9baf7948e66454a88b19df86a66173e","author":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"date":"2012-12-03 19:56:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"655949df4751e779bcf5d43310f2db8e09d827e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-03 20:15:16.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17166/2/check/gate-swift-merge/1370 : SUCCESS\n- http://logs.openstack.org/17166/2/check/gate-swift-docs/994 : SUCCESS\n- http://logs.openstack.org/17166/2/check/gate-swift-pep8/1137 : SUCCESS\n- http://logs.openstack.org/17166/2/check/gate-swift-python26/1242 : SUCCESS\n- http://logs.openstack.org/17166/2/check/gate-swift-python27/1244 : SUCCESS\n- http://logs.openstack.org/17166/2/check/gate-tempest-devstack-vm/20915 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"d71f4d5d1a5162f8586f7cdc4f55cf4c2a09cf85","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-03 20:15:42.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/52416\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/52415\n","accounts_in_message":[],"_revision_number":2},{"id":"992c8caee5901b0a9adfb313542aca920e976dc9","author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"date":"2012-12-03 21:32:20.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(4 inline comments)\n\nNice work.\n\nPerhaps in another commit at some point we could consolidate the same string used in four places?","accounts_in_message":[],"_revision_number":2},{"id":"c04004e908c36e7b752abbf8306ad3b3a411a3cf","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2012-12-03 22:34:48.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f25710a4ab9436421cb1b03a10ef029192caf83c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-03 22:58:52.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"d822f7f16985f95663041ec65232bd43c8f6563d","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2012-12-03 22:58:52.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d9e58d6d90727355d2eab26f41853eb1beeff54b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-03 23:20:10.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/17166/2/gate/gate-swift-merge/1375 : SUCCESS\n- http://logs.openstack.org/17166/2/gate/gate-swift-docs/999 : SUCCESS\n- http://logs.openstack.org/17166/2/gate/gate-swift-pep8/1142 : SUCCESS\n- http://logs.openstack.org/17166/2/gate/gate-swift-python26/1247 : SUCCESS\n- http://logs.openstack.org/17166/2/gate/gate-swift-python27/1249 : SUCCESS\n- http://logs.openstack.org/17166/2/gate/gate-tempest-devstack-vm/20933 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"da9530d7cdbbf0e23378524d3b55746700f1ab47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-03 23:20:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"064ee2b58337b7fd3ae5fca343b1f6fd3bd86ed7","revisions":{"c5a1fe90b4bad0c159d4770f88811ea88ee97bad":{"kind":"REWORK","_number":1,"created":"2012-11-29 21:37:47.000000000","uploader":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"ref":"refs/changes/66/17166/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/66/17166/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/66/17166/1"}}},"commit":{"parents":[{"commit":"871f552ab6b9b40317b90b3b1daf9ca512a9d69a","subject":"Merge \"Updates to use new keystoneclient middleware.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/871f552ab6b9b40317b90b3b1daf9ca512a9d69a"}]}],"author":{"name":"Michael Barton","email":"mike@weirdlooking.com","date":"2012-11-29 21:29:00.000000000","tz":-480},"committer":{"name":"Michael Barton","email":"mike@weirdlooking.com","date":"2012-11-29 21:37:11.000000000","tz":-480},"subject":"406 if we can\u0027t satisfy Accept","message":"406 if we can\u0027t satisfy Accept\n\nThe container and account servers should respond with 406 if the Accept header\nisn\u0027t satisfiable.  This behavior is defined in RFC 2616 section 14.1.\n\nChange-Id: I8a67ccafe33dc70ef4f7794686a54fbc8581f4dc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c5a1fe90b4bad0c159d4770f88811ea88ee97bad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c5a1fe90b4bad0c159d4770f88811ea88ee97bad"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"871f552ab6b9b40317b90b3b1daf9ca512a9d69a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"064ee2b58337b7fd3ae5fca343b1f6fd3bd86ed7":{"kind":"REWORK","_number":2,"created":"2012-12-03 19:56:46.000000000","uploader":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"ref":"refs/changes/66/17166/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/66/17166/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/66/17166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/66/17166/2"}}},"commit":{"parents":[{"commit":"871f552ab6b9b40317b90b3b1daf9ca512a9d69a","subject":"Merge \"Updates to use new keystoneclient middleware.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/871f552ab6b9b40317b90b3b1daf9ca512a9d69a"}]}],"author":{"name":"Michael Barton","email":"mike@weirdlooking.com","date":"2012-11-29 21:29:00.000000000","tz":-480},"committer":{"name":"Michael Barton","email":"mike@weirdlooking.com","date":"2012-12-03 19:42:37.000000000","tz":-480},"subject":"406 if we can\u0027t satisfy Accept","message":"406 if we can\u0027t satisfy Accept\n\nThe container and account servers should respond with 406 if the Accept header\nisn\u0027t satisfiable.  This behavior is defined in RFC 2616 section 14.1.\n\nChange-Id: I8a67ccafe33dc70ef4f7794686a54fbc8581f4dc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/064ee2b58337b7fd3ae5fca343b1f6fd3bd86ed7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/064ee2b58337b7fd3ae5fca343b1f6fd3bd86ed7"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"871f552ab6b9b40317b90b3b1daf9ca512a9d69a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}