)]}'
{"test/probe/common.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"de18f29e2aefebdbef0d6567f7fafcf96a54ea89","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        except SkipTest as err:"},{"line_number":346,"context_line":"            sys.exit(\u0027%s ERROR: %s\u0027 % (server, err))"},{"line_number":347,"context_line":"        print \u0027%s OK\u0027 % server"},{"line_number":348,"context_line":"    for policy in POLICIES:"},{"line_number":349,"context_line":"        test_requirements \u003d {"},{"line_number":350,"context_line":"            EC_POLICY: ECProbeTest,"},{"line_number":351,"context_line":"            REPL_POLICY: ReplProbeTest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_f4e534a8","line":348,"updated":"2015-04-28 11:35:57.000000000","message":"I think it would be better to iterate over the test types - we don\u0027t need *all* policies to be compliant, we just need each test type to find a suitable policy.","commit_id":"44b610030bbfc4707d1bc6ef983ce2cb95f7c22a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"de18f29e2aefebdbef0d6567f7fafcf96a54ea89","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            REPL_POLICY: ReplProbeTest,"},{"line_number":352,"context_line":"        }.get(policy.policy_type)"},{"line_number":353,"context_line":"        if not test_requirements:"},{"line_number":354,"context_line":"            print \u0027Ignoriing unknown policy_type for %r\u0027 % policy"},{"line_number":355,"context_line":"            continue"},{"line_number":356,"context_line":"        required_replicas \u003d test_requirements.obj_required_replicas"},{"line_number":357,"context_line":"        required_devices \u003d test_requirements.obj_required_devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_147af024","line":354,"updated":"2015-04-28 11:35:57.000000000","message":"s/Ignoriing/Ignoring/","commit_id":"44b610030bbfc4707d1bc6ef983ce2cb95f7c22a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"de18f29e2aefebdbef0d6567f7fafcf96a54ea89","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            get_ring(policy.ring_name, required_replicas, required_devices,"},{"line_number":360,"context_line":"                     server\u003d\u0027object\u0027, force_validate\u003dTrue)"},{"line_number":361,"context_line":"        except SkipTest as err:"},{"line_number":362,"context_line":"            sys.exit(\u0027object ERROR (%s): %s\u0027 % (policy.name, err))"},{"line_number":363,"context_line":"        print \u0027object OK (%s)\u0027 % policy.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_d4f9184f","line":362,"updated":"2015-04-28 11:35:57.000000000","message":"It might be useful to continue iteration and report which probe tests *would* work, even it ultimately exiting with non-zero code.","commit_id":"44b610030bbfc4707d1bc6ef983ce2cb95f7c22a"}]}
