)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a699c286be7ac0242bf16c7d62dced378108bdf7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Prevent to decode with invalid ec scheme"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, we must not deploy overwrite the ec policy scheme"},{"line_number":10,"context_line":"if we have already have some objects in the policy becuase"},{"line_number":11,"context_line":"absolutely we won\u0027t be able to get the correct data from the"},{"line_number":12,"context_line":"Swift with the overwritten policy."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_a3af822a","line":10,"updated":"2015-05-26 11:00:32.000000000","message":"typo because","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"821cec6a4ecc6bbc3c95e4c5677a7e421e33f7cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Prevent to decode with invalid ec scheme"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, we must not deploy overwrite the ec policy scheme"},{"line_number":10,"context_line":"if we have already have some objects in the policy becuase"},{"line_number":11,"context_line":"absolutely we won\u0027t be able to get the correct data from the"},{"line_number":12,"context_line":"Swift with the overwritten policy."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_42053ac0","line":10,"in_reply_to":"7a016987_a3af822a","updated":"2015-05-27 11:46:44.000000000","message":"will fix but this patch might be abandon.","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a699c286be7ac0242bf16c7d62dced378108bdf7","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, in the such a case, current Swift would return the garbage"},{"line_number":15,"context_line":"(i.e. decorded but incorrect object) and user might not find the fact"},{"line_number":16,"context_line":"it is the garbase, unfortunately."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"To prevent the situation, this patch adds a validation that"},{"line_number":19,"context_line":"the swift could decode the FAs correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_e36b3af0","line":16,"updated":"2015-05-26 11:00:32.000000000","message":"typo garbage","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"821cec6a4ecc6bbc3c95e4c5677a7e421e33f7cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, in the such a case, current Swift would return the garbage"},{"line_number":15,"context_line":"(i.e. decorded but incorrect object) and user might not find the fact"},{"line_number":16,"context_line":"it is the garbase, unfortunately."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"To prevent the situation, this patch adds a validation that"},{"line_number":19,"context_line":"the swift could decode the FAs correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_2208fed8","line":16,"in_reply_to":"7a016987_e36b3af0","updated":"2015-05-27 11:46:44.000000000","message":"will fix","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a699c286be7ac0242bf16c7d62dced378108bdf7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(i.e. decorded but incorrect object) and user might not find the fact"},{"line_number":16,"context_line":"it is the garbase, unfortunately."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"To prevent the situation, this patch adds a validation that"},{"line_number":19,"context_line":"the swift could decode the FAs correctly."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"TODO: Create validater for other similar stuffs (e.g. ec_segment_size)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_837366e7","line":18,"updated":"2015-05-26 11:00:32.000000000","message":"To prevent THIS situation..","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"821cec6a4ecc6bbc3c95e4c5677a7e421e33f7cd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(i.e. decorded but incorrect object) and user might not find the fact"},{"line_number":16,"context_line":"it is the garbase, unfortunately."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"To prevent the situation, this patch adds a validation that"},{"line_number":19,"context_line":"the swift could decode the FAs correctly."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"TODO: Create validater for other similar stuffs (e.g. ec_segment_size)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_c2f92aca","line":18,"in_reply_to":"7a016987_837366e7","updated":"2015-05-27 11:46:44.000000000","message":"will fix","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d1fb58815a131625a38337a331f8010e226cf391","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"                    resp.headers[\u0027X-Object-Sysmeta-EC-Scheme\u0027]"},{"line_number":1836,"context_line":"                    for resp in good_responses))"},{"line_number":1837,"context_line":"                if len(found_obj_schemes) \u003e 1 or \\"},{"line_number":1838,"context_line":"                        found_obj_schemes[0] !\u003d policy.ec_scheme_description:"},{"line_number":1839,"context_line":"                    self.app.logger.debug("},{"line_number":1840,"context_line":"                        \"Returning 503 for %s; found invalid ec scheme (%s)\","},{"line_number":1841,"context_line":"                        req.path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_4e547520","line":1838,"updated":"2015-05-26 11:33:34.000000000","message":"Why not compare to the whole list?","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a699c286be7ac0242bf16c7d62dced378108bdf7","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"                    resp.headers[\u0027X-Object-Sysmeta-EC-Scheme\u0027]"},{"line_number":1836,"context_line":"                    for resp in good_responses))"},{"line_number":1837,"context_line":"                if len(found_obj_schemes) \u003e 1 or \\"},{"line_number":1838,"context_line":"                        found_obj_schemes[0] !\u003d policy.ec_scheme_description:"},{"line_number":1839,"context_line":"                    self.app.logger.debug("},{"line_number":1840,"context_line":"                        \"Returning 503 for %s; found invalid ec scheme (%s)\","},{"line_number":1841,"context_line":"                        req.path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_432b2e95","line":1838,"updated":"2015-05-26 11:00:32.000000000","message":"Why we compare only with first element not entier list?","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"821cec6a4ecc6bbc3c95e4c5677a7e421e33f7cd","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"                    resp.headers[\u0027X-Object-Sysmeta-EC-Scheme\u0027]"},{"line_number":1836,"context_line":"                    for resp in good_responses))"},{"line_number":1837,"context_line":"                if len(found_obj_schemes) \u003e 1 or \\"},{"line_number":1838,"context_line":"                        found_obj_schemes[0] !\u003d policy.ec_scheme_description:"},{"line_number":1839,"context_line":"                    self.app.logger.debug("},{"line_number":1840,"context_line":"                        \"Returning 503 for %s; found invalid ec scheme (%s)\","},{"line_number":1841,"context_line":"                        req.path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_c2724a7c","line":1838,"in_reply_to":"7a016987_4e547520","updated":"2015-05-27 11:46:44.000000000","message":"I don\u0027t want take more than 1 different schemes to decode.\n\nIn this situation, L1837 checks the length of the list. If len(found_obj_schemes) \u003e 1, it will enter the inside of if condition before L1838 check so that what L1838 should check is just make sure the existing element on the list with length 1.","commit_id":"4645ae9791fa235f1104a80d792deade6b383aec"}]}
