)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9713e0daa61d4da5e0a109f256eab8103e039f57","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            # sub request for copy"},{"line_number":267,"context_line":"            path_info \u003d \u0027/v1/%s/%s/%s\u0027 % ("},{"line_number":268,"context_line":"                self.account_name, self.container_name, self.object_name)"},{"line_number":269,"context_line":"            sub_req \u003d Request.blank(path_info,"},{"line_number":270,"context_line":"                                    environ\u003dreq.environ.copy(),"},{"line_number":271,"context_line":"                                    headers\u003dreq.headers)"},{"line_number":272,"context_line":"            sub_req.environ[\u0027swift_versioned_copy\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_531cd776","line":269,"updated":"2015-05-07 14:59:01.000000000","message":"Why is the sub_req needed? Is it not sufficient to add the swift.post_as_copy var to the request env instead of adding to the query string?","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5c6008676942e6d11eedd10fbd5e4327be4ed35d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            # sub request for copy"},{"line_number":267,"context_line":"            path_info \u003d \u0027/v1/%s/%s/%s\u0027 % ("},{"line_number":268,"context_line":"                self.account_name, self.container_name, self.object_name)"},{"line_number":269,"context_line":"            sub_req \u003d Request.blank(path_info,"},{"line_number":270,"context_line":"                                    environ\u003dreq.environ.copy(),"},{"line_number":271,"context_line":"                                    headers\u003dreq.headers)"},{"line_number":272,"context_line":"            sub_req.environ[\u0027swift_versioned_copy\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_d364504a","line":269,"in_reply_to":"1aca2d91_531cd776","updated":"2015-05-08 01:07:41.000000000","message":"For the purpose to get rid of the query string, yes, what we have to do is just add the swift.post_as_copy as True.\n\nThe reason I changed this to use sub_req is to avoid the possibility that similar situation would happen in the future and  then to keep original request environment to be clean.\nThat is because basically POST and PUT (also COPY) are maintained separately, I think. When we use original request as well as previous one and then if PUT would be changed to use some queries for *PUT* use case, the queries would appear again at *POST* request even though it is just for *PUT*.","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9713e0daa61d4da5e0a109f256eab8103e039f57","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                                    environ\u003dreq.environ.copy(),"},{"line_number":271,"context_line":"                                    headers\u003dreq.headers)"},{"line_number":272,"context_line":"            sub_req.environ[\u0027swift_versioned_copy\u0027] \u003d True"},{"line_number":273,"context_line":"            sub_req.environ[\u0027swift.post_as_copy\u0027] \u003d True"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            sub_req.headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":276,"context_line":"            sub_req.headers[\u0027X-Copy-From\u0027] \u003d quote("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_b307ab1b","line":273,"updated":"2015-05-07 14:59:01.000000000","message":"I understand this part, but could it be done to original request?","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5c6008676942e6d11eedd10fbd5e4327be4ed35d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                                    environ\u003dreq.environ.copy(),"},{"line_number":271,"context_line":"                                    headers\u003dreq.headers)"},{"line_number":272,"context_line":"            sub_req.environ[\u0027swift_versioned_copy\u0027] \u003d True"},{"line_number":273,"context_line":"            sub_req.environ[\u0027swift.post_as_copy\u0027] \u003d True"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            sub_req.headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":276,"context_line":"            sub_req.headers[\u0027X-Copy-From\u0027] \u003d quote("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_93b818e7","line":273,"in_reply_to":"1aca2d91_b307ab1b","updated":"2015-05-08 01:07:41.000000000","message":"As I wrote above, yes it could be added to original request to remove the query.","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            sub_req.headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":276,"context_line":"            sub_req.headers[\u0027X-Copy-From\u0027] \u003d quote("},{"line_number":277,"context_line":"                \u0027/%s/%s\u0027 % (self.container_name, self.object_name))"},{"line_number":278,"context_line":"            sub_req.headers[\u0027X-Fresh-Metadata\u0027] \u003d \u0027true\u0027"},{"line_number":279,"context_line":"            resp \u003d self.PUT(sub_req)"},{"line_number":280,"context_line":"            # Older editions returned 202 Accepted on object POSTs, so we\u0027ll"},{"line_number":281,"context_line":"            # convert any 201 Created responses to that for compatibility with"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_603749b1","line":278,"updated":"2015-05-11 13:32:44.000000000","message":"seems like there is an opportunity to combine the function of swift.post_as_copy and X-Fresh-Metadata - personally I prefer the new swift.post_as_copy as having more obvious purpose than X-Fresh-Metadata.","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"18a206e74b469e31b085fb2511019aadf0c2e4e3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            sub_req.headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":276,"context_line":"            sub_req.headers[\u0027X-Copy-From\u0027] \u003d quote("},{"line_number":277,"context_line":"                \u0027/%s/%s\u0027 % (self.container_name, self.object_name))"},{"line_number":278,"context_line":"            sub_req.headers[\u0027X-Fresh-Metadata\u0027] \u003d \u0027true\u0027"},{"line_number":279,"context_line":"            resp \u003d self.PUT(sub_req)"},{"line_number":280,"context_line":"            # Older editions returned 202 Accepted on object POSTs, so we\u0027ll"},{"line_number":281,"context_line":"            # convert any 201 Created responses to that for compatibility with"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_7696fe95","line":278,"in_reply_to":"9af37de9_603749b1","updated":"2015-05-12 05:12:48.000000000","message":"I\u0027m not sure for now, X-Fresh-Metadata is used for any other use case but if x-fresh-metadata is used just for post as copy, combining seems better to me so I\u0027ll try to do so.","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        if not req.content_type_manually_set:"},{"line_number":580,"context_line":"            sink_req.headers[\u0027Content-Type\u0027] \u003d \\"},{"line_number":581,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":582,"context_line":"        if config_true_value("},{"line_number":583,"context_line":"                sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027)):"},{"line_number":584,"context_line":"            # post-as-copy: ignore new sysmeta, copy existing sysmeta"},{"line_number":585,"context_line":"            condition \u003d lambda k: is_sys_meta(\u0027object\u0027, k)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_00463d23","line":582,"updated":"2015-05-11 13:32:44.000000000","message":"could be if swift.post_as_copy in env ???","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69914e3b657ff8ba9cdaef02e6929c1fd3548940","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        fresh_meta_flag \u003d config_true_value("},{"line_number":578,"context_line":"            sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027))"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # TODO: make sure it would be really expected behaiver that"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_ba2a102b","line":578,"updated":"2015-05-12 12:26:57.000000000","message":"I\u0027m not sure why there is still a test for x-fresh-metadata - the change at line 271 means it is never set?\n\nOr were you thinking that client may have set the header ?? That would be *interesting*, I\u0027m not sure it is intended for clients but could it happen?? hmmm...perhaps it is best to leave it there as you have done.","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"8e7c0e0d566fc44e80a5d6c72d9f412a3ac7bd37","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        fresh_meta_flag \u003d config_true_value("},{"line_number":578,"context_line":"            sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027))"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # TODO: make sure it would be really expected behaiver that"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_843b4eeb","line":578,"in_reply_to":"9a0c5dc1_ba2a102b","updated":"2015-05-13 05:05:37.000000000","message":"x-fresh-metadata seems to be set by client. (It is asserted at Tempest) Please see the failed result on patch set 4 on gerrit gate. http://goo.gl/DN8UGI\n\nI\u0027m not sure but the handmade x-fresh-metadata use case seems not for POST but for COPY.\n\ne.g. when an user make a COPY (or PUT with X-Copy-From) request, the user could choose whether the existing user metadata should be copied or not by x-fresh-metadata. if setting \"x-fresh-metadata: true\", all existing user meta data will be deleted at the new copied object.","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69914e3b657ff8ba9cdaef02e6929c1fd3548940","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # TODO: make sure it would be really expected behaiver that"},{"line_number":582,"context_line":"            #       post_as_copy drops exisiting user metadata [kota_]"},{"line_number":583,"context_line":"            # post-as-copy: ignore new sysmeta, copy existing sysmeta"},{"line_number":584,"context_line":"            condition \u003d lambda k: is_sys_meta(\u0027object\u0027, k)"},{"line_number":585,"context_line":"            remove_items(sink_req.headers, condition)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_f5789b91","line":582,"updated":"2015-05-12 12:26:57.000000000","message":"An object POST always replaces *all* existing X-Object-Meta-* with whatever is sent with the POST request, so the existing behaviour here is correct.\n\nA COPY ( a normal COPY) updates existing X-Object-Meta-* items with values sent with the COPY http://developer.openstack.org/api-ref-objectstorage-v1.html#copyObject","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"8e7c0e0d566fc44e80a5d6c72d9f412a3ac7bd37","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # TODO: make sure it would be really expected behaiver that"},{"line_number":582,"context_line":"            #       post_as_copy drops exisiting user metadata [kota_]"},{"line_number":583,"context_line":"            # post-as-copy: ignore new sysmeta, copy existing sysmeta"},{"line_number":584,"context_line":"            condition \u003d lambda k: is_sys_meta(\u0027object\u0027, k)"},{"line_number":585,"context_line":"            remove_items(sink_req.headers, condition)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_0a5645d2","line":582,"in_reply_to":"9a0c5dc1_f5789b91","updated":"2015-05-13 05:05:37.000000000","message":"You\u0027re right at POST request. I deleted this TODO on the next patch set.\n\nHowever, as I described above, we seems to have to keep x-fresh-metadata here, and maybe we need to update the documentation of the COPY request. IMHO, the x-fresh-metadata seems to behave like as x-amz-metadata-directive on Amazon S3[1]. (tbh, I don\u0027t like to suggest S3 behavior on \"Swift\" discussion) \n\n1: http://goo.gl/OZuK9m","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"18ed2081182d0ffff1da60657a56d41218e9dc93","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        fresh_meta_flag \u003d config_true_value("},{"line_number":578,"context_line":"            sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027))"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # post-as-copy: ignore new sysmeta, copy existing sysmeta"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_ac1e2261","line":578,"updated":"2015-05-13 14:13:58.000000000","message":"is fresh_meta_flag still needed since it was removed in POST? where else would it be set?","commit_id":"377176432bd2d9cb90f4d893ca3ff35e5544c69e"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"834fa3a30e8548fc0f69cb6019bd5088f8d6af59","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        fresh_meta_flag \u003d config_true_value("},{"line_number":578,"context_line":"            sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027))"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"},{"line_number":581,"context_line":"            # post-as-copy: ignore new sysmeta, copy existing sysmeta"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_febf0e5e","line":578,"in_reply_to":"9a0c5dc1_ac1e2261","updated":"2015-05-13 20:02:23.000000000","message":"by client. Alistair asked me the same thing before :P\n\nPlease see the failed result on patch set 4 on gerrit gate. http://goo.gl/DN8UGI","commit_id":"377176432bd2d9cb90f4d893ca3ff35e5544c69e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"f9940f6560a4c1b1e2b53c342910a3379c8a5154","unresolved":false,"context_lines":[{"line_number":574,"context_line":"            sink_req.headers[\u0027Content-Type\u0027] \u003d \\"},{"line_number":575,"context_line":"                source_resp.headers[\u0027Content-Type\u0027]"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        fresh_meta_flag \u003d config_true_value("},{"line_number":578,"context_line":"            sink_req.headers.get(\u0027x-fresh-metadata\u0027, \u0027false\u0027))"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if fresh_meta_flag or \u0027swift.post_as_copy\u0027 in sink_req.environ:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_bb433b6c","line":577,"updated":"2015-05-14 05:31:22.000000000","message":"is x-fresh-metadata even used anymore","commit_id":"025c4c4339e7ace2f5be8cb3a3cddf6c38ceff37"}],"test/functional/tests.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":2336,"context_line":"        except ValueError:"},{"line_number":2337,"context_line":"            self.fail(\"COPY didn\u0027t copy the manifest (invalid json on GET)\")"},{"line_number":2338,"context_line":""},{"line_number":2339,"context_line":"    def test_slo_post_the_manifest_metadata_update(self):"},{"line_number":2340,"context_line":"        file_item \u003d self.env.container.file(\"manifest-abcde\")"},{"line_number":2341,"context_line":"        file_item.sync_metadata({\u0027x-object-meta-post\u0027: \u0027update\u0027})"},{"line_number":2342,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_602629bc","line":2339,"updated":"2015-05-11 13:32:44.000000000","message":"unfortunately these tests cause test_slo_ranged_get to fail (test coupling) on a cluster using post_as_copy\u003dfalse","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"        try:"},{"line_number":2346,"context_line":"            json.loads(updated_contents)"},{"line_number":2347,"context_line":"        except ValueError:"},{"line_number":2348,"context_line":"            self.fail(\"POST didn\u0027t copy the manifest (invalid json on GET)\")"},{"line_number":2349,"context_line":""},{"line_number":2350,"context_line":"    def test_slo_post_the_manifest_metadata_update_with_qs(self):"},{"line_number":2351,"context_line":"        file_item \u003d self.env.container.file(\"manifest-abcde\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_4d4fde92","line":2348,"updated":"2015-05-11 13:32:44.000000000","message":"Strictly a POST may not be expected to copy (ie fast POST) so maybe chabge the message to e.g. \"Unexpected content on GET, expected a json body\"","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"18a206e74b469e31b085fb2511019aadf0c2e4e3","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"        try:"},{"line_number":2346,"context_line":"            json.loads(updated_contents)"},{"line_number":2347,"context_line":"        except ValueError:"},{"line_number":2348,"context_line":"            self.fail(\"POST didn\u0027t copy the manifest (invalid json on GET)\")"},{"line_number":2349,"context_line":""},{"line_number":2350,"context_line":"    def test_slo_post_the_manifest_metadata_update_with_qs(self):"},{"line_number":2351,"context_line":"        file_item \u003d self.env.container.file(\"manifest-abcde\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_fb8e5726","line":2348,"in_reply_to":"9af37de9_4d4fde92","updated":"2015-05-12 05:12:48.000000000","message":"Done","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"                json.loads(updated_contents)"},{"line_number":2363,"context_line":"            except ValueError:"},{"line_number":2364,"context_line":"                self.fail("},{"line_number":2365,"context_line":"                    \"POST didn\u0027t copy the manifest (invalid json on GET)\")"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"    def test_slo_get_the_manifest(self):"},{"line_number":2368,"context_line":"        manifest \u003d self.env.container.file(\"manifest-abcde\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_ad588a57","line":2365,"updated":"2015-05-11 13:32:44.000000000","message":"ditto re message","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"18a206e74b469e31b085fb2511019aadf0c2e4e3","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"                json.loads(updated_contents)"},{"line_number":2363,"context_line":"            except ValueError:"},{"line_number":2364,"context_line":"                self.fail("},{"line_number":2365,"context_line":"                    \"POST didn\u0027t copy the manifest (invalid json on GET)\")"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"    def test_slo_get_the_manifest(self):"},{"line_number":2368,"context_line":"        manifest \u003d self.env.container.file(\"manifest-abcde\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_1baa4b71","line":2365,"in_reply_to":"9af37de9_ad588a57","updated":"2015-05-12 05:12:48.000000000","message":"Done","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69914e3b657ff8ba9cdaef02e6929c1fd3548940","unresolved":false,"context_lines":[{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"    def test_slo_post_the_manifest_metadata_update(self):"},{"line_number":2369,"context_line":"        file_item \u003d self.env.container.file(\"manifest-post\")"},{"line_number":2370,"context_line":"        file_item.sync_metadata({\u0027x-object-meta-post\u0027: \u0027update\u0027})"},{"line_number":2371,"context_line":""},{"line_number":2372,"context_line":"        updated \u003d self.env.container.file(\"manifest-post\")"},{"line_number":2373,"context_line":"        updated_contents \u003d updated.read(parms\u003d{\u0027multipart-manifest\u0027: \u0027get\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_6d55ffc4","line":2370,"updated":"2015-05-12 12:26:57.000000000","message":"with fast-post (bug) this causes the manifest to lose its X-Static-Large-Object....","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"8e7c0e0d566fc44e80a5d6c72d9f412a3ac7bd37","unresolved":false,"context_lines":[{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"    def test_slo_post_the_manifest_metadata_update(self):"},{"line_number":2369,"context_line":"        file_item \u003d self.env.container.file(\"manifest-post\")"},{"line_number":2370,"context_line":"        file_item.sync_metadata({\u0027x-object-meta-post\u0027: \u0027update\u0027})"},{"line_number":2371,"context_line":""},{"line_number":2372,"context_line":"        updated \u003d self.env.container.file(\"manifest-post\")"},{"line_number":2373,"context_line":"        updated_contents \u003d updated.read(parms\u003d{\u0027multipart-manifest\u0027: \u0027get\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_aa0a99d0","line":2370,"in_reply_to":"9a0c5dc1_6d55ffc4","updated":"2015-05-13 05:05:37.000000000","message":"whoops, exactly. I didn\u0027t notice because we don\u0027t have the assertion for the x-static-large-object :P\n\nNice catch!","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69914e3b657ff8ba9cdaef02e6929c1fd3548940","unresolved":false,"context_lines":[{"line_number":2377,"context_line":"            self.fail(\"Unexpected content on GET, expected a json body\")"},{"line_number":2378,"context_line":""},{"line_number":2379,"context_line":"    def test_slo_post_the_manifest_metadata_update_with_qs(self):"},{"line_number":2380,"context_line":"        file_item \u003d self.env.container.file(\"manifest-post\")"},{"line_number":2381,"context_line":""},{"line_number":2382,"context_line":"        # multipart-manifest query should be ignored on post"},{"line_number":2383,"context_line":"        for verb in (\u0027put\u0027, \u0027get\u0027, \u0027delete\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a0c5dc1_0dd8c352","line":2380,"updated":"2015-05-12 12:26:57.000000000","message":"with fast-post, if test_slo_post_the_manifest_metadata_update has run, then file_item does not have X-Static-Large-Object :(\n\nThe test will need to re-create the manifest for each verb.","commit_id":"cb18d9658103df16b35629e06e8f42955e1dedff"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"18ed2081182d0ffff1da60657a56d41218e9dc93","unresolved":false,"context_lines":[{"line_number":2382,"context_line":"        try:"},{"line_number":2383,"context_line":"            json.loads(updated_contents)"},{"line_number":2384,"context_line":"        except ValueError:"},{"line_number":2385,"context_line":"            self.fail(\"Unexpected content on GET, expected a json body\")"},{"line_number":2386,"context_line":""},{"line_number":2387,"context_line":"    def test_slo_post_the_manifest_metadata_update_with_qs(self):"},{"line_number":2388,"context_line":"        # multipart-manifest query should be ignored on post"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_317debe7","line":2385,"updated":"2015-05-13 14:13:58.000000000","message":"would it make sense to add a couple of asserts here to make sure that you still have both headers x-static-large-object and x-object-meta-post ?","commit_id":"377176432bd2d9cb90f4d893ca3ff35e5544c69e"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"834fa3a30e8548fc0f69cb6019bd5088f8d6af59","unresolved":false,"context_lines":[{"line_number":2382,"context_line":"        try:"},{"line_number":2383,"context_line":"            json.loads(updated_contents)"},{"line_number":2384,"context_line":"        except ValueError:"},{"line_number":2385,"context_line":"            self.fail(\"Unexpected content on GET, expected a json body\")"},{"line_number":2386,"context_line":""},{"line_number":2387,"context_line":"    def test_slo_post_the_manifest_metadata_update_with_qs(self):"},{"line_number":2388,"context_line":"        # multipart-manifest query should be ignored on post"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_de0faadf","line":2385,"in_reply_to":"9a0c5dc1_317debe7","updated":"2015-05-13 20:02:23.000000000","message":"I\u0027d *like* to add the \u0027x-static-large-object\u0027 assertion here, but *cannot* for now because of bug 1453807. (on fast-post the x-static-large-object header will be missing)\n\nThe fix was posted as another patch set depended on this, here https://review.openstack.org/#/c/182564/\n\nHowever, we should add the assertion for \u0027x-object-meta-post\u0027. will fix.","commit_id":"377176432bd2d9cb90f4d893ca3ff35e5544c69e"}],"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            resp \u003d req.get_response(self.app)"},{"line_number":607,"context_line":"        self.assertEquals(resp.status_int, 202)"},{"line_number":608,"context_line":"        self.assertEquals(req.environ[\u0027QUERY_STRING\u0027], \u0027\u0027)"},{"line_number":609,"context_line":"        # post_as_copy does\u0027t touch original reqest"},{"line_number":610,"context_line":"        self.assertTrue(\u0027swift.post_as_copy\u0027 not in req.environ)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def test_POST_as_COPY_static_large_object(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_c03ef5b7","line":609,"updated":"2015-05-11 13:32:44.000000000","message":"nit s/does\u0027t/doesn\u0027t\u0027","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"18a206e74b469e31b085fb2511019aadf0c2e4e3","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            resp \u003d req.get_response(self.app)"},{"line_number":607,"context_line":"        self.assertEquals(resp.status_int, 202)"},{"line_number":608,"context_line":"        self.assertEquals(req.environ[\u0027QUERY_STRING\u0027], \u0027\u0027)"},{"line_number":609,"context_line":"        # post_as_copy does\u0027t touch original reqest"},{"line_number":610,"context_line":"        self.assertTrue(\u0027swift.post_as_copy\u0027 not in req.environ)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def test_POST_as_COPY_static_large_object(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_bbfd7f70","line":609,"in_reply_to":"9af37de9_c03ef5b7","updated":"2015-05-12 05:12:48.000000000","message":"Done","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            resp \u003d req.get_response(self.app)"},{"line_number":624,"context_line":"        self.assertEquals(resp.status_int, 202)"},{"line_number":625,"context_line":"        self.assertEquals(req.environ[\u0027QUERY_STRING\u0027], \u0027\u0027)"},{"line_number":626,"context_line":"        # post_as_copy does\u0027t touch original reqest"},{"line_number":627,"context_line":"        self.assertTrue(\u0027swift.post_as_copy\u0027 not in req.environ)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def test_POST_delete_at(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_a04bf158","line":626,"updated":"2015-05-11 13:32:44.000000000","message":"nit s/does\u0027t/doesn\u0027t\u0027","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"18a206e74b469e31b085fb2511019aadf0c2e4e3","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            resp \u003d req.get_response(self.app)"},{"line_number":624,"context_line":"        self.assertEquals(resp.status_int, 202)"},{"line_number":625,"context_line":"        self.assertEquals(req.environ[\u0027QUERY_STRING\u0027], \u0027\u0027)"},{"line_number":626,"context_line":"        # post_as_copy does\u0027t touch original reqest"},{"line_number":627,"context_line":"        self.assertTrue(\u0027swift.post_as_copy\u0027 not in req.environ)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def test_POST_delete_at(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_9b02bb6e","line":626,"in_reply_to":"9af37de9_a04bf158","updated":"2015-05-12 05:12:48.000000000","message":"Done","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b6009caf8aa128cc1172048bf7cba025545d95a0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self.assertEquals(resp.status_int, 202)"},{"line_number":625,"context_line":"        self.assertEquals(req.environ[\u0027QUERY_STRING\u0027], \u0027\u0027)"},{"line_number":626,"context_line":"        # post_as_copy does\u0027t touch original reqest"},{"line_number":627,"context_line":"        self.assertTrue(\u0027swift.post_as_copy\u0027 not in req.environ)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def test_POST_delete_at(self):"},{"line_number":630,"context_line":"        t \u003d str(int(time.time() + 100))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_c09395a2","line":627,"updated":"2015-05-11 13:32:44.000000000","message":"ditto - capture the subreq and verify as well","commit_id":"9f968c9a5683ed50a35375bedbea62ef43ef90cd"}]}
