)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"fc887e436b973428bc764118c2c874a40d23328b","unresolved":false,"context_lines":[{"line_number":2209,"context_line":"            # written as we do fragment archives in order to call the PUT a"},{"line_number":2210,"context_line":"            # success."},{"line_number":2211,"context_line":"            min_conns \u003d 2"},{"line_number":2212,"context_line":"            putters \u003d [p for p in putters if not p.failed]"},{"line_number":2213,"context_line":"            # ignore response etags, and quorum boolean"},{"line_number":2214,"context_line":"            statuses, reasons, bodies, _etags, _quorum \u003d \\"},{"line_number":2215,"context_line":"                self._get_put_responses(req, putters, len(nodes),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_4a923359","line":2212,"updated":"2015-05-12 02:08:22.000000000","message":"NIT: Not that this has anything to do with the current patch, but while looking more in depth at the code, the failed putters are removed, great, but _get_put_responses loops through as a part of it\u0027s logic and skips over them, so it isn\u0027t really required.. I.e we now loop through twice so no real benefit.. unless I\u0027m missing something.","commit_id":"c1eedbece1c34851b0a5ab5b9c081e6b1d715222"}],"test/unit/__init__.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"45a07be55cab2e37322b6b52e0f2388ea8081950","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                raise Exception(\u0027test\u0027)"},{"line_number":841,"context_line":"            if kwargs.get(\u0027raise_timeout_exc\u0027):"},{"line_number":842,"context_line":"                raise eventlet.Timeout()"},{"line_number":843,"context_line":"            self.status \u003d self._status.get_response_status()"},{"line_number":844,"context_line":"            return self"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"        def getexpect(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_1331a8ec","line":843,"updated":"2015-05-08 00:33:54.000000000","message":"I\u0027m always vaguely uncomfortable when stuff like this happens: on must call .getresponse() or else .getheaders() will traceback randomly with .status missing. Probably good enough for tests, however.","commit_id":"c1eedbece1c34851b0a5ab5b9c081e6b1d715222"}],"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"38cbc0cd72ff1a5880fb331e5731fe807e771786","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        self.app.post_quorum_timeout \u003d 0.01"},{"line_number":1412,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/v1/a/c/o\u0027, method\u003d\u0027PUT\u0027,"},{"line_number":1413,"context_line":"                                              body\u003d\u0027\u0027)"},{"line_number":1414,"context_line":"        # pleanty of slow commits"},{"line_number":1415,"context_line":"        response_sleep \u003d 5.0"},{"line_number":1416,"context_line":"        codes \u003d [FakeStatus(201, response_sleep\u003dresponse_sleep)"},{"line_number":1417,"context_line":"                 for i in range(self.replicas())]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_2f946be0","line":1414,"updated":"2015-05-07 00:26:23.000000000","message":"s/pleanty/plenty","commit_id":"90ff92872dc33a77f9f9e40154f8eff09236c5ab"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc8a2c5911946f3f354143813982f01b54202bd9","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        self.assertTrue(\u0027retrying\u0027 in error_lines[0])"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"    def test_PUT_with_slow_commits(self):"},{"line_number":1410,"context_line":"        # make this longer for than slow responses for the test to pass"},{"line_number":1411,"context_line":"        self.app.post_quorum_timeout \u003d 0.01"},{"line_number":1412,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/v1/a/c/o\u0027, method\u003d\u0027PUT\u0027,"},{"line_number":1413,"context_line":"                                              body\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_f80f3886","line":1410,"updated":"2015-05-13 13:18:16.000000000","message":"I don\u0027t understand this comment, even after removing what might be extraneous words ;) Should it be:\n\n  # make this longer than slow responses for the test to fail\n\nor should it just not be there?","commit_id":"c1eedbece1c34851b0a5ab5b9c081e6b1d715222"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"7f5deda24323344b19352454d8daa8f91569547a","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"        self.assertTrue(\u0027retrying\u0027 in error_lines[0])"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"    def test_PUT_with_slow_commits(self):"},{"line_number":1410,"context_line":"        # make this longer for than slow responses for the test to pass"},{"line_number":1411,"context_line":"        self.app.post_quorum_timeout \u003d 0.01"},{"line_number":1412,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/v1/a/c/o\u0027, method\u003d\u0027PUT\u0027,"},{"line_number":1413,"context_line":"                                              body\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_213307f8","line":1410,"in_reply_to":"9a0c5dc1_f80f3886","updated":"2015-05-20 00:56:34.000000000","message":"Ya, test seems to fail just fine (with the part of this patch that fixes the bug reverted).","commit_id":"c1eedbece1c34851b0a5ab5b9c081e6b1d715222"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc8a2c5911946f3f354143813982f01b54202bd9","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        self.app.post_quorum_timeout \u003d 0.01"},{"line_number":1412,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/v1/a/c/o\u0027, method\u003d\u0027PUT\u0027,"},{"line_number":1413,"context_line":"                                              body\u003d\u0027\u0027)"},{"line_number":1414,"context_line":"        # pleanty of slow commits"},{"line_number":1415,"context_line":"        response_sleep \u003d 5.0"},{"line_number":1416,"context_line":"        codes \u003d [FakeStatus(201, response_sleep\u003dresponse_sleep)"},{"line_number":1417,"context_line":"                 for i in range(self.replicas())]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_3864b047","line":1414,"updated":"2015-05-13 13:18:16.000000000","message":"nit s/pleanty/plenty/","commit_id":"c1eedbece1c34851b0a5ab5b9c081e6b1d715222"}]}