)]}'
{"swift/obj/server.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"83f1c1af3930d707d9e1b60c47b3e0f6873c40fb","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                request\u003drequest,"},{"line_number":447,"context_line":"                headers\u003d{\u0027X-Backend-Timestamp\u0027: orig_timestamp.internal})"},{"line_number":448,"context_line":"        metadata \u003d {\u0027X-Timestamp\u0027: req_timestamp.internal}"},{"line_number":449,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":450,"context_line":"            metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":451,"context_line":"                             orig_metadata[\u0027X-Static-Large-Object\u0027]})"},{"line_number":452,"context_line":"        metadata.update(val for val in request.headers.iteritems()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_49c5463a","line":449,"updated":"2015-06-03 15:34:16.000000000","message":"I know it sounds excessively nitpicky, but could you factor the \u0027X-Static-Large-Object\u0027 like it\u0027s done with \u0027x-backend-container-update-override-\u0027 in _check_container_override? Purely for prettiness.","commit_id":"bfb2c10fdf424e6728d661e2b0d590f5e4ee1e17"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"a74fec59c5d423c750524d9c004ca7d0246bfe1a","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                request\u003drequest,"},{"line_number":447,"context_line":"                headers\u003d{\u0027X-Backend-Timestamp\u0027: orig_timestamp.internal})"},{"line_number":448,"context_line":"        metadata \u003d {\u0027X-Timestamp\u0027: req_timestamp.internal}"},{"line_number":449,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":450,"context_line":"            metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":451,"context_line":"                             orig_metadata[\u0027X-Static-Large-Object\u0027]})"},{"line_number":452,"context_line":"        metadata.update(val for val in request.headers.iteritems()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_56b6523e","line":449,"in_reply_to":"5afe65bd_49c5463a","updated":"2015-06-05 05:13:31.000000000","message":"Sure, sounds good will fix it soon.","commit_id":"bfb2c10fdf424e6728d661e2b0d590f5e4ee1e17"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6fce862e40b349c2c040795e328bcc5cf8fe0bce","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                override \u003d key.lower().replace(override_prefix, \u0027x-\u0027)"},{"line_number":418,"context_line":"                update_headers[override] \u003d val"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _check_slo_manifest(self, update_metadata, orig_metadata):"},{"line_number":421,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":422,"context_line":"            update_metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":423,"context_line":"                                    orig_metadata[\u0027X-Static-Large-Object\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_5fb40af1","line":420,"updated":"2015-08-18 12:44:03.000000000","message":"nit: the name of the method could emphasize its purpose e.g.:\n\n  _preserve_slo_manifest","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1bcaf330b9feafd2c29474ca793901e4e749cff7","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                override \u003d key.lower().replace(override_prefix, \u0027x-\u0027)"},{"line_number":418,"context_line":"                update_headers[override] \u003d val"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _check_slo_manifest(self, update_metadata, orig_metadata):"},{"line_number":421,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":422,"context_line":"            update_metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":423,"context_line":"                                    orig_metadata[\u0027X-Static-Large-Object\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_abd73d22","line":420,"in_reply_to":"fa1b9901_5fb40af1","updated":"2015-08-23 11:27:30.000000000","message":"good thought, will fix.","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6fce862e40b349c2c040795e328bcc5cf8fe0bce","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    def _check_slo_manifest(self, update_metadata, orig_metadata):"},{"line_number":421,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":422,"context_line":"            update_metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":423,"context_line":"                                    orig_metadata[\u0027X-Static-Large-Object\u0027]})"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    @public"},{"line_number":426,"context_line":"    @timing_stats()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_5f0f2ae1","line":423,"updated":"2015-08-18 12:44:03.000000000","message":"nit: update method not required, could be :\n\n  update_metadata[\u0027X-Static-Large-Object\u0027] \u003d orig_metadata[\u0027X-Static-Large-Object\u0027]","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1bcaf330b9feafd2c29474ca793901e4e749cff7","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    def _check_slo_manifest(self, update_metadata, orig_metadata):"},{"line_number":421,"context_line":"        if \u0027X-Static-Large-Object\u0027 in orig_metadata:"},{"line_number":422,"context_line":"            update_metadata.update({\u0027X-Static-Large-Object\u0027:"},{"line_number":423,"context_line":"                                    orig_metadata[\u0027X-Static-Large-Object\u0027]})"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    @public"},{"line_number":426,"context_line":"    @timing_stats()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_2b1d6d0f","line":423,"in_reply_to":"fa1b9901_5f0f2ae1","updated":"2015-08-23 11:27:30.000000000","message":"yup, will fix.","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"}],"test/functional/tests.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6fce862e40b349c2c040795e328bcc5cf8fe0bce","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"        updated.info()"},{"line_number":2436,"context_line":"        updated.header_fields([(\u0027user-meta\u0027, \u0027x-object-meta-post\u0027)])  # sanity"},{"line_number":2437,"context_line":"        updated_contents \u003d updated.read(parms\u003d{\u0027multipart-manifest\u0027: \u0027get\u0027})"},{"line_number":2438,"context_line":"        updated.info()"},{"line_number":2439,"context_line":"        updated.header_fields([(\u0027slo\u0027, \u0027x-static-large-object\u0027)])"},{"line_number":2440,"context_line":"        try:"},{"line_number":2441,"context_line":"            json.loads(updated_contents)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_da1a6817","line":2438,"updated":"2015-08-18 12:44:03.000000000","message":"i don\u0027t think this info() is needed, we have done a .info at line 2435.\n\nperhaps just put line 2439 after line 2436","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1bcaf330b9feafd2c29474ca793901e4e749cff7","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"        updated.info()"},{"line_number":2436,"context_line":"        updated.header_fields([(\u0027user-meta\u0027, \u0027x-object-meta-post\u0027)])  # sanity"},{"line_number":2437,"context_line":"        updated_contents \u003d updated.read(parms\u003d{\u0027multipart-manifest\u0027: \u0027get\u0027})"},{"line_number":2438,"context_line":"        updated.info()"},{"line_number":2439,"context_line":"        updated.header_fields([(\u0027slo\u0027, \u0027x-static-large-object\u0027)])"},{"line_number":2440,"context_line":"        try:"},{"line_number":2441,"context_line":"            json.loads(updated_contents)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_2be48d0b","line":2438,"in_reply_to":"fa1b9901_da1a6817","updated":"2015-08-23 11:27:30.000000000","message":"Exactly, I\u0027ll get rid of redundant info() (of course L2461, too), thanks!","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6fce862e40b349c2c040795e328bcc5cf8fe0bce","unresolved":false,"context_lines":[{"line_number":2458,"context_line":"                [(\u0027user-meta\u0027, \u0027x-object-meta-post\u0027)])  # sanity"},{"line_number":2459,"context_line":"            updated_contents \u003d updated.read("},{"line_number":2460,"context_line":"                parms\u003d{\u0027multipart-manifest\u0027: \u0027get\u0027})"},{"line_number":2461,"context_line":"            updated.info()"},{"line_number":2462,"context_line":"            updated.header_fields([(\u0027slo\u0027, \u0027x-static-large-object\u0027)])"},{"line_number":2463,"context_line":"            try:"},{"line_number":2464,"context_line":"                json.loads(updated_contents)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_7ae23c05","line":2461,"updated":"2015-08-18 12:44:03.000000000","message":"ditto - don\u0027t need extra .info","commit_id":"03431732c6c539c9732619ed1afc845214bd4169"}]}