)]}'
{"swift/container/server.py":[{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"7d72974ce4508b24410757c2f0c426e9e52ae096","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        account_hosts \u003d req.headers.get(\u0027X-Account-Host\u0027, \u0027\u0027)"},{"line_number":102,"context_line":"        account_devices \u003d req.headers.get(\u0027X-Account-Device\u0027, \u0027\u0027)"},{"line_number":103,"context_line":"        account_partition \u003d req.headers.get(\u0027X-Account-Partition\u0027, \u0027\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        updates \u003d [upd for upd in"},{"line_number":106,"context_line":"                   zip((h.strip() for h in account_hosts.split(\u0027,\u0027)),"},{"line_number":107,"context_line":"                       (c.strip() for c in account_devices.split(\u0027,\u0027)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0XA%3D","line":104,"updated":"2013-01-03 23:00:27.000000000","message":"Would be nice to have a comment here, as the following can be tough to follow and discern the assumptions and intent","commit_id":"38783cd8df79cc61a971582a92a9b41a2a515785"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"219d10c5e0bcd37d7980446b6bee8941a762ea8d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        account_devices \u003d req.headers.get(\u0027X-Account-Device\u0027, \u0027\u0027)"},{"line_number":103,"context_line":"        account_partition \u003d req.headers.get(\u0027X-Account-Partition\u0027, \u0027\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        updates \u003d [upd for upd in"},{"line_number":106,"context_line":"                   zip((h.strip() for h in account_hosts.split(\u0027,\u0027)),"},{"line_number":107,"context_line":"                       (c.strip() for c in account_devices.split(\u0027,\u0027)))"},{"line_number":108,"context_line":"                   if all(upd) and account_partition]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0VA%3D","line":105,"updated":"2013-01-03 22:30:54.000000000","message":"I think that udp checks and strips could be done in the next for loop, that would remove an extra iteration. Right now, it iterates over the ziped lists and checks whether all tuples in that zip validate to True, then it iterates again in line 112 over a (maybe) smaller list.\n\nWouldn\u0027t it be better (and more explicit) to check if account_host and account_device validate inside the lopp at line 112? (strip could also be moved down there)","commit_id":"38783cd8df79cc61a971582a92a9b41a2a515785"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"219d10c5e0bcd37d7980446b6bee8941a762ea8d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        updates \u003d [upd for upd in"},{"line_number":106,"context_line":"                   zip((h.strip() for h in account_hosts.split(\u0027,\u0027)),"},{"line_number":107,"context_line":"                       (c.strip() for c in account_devices.split(\u0027,\u0027)))"},{"line_number":108,"context_line":"                   if all(upd) and account_partition]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        account_404s \u003d 0"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0Ug%3D","line":108,"updated":"2013-01-03 22:30:54.000000000","message":"Perhaps we should just check if account_partition validates to True before doing this, from what I see, if account_partition is False there wont be any loop because updates will be empty","commit_id":"38783cd8df79cc61a971582a92a9b41a2a515785"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"8b175daffb0f8359f0cb55d9a76bee21f1a8025f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        updates \u003d [upd for upd in"},{"line_number":106,"context_line":"                   zip((h.strip() for h in account_hosts.split(\u0027,\u0027)),"},{"line_number":107,"context_line":"                       (c.strip() for c in account_devices.split(\u0027,\u0027)))"},{"line_number":108,"context_line":"                   if all(upd) and account_partition]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        account_404s \u003d 0"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0SU%3D","line":108,"in_reply_to":"AAAAM3%2F%2F0Ug%3D","updated":"2013-01-07 20:06:21.000000000","message":"In the grand scheme of things, it isn\u0027t *that* big of a deal.  If the lists were huge, or costly to generate, then I would say yes, but as is, it isn\u0027t a huge impact.","commit_id":"38783cd8df79cc61a971582a92a9b41a2a515785"}],"swift/obj/server.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"219d10c5e0bcd37d7980446b6bee8941a762ea8d","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        contdevices \u003d headers_in.get(\u0027X-Container-Device\u0027, \u0027\u0027)"},{"line_number":498,"context_line":"        partition \u003d headers_in.get(\u0027X-Container-Partition\u0027, \u0027\u0027)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        updates \u003d [upd for upd in"},{"line_number":501,"context_line":"                   zip((h.strip() for h in hosts.split(\u0027,\u0027)),"},{"line_number":502,"context_line":"                       (c.strip() for c in contdevices.split(\u0027,\u0027)))"},{"line_number":503,"context_line":"                   if all(upd) and partition]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0Uw%3D","line":500,"updated":"2013-01-03 22:30:54.000000000","message":"pls, read my comment at line 105 (server.py)","commit_id":"38783cd8df79cc61a971582a92a9b41a2a515785"}]}