)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"049de8ec096fae2449805a02a493226616b0824b","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                    pass"},{"line_number":629,"context_line":"                # we just deleted this hsh_path, why are we waiting"},{"line_number":630,"context_line":"                # until the next suffix hash to raise PathNotDir so that"},{"line_number":631,"context_line":"                # this suffix will get del\u0027d from the suffix hashes?"},{"line_number":632,"context_line":"            for filename in files:"},{"line_number":633,"context_line":"                key, value \u003d mapper(filename)"},{"line_number":634,"context_line":"                hashes[key].update(value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_0a3e0eb8","side":"PARENT","line":631,"updated":"2015-07-22 08:43:16.000000000","message":"heh, i guess this comment is less relevant now\n\nI\u0027ll wait to see what happens with the upstream patch - maybe torgomatic will take this back over...","commit_id":"e7341a0c309c081b0d192d0248867d90c4b642ec"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"34bf6d2ae36438ca89cf32ce25460a523aba23bb","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        else:"},{"line_number":638,"context_line":"            # if we remove it, pretend like it wasn\u0027t there to begin with so"},{"line_number":639,"context_line":"            # that the suffix key gets removed"},{"line_number":640,"context_line":"            raise PathNotDir()"},{"line_number":641,"context_line":"        return hashes"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def _hash_suffix(self, path, reclaim_age):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_32343f48","line":640,"updated":"2015-08-07 04:02:51.000000000","message":"Successful remove will raise an error and it will be handled at _get_hashes to remove the suffix from hashes dict. Great, it makes me sense.\n\nJust small nits but I am wondering if the exception name should be \"PathNotDir\"? Seems something like \"EmptyDir\"?\n\nHowever, it is not a blocker. It might be only me to think so.","commit_id":"44917c8a90e79a85cd6c6821d8b6d043f83b322d"}]}