)]}'
{"swift/common/manager.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"207978aec918c75a7ef2653f57c6d5cf2fb6ec08","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        pids \u003d {}"},{"line_number":515,"context_line":"        for pid_file, pid in self.iter_pid_files(**kwargs):"},{"line_number":516,"context_line":"            if not pid:  # Catches None and 0"},{"line_number":517,"context_line":"                print _(\u0027Removing pid file %s with invalid pid\u0027)"},{"line_number":518,"context_line":"                remove_file(pid_file)"},{"line_number":519,"context_line":"                continue"},{"line_number":520,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_4cb7aad8","line":517,"updated":"2015-06-03 05:22:25.000000000","message":"Functional testing revealed a raw \"%s\" in output... missing formatting.","commit_id":"2f833ec13461042e28744d39e303739e37e3dc46"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"c7fc61892a39c0fde14b748ed4822ef114a09e16","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        \"\"\""},{"line_number":514,"context_line":"        pids \u003d {}"},{"line_number":515,"context_line":"        for pid_file, pid in self.iter_pid_files(**kwargs):"},{"line_number":516,"context_line":"            if not pid:  # Catches None and 0"},{"line_number":517,"context_line":"                print _(\u0027Removing pid file %s with invalid pid\u0027) % pid_file"},{"line_number":518,"context_line":"                remove_file(pid_file)"},{"line_number":519,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_f2602dd1","line":516,"updated":"2015-07-09 04:53:06.000000000","message":"Thank you for not making me wonder if you meant to catch 0. :)","commit_id":"e860ec138913dc4c450725766a77e76a7101d06e"}],"test/unit/common/test_manager.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e769abd2c52e8dc9728fd8887f93e0e8c9b16ee5","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                    pids \u003d server.signal_pids(signal.SIG_DFL, verbose\u003dTrue)"},{"line_number":768,"context_line":"                    output \u003d pop_stream(f)"},{"line_number":769,"context_line":"                    old_stdout.write(\u0027output %s\u0027 % output)"},{"line_number":770,"context_line":"                    self.assert_(\u0027with invalid pid\u0027 in output.lower())"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"                    server \u003d manager.Server(\u0027invalid-server\u0027,"},{"line_number":773,"context_line":"                                            run_dir\u003dmanager.RUN_DIR)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9dcfbb7e","line":770,"updated":"2015-05-29 11:19:42.000000000","message":"Should we check the pid file existence like as:\n\nhttp://paste.openstack.org/show/244620/","commit_id":"7a780499f1acbb9ec28f92960c83f1b856e60f84"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c5c016a740e6a92e9c39d8b22d1fe0be028b96fd","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                    output \u003d pop_stream(f)"},{"line_number":769,"context_line":"                    old_stdout.write(\u0027output %s\u0027 % output)"},{"line_number":770,"context_line":"                    self.assert_(\u0027with invalid pid\u0027 in output.lower())"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"                    server \u003d manager.Server(\u0027invalid-server\u0027,"},{"line_number":773,"context_line":"                                            run_dir\u003dmanager.RUN_DIR)"},{"line_number":774,"context_line":"                    # test verbose warns on removing pid file with invalid pid"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_80ccee89","line":771,"updated":"2015-05-29 11:25:13.000000000","message":"I think you should add more tests. Overall, great job!","commit_id":"7a780499f1acbb9ec28f92960c83f1b856e60f84"}]}
