)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bb8c2903314e98c15c38392117e853902b4b3f5d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"In this case, at least 3 container updates are saved."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For another example:"},{"line_number":54,"context_line":"9 replicated objects, qurum_size\u003d4 (7//2+1), 3 replica for container."},{"line_number":55,"context_line":"CU: container update"},{"line_number":56,"context_line":"CA: commit ack (201s for successful PUT on replicated)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba15a1d1_2c5d6079","line":54,"updated":"2015-09-23 06:12:27.000000000","message":"There are 7 not 9 replicated objects... so s/9/7/","commit_id":"a297fd41f051e1d7e7d05e5f246626bd4a96403f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"8667ec226455d5f77a5e8923a7ecf1e6b045b85b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"In this case, at least 3 container updates are saved."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For another example:"},{"line_number":54,"context_line":"9 replicated objects, qurum_size\u003d4 (7//2+1), 3 replica for container."},{"line_number":55,"context_line":"CU: container update"},{"line_number":56,"context_line":"CA: commit ack (201s for successful PUT on replicated)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba15a1d1_f0791994","line":54,"in_reply_to":"ba15a1d1_2c5d6079","updated":"2015-09-23 22:15:11.000000000","message":"Ah, yeah. That\u0027s the rest I was rewriting commit message. Done!","commit_id":"a297fd41f051e1d7e7d05e5f246626bd4a96403f"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"83b706f91d024967934afbbc8f4318ef70d8444b","unresolved":false,"context_lines":[{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"    @classmethod"},{"line_number":1597,"context_line":"    def connect(cls, node, part, path, headers, conn_timeout, node_timeout,"},{"line_number":1598,"context_line":"                chunked\u003dFalse, container_update\u003dFalse):"},{"line_number":1599,"context_line":"        \"\"\""},{"line_number":1600,"context_line":"        Connect to a backend node and send the headers."},{"line_number":1601,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_951dfd74","line":1598,"updated":"2015-06-25 05:13:42.000000000","message":"we have headers in the signature here already - why not calculate it here rather than plumbing a new arg?","commit_id":"284dfec1c2b240f0d2aa09b5a51361003035eeac"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"83b706f91d024967934afbbc8f4318ef70d8444b","unresolved":false,"context_lines":[{"line_number":2204,"context_line":"            self._check_failure_put_connections(putters, req, nodes, min_conns)"},{"line_number":2205,"context_line":""},{"line_number":2206,"context_line":"            con_update_putters \u003d [p for p in putters if p.container_update]"},{"line_number":2207,"context_line":"            self._check_min_conn(req, con_update_putters, 2)"},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":"            self._transfer_data(req, policy, data_source, putters,"},{"line_number":2210,"context_line":"                                nodes, min_conns, etag_hasher)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_b504c117","line":2207,"updated":"2015-06-25 05:13:42.000000000","message":"# check the minimum number of connections with container updater headers were met and... return an error if we failed to connect to at least two of the three nodes we happened to pre-select to attach container headers too?\n\nI\u0027m not even sure I understand how this addresses the failure condition here - all of the outgoing_headers we get called with *will* be assigned to a *connected* node by _get_put_connections (unless we run out of nodes, we\u0027ll just dig for a handoff and put the failed connections set of headers on the handoff connection).  The question is if those three nodes that got the headers make it all the way to the end where we calculate quorum?  Because in a 10+4 we could easily drop them and still think we\u0027re successful.","commit_id":"284dfec1c2b240f0d2aa09b5a51361003035eeac"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bb8c2903314e98c15c38392117e853902b4b3f5d","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            i \u003d existing_updates"},{"line_number":305,"context_line":"            container \u003d next(container_iter)"},{"line_number":306,"context_line":"            set_container_update(i, container)"},{"line_number":307,"context_line":"            existing_updates +\u003d 1"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        for i, node in enumerate(delete_at_nodes or []):"},{"line_number":310,"context_line":"            i \u003d i % len(headers)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_17062e1c","line":307,"updated":"2015-09-23 06:12:27.000000000","message":"Because we are using itertools.cycle we\u0027ll never get a StopIteration, which means we should be able to simplify the above while statement to:\n\n  while existing_updates \u003c n_updates_needed:                                  \n      set_container_update(existing_updates, next(container_iter))             \n      existing_updates +\u003d 1","commit_id":"a297fd41f051e1d7e7d05e5f246626bd4a96403f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"8667ec226455d5f77a5e8923a7ecf1e6b045b85b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            i \u003d existing_updates"},{"line_number":305,"context_line":"            container \u003d next(container_iter)"},{"line_number":306,"context_line":"            set_container_update(i, container)"},{"line_number":307,"context_line":"            existing_updates +\u003d 1"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        for i, node in enumerate(delete_at_nodes or []):"},{"line_number":310,"context_line":"            i \u003d i % len(headers)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_f0d59942","line":307,"in_reply_to":"ba15a1d1_17062e1c","updated":"2015-09-23 22:15:11.000000000","message":"Nice catch, done!","commit_id":"a297fd41f051e1d7e7d05e5f246626bd4a96403f"}],"test/unit/__init__.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"19c19e2e2efa04d6d8b98ca53e3af08349772827","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.max_more_nodes \u003d max_more_nodes"},{"line_number":198,"context_line":"        self._part_shift \u003d 32 - part_power"},{"line_number":199,"context_line":"        # 9 total nodes (6 more past the initial 3) is the cap, no matter if"},{"line_number":200,"context_line":"        # this is set higher, or R^2 for R replicas"},{"line_number":201,"context_line":"        self.set_replicas(replicas)"},{"line_number":202,"context_line":"        self._reload()"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bff0334d_800ee02f","line":200,"updated":"2017-04-07 20:57:32.000000000","message":"I think the existing max_more_nodes default of 2 * replicas was better!","commit_id":"3f943cfcf2de26e51f1ace96f2c28a36ab105887"}],"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"225503e5f75ad385f0122c2b7630b07aaa606d67","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # artificially by the proxy max request node count"},{"line_number":170,"context_line":"        object_ring.max_more_nodes \u003d 100000"},{"line_number":171,"context_line":"        # nothing magic about * 2 + 3, just a way to make it bigger"},{"line_number":172,"context_line":"        self.app.request_node_count \u003d lambda r: object_ring.replicas * 2 + 3"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        all_nodes \u003d object_ring.get_part_nodes(1)"},{"line_number":175,"context_line":"        all_nodes.extend(object_ring.get_more_nodes(1))"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a1a9d01_1623f6be","line":172,"updated":"2015-09-25 08:00:03.000000000","message":"Might \"lamda r: r * 2 + 3\" be robust for ring changing?\n\nWill change later patch.","commit_id":"079484746111eeb2538a46f35cb720f640cdd4f5"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"225503e5f75ad385f0122c2b7630b07aaa606d67","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_DELETE_not_found(self):"},{"line_number":252,"context_line":"        if self.replicas() \u003d\u003d 1:"},{"line_number":253,"context_line":"            return"},{"line_number":254,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/v1/a/c/o\u0027, method\u003d\u0027DELETE\u0027)"},{"line_number":255,"context_line":"        codes \u003d [404] * (self.replicas() - 1) + [204]"},{"line_number":256,"context_line":"        with set_http_connect(*codes):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a1a9d01_964f0692","line":253,"updated":"2015-09-25 08:00:03.000000000","message":"I don\u0027t think we need to make the condition like this even if this test assume the default policy has more than 1 replica. I have an idea to prevent for setting the condition. Will change later patch.","commit_id":"079484746111eeb2538a46f35cb720f640cdd4f5"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"225503e5f75ad385f0122c2b7630b07aaa606d67","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                if num_containers \u003c\u003d self.quorum(policy):"},{"line_number":506,"context_line":"                    # filling case"},{"line_number":507,"context_line":"                    expected \u003d min(self.quorum(policy) + 1,"},{"line_number":508,"context_line":"                                   self.replicas(policy))"},{"line_number":509,"context_line":"                else:"},{"line_number":510,"context_line":"                    # container updates \u003e\u003d object replicas"},{"line_number":511,"context_line":"                    expected \u003d min(num_containers,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a1a9d01_53ec20c7","line":508,"updated":"2015-09-25 08:00:03.000000000","message":"Nice catch! When using 1-replica, we should expect the number of  container_updates headers is obviously 1.","commit_id":"079484746111eeb2538a46f35cb720f640cdd4f5"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"bc9dd0213fb56c4ccb42fb935116865c39335cb9","unresolved":false,"context_lines":[{"line_number":929,"context_line":"     StoragePolicy(2, \u00278-replica\u0027, False),"},{"line_number":930,"context_line":"     StoragePolicy(3, \u002715-replica\u0027, False)],"},{"line_number":931,"context_line":"    fake_ring_args\u003d["},{"line_number":932,"context_line":"        {\u0027replicas\u0027: 5}, {\u0027replicas\u0027: 1}, {\u0027replicas\u0027: 8}, {\u0027replicas\u0027: 15}])"},{"line_number":933,"context_line":"class TestReplicatedObjControllerVariousReplicas(BaseObjectControllerMixin,"},{"line_number":934,"context_line":"                                                 unittest.TestCase):"},{"line_number":935,"context_line":"    controller_cls \u003d obj.ReplicatedObjectController"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a1a9d01_e2aa2519","line":932,"updated":"2015-09-25 18:57:11.000000000","message":"I actually think that\u0027s a feature of this patch that it tests a 1-replica ring.\n\nIn fact, I\u0027d suggest that later we should add more types of rings to test and make sure the tests are looping over all the policies. (Not in this patch, though)","commit_id":"07d5e066c830602560972c1828ced219fbac86f9"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"225503e5f75ad385f0122c2b7630b07aaa606d67","unresolved":false,"context_lines":[{"line_number":3650,"context_line":"                    collected_nodes.append(node)"},{"line_number":3651,"context_line":"                self.assertEqual(len(collected_nodes), 5)"},{"line_number":3652,"context_line":""},{"line_number":3653,"context_line":"                object_ring.max_more_nodes \u003d 6"},{"line_number":3654,"context_line":"                self.app.request_node_count \u003d lambda r: 20"},{"line_number":3655,"context_line":"                partition, nodes \u003d object_ring.get_nodes(\u0027account\u0027,"},{"line_number":3656,"context_line":"                                                         \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a1a9d01_59467f24","line":3653,"updated":"2015-09-25 08:00:03.000000000","message":"This is caused from test/unit/__init__.py change, but seems ok to me.","commit_id":"079484746111eeb2538a46f35cb720f640cdd4f5"}]}
