)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"7570007517b78a92f0fbb1674c7cb35864006ed9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    # Use \u0027poll\u0027 when available"},{"line_number":40,"context_line":"    import eventlet.hubs.poll"},{"line_number":41,"context_line":"    HUB \u003d \"poll\""},{"line_number":42,"context_line":"except (ImportError, AttributeError):"},{"line_number":43,"context_line":"    # Eventlet raises an AttributeError"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F2hg%3D","line":40,"updated":"2013-01-02 13:27:45.000000000","message":"Perhaps an else clause could be added here to delete the import of the poll module that was just imported, since it is not used anywhere?\n\nSo, is there a documentation impact here? If the poll hub is not available, do we need to refer the user in the documentation to how an eventlet hub is chosen?","commit_id":"edec087352a72bf3ee40174c85f141fcce7db3ae"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"29f56bf4c75ebf09ee624a53652d39f33728bc45","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    # Use \u0027poll\u0027 when available"},{"line_number":40,"context_line":"    import eventlet.hubs.poll"},{"line_number":41,"context_line":"    HUB \u003d \"poll\""},{"line_number":42,"context_line":"except (ImportError, AttributeError):"},{"line_number":43,"context_line":"    # Eventlet raises an AttributeError"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F1rs%3D","line":40,"in_reply_to":"AAAAM3%2F%2F2E8%3D","updated":"2013-01-02 21:17:18.000000000","message":"I used a string for \"further\" usage purposes (just in case something like [\"if HUB \u003d\u003d ....\" ] is needed [I know there\u0027s a get_hub function]), but we could use the module instead.\n\nEventlet uses hasattr over the select module.","commit_id":"edec087352a72bf3ee40174c85f141fcce7db3ae"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9c0ba6fe0947c51786eebd5d042f6b40dc401da5","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    # Use \u0027poll\u0027 when available"},{"line_number":40,"context_line":"    import eventlet.hubs.poll"},{"line_number":41,"context_line":"    HUB \u003d \"poll\""},{"line_number":42,"context_line":"except (ImportError, AttributeError):"},{"line_number":43,"context_line":"    # Eventlet raises an AttributeError"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F2E8%3D","line":40,"in_reply_to":"AAAAM3%2F%2F2fo%3D","updated":"2013-01-02 17:49:56.000000000","message":"You can pass module in directly - it doesn\u0027t *have* to be a string.  You could also accept the AttributeError around use_hub and retry.  FWIW, currently eventlet\u0027s get_default_hub uses hasattr(eventlet.hubs, \u0027poll\u0027).","commit_id":"edec087352a72bf3ee40174c85f141fcce7db3ae"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cbf4bb77c58f77b7a7bf8ae06d088e888d7cc1a6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    # Use \u0027poll\u0027 when available"},{"line_number":40,"context_line":"    import eventlet.hubs.poll"},{"line_number":41,"context_line":"    HUB \u003d \"poll\""},{"line_number":42,"context_line":"except (ImportError, AttributeError):"},{"line_number":43,"context_line":"    # Eventlet raises an AttributeError"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F2fo%3D","line":40,"in_reply_to":"AAAAM3%2F%2F2hg%3D","updated":"2013-01-02 13:37:45.000000000","message":"I don\u0027t think it is necessary to remove the import since it is harmless, but I try / except in the use_hub call could be used instead of this try / except, the thing is that it is more explicit like this.\n\nYeap, documentation should be updated and refer that swift will use poll when available otherwise it will delegate the hub selection to eventlet (maybe we should just point to eventlet\u0027s documentation since it might change in the future).","commit_id":"edec087352a72bf3ee40174c85f141fcce7db3ae"}]}