)]}'
{"swift/common/middleware/tempauth.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a8e1388271ee6b86793c536e320f0ae015992a93","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self.auth_prefix \u003d \u0027/\u0027 + self.auth_prefix"},{"line_number":84,"context_line":"        if self.auth_prefix[-1] !\u003d \u0027/\u0027:"},{"line_number":85,"context_line":"            self.auth_prefix +\u003d \u0027/\u0027"},{"line_number":86,"context_line":"        if len(self.auth_prefix) \u003d\u003d 1:"},{"line_number":87,"context_line":"            raise ValueError(\u0027Invalid Auth Prefix(Too Short)\u0027)"},{"line_number":88,"context_line":"        self.token_life \u003d int(conf.get(\u0027token_life\u0027, 86400))"},{"line_number":89,"context_line":"        self.allow_overrides \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fxbc%3D","line":86,"updated":"2013-01-06 09:22:48.000000000","message":"Perhaps, we should check if self.auth_prefix is equal \"/\", it\u0027d make code more explicit and clear for others.","commit_id":"a694247d2cbbfcbd9acef67e9c30e0736858cc1d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a8e1388271ee6b86793c536e320f0ae015992a93","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self.auth_prefix[-1] !\u003d \u0027/\u0027:"},{"line_number":85,"context_line":"            self.auth_prefix +\u003d \u0027/\u0027"},{"line_number":86,"context_line":"        if len(self.auth_prefix) \u003d\u003d 1:"},{"line_number":87,"context_line":"            raise ValueError(\u0027Invalid Auth Prefix(Too Short)\u0027)"},{"line_number":88,"context_line":"        self.token_life \u003d int(conf.get(\u0027token_life\u0027, 86400))"},{"line_number":89,"context_line":"        self.allow_overrides \u003d config_true_value("},{"line_number":90,"context_line":"            conf.get(\u0027allow_overrides\u0027, \u0027t\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fxbg%3D","line":87,"updated":"2013-01-06 09:22:48.000000000","message":"Perhaps, we should make the error message more explicit, something like:\n\n\"Invalid Auth Prefix %s\" % self.auth_prefix","commit_id":"a694247d2cbbfcbd9acef67e9c30e0736858cc1d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71657a821412b8a9b6c3670eab121fa952958d1c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.reseller_prefix if self.reseller_prefix else \u0027NONE\u0027,))"},{"line_number":79,"context_line":"        self.auth_prefix \u003d conf.get(\u0027auth_prefix\u0027, \u0027/auth/\u0027)"},{"line_number":80,"context_line":"        if not self.auth_prefix:"},{"line_number":81,"context_line":"            self.auth_prefix \u003d \u0027/auth/\u0027"},{"line_number":82,"context_line":"        if self.auth_prefix[0] !\u003d \u0027/\u0027:"},{"line_number":83,"context_line":"            self.auth_prefix \u003d \u0027/\u0027 + self.auth_prefix"},{"line_number":84,"context_line":"        if self.auth_prefix[-1] !\u003d \u0027/\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fvxc%3D","side":"PARENT","line":81,"updated":"2013-01-07 20:38:23.000000000","message":"What about changing the check here to\n\n    if not auth_prefix.strip(\u0027/\u0027):\n\n?\n\nThis would also catch auth_prefix \u003d \u0027//\u0027 and maybe helps convey that a \"Non-empty auth prefix path is required.\"\n\nNot sure about rewriting the config option as \u0027/auth/\u0027 here... Maybe the idea is we don\u0027t want the entire proxy to just refuse to load?  If we want to support current behavior, would it be ok to just log a warning?","commit_id":"6e9b1a52a593f4f2a1d085d9c65422934a99571f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"98ea4194abcb290d159ac1b5945aef8c434170a6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self.auth_prefix[-1] !\u003d \u0027/\u0027:"},{"line_number":85,"context_line":"            self.auth_prefix +\u003d \u0027/\u0027"},{"line_number":86,"context_line":"        if self.auth_prefix \u003d\u003d \u0027/\u0027:"},{"line_number":87,"context_line":"            raise ValueError(\u0027Invalid Auth Prefix %s\u0027 % self.auth_prefix)"},{"line_number":88,"context_line":"        self.token_life \u003d int(conf.get(\u0027token_life\u0027, 86400))"},{"line_number":89,"context_line":"        self.allow_overrides \u003d config_true_value("},{"line_number":90,"context_line":"            conf.get(\u0027allow_overrides\u0027, \u0027t\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fwy8%3D","line":87,"updated":"2013-01-07 08:44:15.000000000","message":"Since we know exactly why this url is invalid, we should explicit it somehow. Could you please add it to the error message? Otherwise, users might not know why the url is invalid and start looking around (irc, m-l, etc) for a reason.","commit_id":"5ef7a147e246972a7f922994502a31561a49404b"}]}