)]}'
{"doc/source/replication_network.rst":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        swift-ring-builder object.builder set_info --rsync-port 873 --change-rsync-port 900"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"#. Write new ring::"},{"line_number":524,"context_line":"        swift-ring-builder object.builder write_ring"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa1b9901_fd741cd0","line":524,"updated":"2015-08-18 03:44:01.000000000","message":"Yeah this was great!  On a swift-all-in-one:\n\n  # set it to 900\n  for ring in account container object; do\n    swift-ring-builder /etc/swift/${ring}.builder set_info --ip 127.0.0.1 --change-rsync-port 900\n    swift-ring-builder /etc/swift/${ring}.builder write_ring\n  done\n\n  # put it back to default\n  for ring in account container object; do\n    swift-ring-builder /etc/swift/${ring}.builder set_info --ip 127.0.0.1 --change-rsync-port 873\n    swift-ring-builder /etc/swift/${ring}.builder write_ring\n  done","commit_id":"25d65d41890b9734ea192865a284e83925054201"}],"swift/cli/ringbuilder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if \u0027:\u0027 in copy_dev[key]:"},{"line_number":58,"context_line":"            copy_dev[key] \u003d \u0027[\u0027 + copy_dev[key] + \u0027]\u0027"},{"line_number":59,"context_line":"    return (\u0027d%(id)sr%(region)sz%(zone)s-%(ip)s:%(port)sR\u0027"},{"line_number":60,"context_line":"            \u0027%(replication_ip)s:%(replication_port)sy\u0027"},{"line_number":61,"context_line":"            \u0027%(rsync_port)s/%(device)s_\u0027"},{"line_number":62,"context_line":"            \u0027\"%(meta)s\"\u0027 % copy_dev)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_dd72787c","line":60,"updated":"2015-08-18 03:44:01.000000000","message":"nit: I think the literal y here is not a great separator, a second \u0027:\u0027 I think would look pretty good.","commit_id":"25d65d41890b9734ea192865a284e83925054201"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":486,"context_line":"swift-ring-builder \u003cbuilder_file\u003e search"},{"line_number":487,"context_line":"    --region \u003cregion\u003e --zone \u003czone\u003e --ip \u003cip or hostname\u003e --port \u003cport\u003e"},{"line_number":488,"context_line":"    --replication-ip \u003cr_ip or r_hostname\u003e --replication-port \u003cr_port\u003e"},{"line_number":489,"context_line":"    --rsync-port \u003cy_port\u003e --device \u003cdevice_name\u003e --meta \u003cmeta\u003e"},{"line_number":490,"context_line":"    --weight \u003cweight\u003e"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    Where \u003cr_ip\u003e, \u003cr_hostname\u003e and \u003cr_port\u003e are replication ip, hostname"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_9d908097","line":489,"updated":"2015-08-18 03:44:01.000000000","message":"nit I think s_port would be good too - maybe better?","commit_id":"25d65d41890b9734ea192865a284e83925054201"}],"swift/common/ring/builder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":1488,"context_line":"                if \u0027ip\u0027 in dev:"},{"line_number":1489,"context_line":"                    dev.setdefault(\u0027replication_ip\u0027, dev[\u0027ip\u0027])"},{"line_number":1490,"context_line":"                if \u0027port\u0027 in dev:"},{"line_number":1491,"context_line":"                    dev.setdefault(\u0027replication_port\u0027, dev[\u0027port\u0027])"},{"line_number":1492,"context_line":"        return builder"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    def save(self, builder_file):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_bd5f840d","side":"PARENT","line":1491,"updated":"2015-08-18 03:44:01.000000000","message":"it seems like the setdefault would probably be good enough here too?","commit_id":"f05eddeece3b37046874cd6c4ab047529f9b559b"}],"swift/common/ring/utils.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        R:5678           Matches devices that use replication port 5678"},{"line_number":293,"context_line":"        1.2.3.4R5.6.7.8  Matches devices that use ip 1.2.3.4 and replication ip"},{"line_number":294,"context_line":"                         5.6.7.8"},{"line_number":295,"context_line":"        y874             Matches devices that use rsync port 874"},{"line_number":296,"context_line":"        /sdb1            Matches devices with the device name sdb1"},{"line_number":297,"context_line":"        _shiny           Matches devices with shiny in the meta data"},{"line_number":298,"context_line":"        _\"snet: 5.6.7.8\" Matches devices with snet: 5.6.7.8 in the meta data"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_5d2c284a","line":295,"updated":"2015-08-18 03:44:01.000000000","message":"ick, R::\u003cport\u003e would be sorta cute","commit_id":"25d65d41890b9734ea192865a284e83925054201"}],"swift/obj/replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        rsync_port \u003d node[\u0027rsync_port\u0027]"},{"line_number":200,"context_line":"        if self.vm_test_mode:"},{"line_number":201,"context_line":"            rsync_module \u003d \u0027rsync://%s:%d/object%s\u0027 % ("},{"line_number":202,"context_line":"                node_ip, rsync_port, node[\u0027replication_port\u0027])"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            rsync_module \u003d \u0027rsync://%s:%d/object\u0027 % (node_ip, rsync_port)"},{"line_number":205,"context_line":"        had_any \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_7d8d6c30","line":202,"updated":"2015-08-18 03:44:01.000000000","message":"this looks right, but I didn\u0027t see any tests specifically for vm_test_mode in test.unit.obj.test_replicator - so that\u0027s something I\u0027ll want to test functionally.","commit_id":"25d65d41890b9734ea192865a284e83925054201"}],"test/unit/obj/test_replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d43af41898140bf9f4c72d8a932477e3f799e40c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                 if node[\u0027ip\u0027] not in _ips()]"},{"line_number":234,"context_line":"        rsync_mods \u003d tuple([\u0027rsync://%s:%d/object/sda/objects/%s\u0027 %"},{"line_number":235,"context_line":"                            (node[\u0027ip\u0027], node[\u0027rsync_port\u0027], cur_part)"},{"line_number":236,"context_line":"                            for node in nodes])"},{"line_number":237,"context_line":"        for node in nodes:"},{"line_number":238,"context_line":"            process_arg_checker.append("},{"line_number":239,"context_line":"                (0, \u0027\u0027, [\u0027rsync\u0027, whole_path_from, rsync_mods]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_fda09c92","line":236,"updated":"2015-08-18 03:44:01.000000000","message":"kudos, I find the explicit protocol form easier to read actually","commit_id":"25d65d41890b9734ea192865a284e83925054201"}]}