)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3e911e30206943cccedb19fa0de20af32c6913c3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  - both are called from other modules so neither should have"},{"line_number":47,"context_line":"    the \u0027_\u0027: the heritage is that before we had diskfile.get_hashes()"},{"line_number":48,"context_line":"    which was called by DiskFileManager.get_hashes() via"},{"line_number":49,"context_line":"    DiskFileManager._get_hashes()."},{"line_number":50,"context_line":"  - Now diskfile.get_hashes() has been moved in the class to be"},{"line_number":51,"context_line":"    DiskFileManager._get_hashes() but it is still called from the"},{"line_number":52,"context_line":"    replicator."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_83afaa7c","line":49,"updated":"2015-07-06 17:14:18.000000000","message":"just because the replicator reaches behind the public interface and goes digging in the guts doesn\u0027t mean it cant\u0027 have a leading underscore.  I think it\u0027s a fair warning - there be dragons here.","commit_id":"81fae958f170e5211c4735f420b9392753a10446"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fd297c2a78f2282acef7d5d0b0eaaa9c7c8d15d8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  - both are called from other modules so neither should have"},{"line_number":47,"context_line":"    the \u0027_\u0027: the heritage is that before we had diskfile.get_hashes()"},{"line_number":48,"context_line":"    which was called by DiskFileManager.get_hashes() via"},{"line_number":49,"context_line":"    DiskFileManager._get_hashes()."},{"line_number":50,"context_line":"  - Now diskfile.get_hashes() has been moved in the class to be"},{"line_number":51,"context_line":"    DiskFileManager._get_hashes() but it is still called from the"},{"line_number":52,"context_line":"    replicator."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_850344be","line":49,"in_reply_to":"ba3cc151_83afaa7c","updated":"2015-07-10 15:57:30.000000000","message":"ok","commit_id":"81fae958f170e5211c4735f420b9392753a10446"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3e911e30206943cccedb19fa0de20af32c6913c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    replicator."},{"line_number":53,"context_line":"  - Do we even need both? get_hashes() does a little more checking"},{"line_number":54,"context_line":"    wrt _get_hashes() but replicator has all the info it needs to call"},{"line_number":55,"context_line":"    get_hashes() instead and let it build the partition path."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Change-Id: I963e0d0ae0d6569ad1de605034c529529cbb4f9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_83fd6a70","line":55,"updated":"2015-07-06 17:14:18.000000000","message":"get_hashes() is the public interface used by the obj-server, it does all the tpool wrapping and device mount checking.\n\n_get_hashes is the raw method, it doesn\u0027t do anything for you, you shouldn\u0027t use it unless you know how (e.g. replicator knows how)","commit_id":"81fae958f170e5211c4735f420b9392753a10446"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fd297c2a78f2282acef7d5d0b0eaaa9c7c8d15d8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    replicator."},{"line_number":53,"context_line":"  - Do we even need both? get_hashes() does a little more checking"},{"line_number":54,"context_line":"    wrt _get_hashes() but replicator has all the info it needs to call"},{"line_number":55,"context_line":"    get_hashes() instead and let it build the partition path."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Change-Id: I963e0d0ae0d6569ad1de605034c529529cbb4f9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_25f598ca","line":55,"in_reply_to":"ba3cc151_83fd6a70","updated":"2015-07-10 15:57:30.000000000","message":"ok thanks for feedback, will leave as is","commit_id":"81fae958f170e5211c4735f420b9392753a10446"}],"test/unit/obj/test_auditor.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3e911e30206943cccedb19fa0de20af32c6913c3","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    def test_with_tombstone_and_data(self):"},{"line_number":516,"context_line":"        # we should never find a tombstone and data file in object dir since"},{"line_number":517,"context_line":"        # diskfile cleans up older files, but just in case verify they are both"},{"line_number":518,"context_line":"        # removed during audit"},{"line_number":519,"context_line":"        ts_iter \u003d make_timestamp_iter()"},{"line_number":520,"context_line":"        ts_tomb \u003d ts_iter.next()"},{"line_number":521,"context_line":"        ts_data \u003d ts_iter.next()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_23525ede","line":518,"updated":"2015-07-06 17:14:18.000000000","message":"rsync replication would do this","commit_id":"81fae958f170e5211c4735f420b9392753a10446"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fd297c2a78f2282acef7d5d0b0eaaa9c7c8d15d8","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    def test_with_tombstone_and_data(self):"},{"line_number":516,"context_line":"        # we should never find a tombstone and data file in object dir since"},{"line_number":517,"context_line":"        # diskfile cleans up older files, but just in case verify they are both"},{"line_number":518,"context_line":"        # removed during audit"},{"line_number":519,"context_line":"        ts_iter \u003d make_timestamp_iter()"},{"line_number":520,"context_line":"        ts_tomb \u003d ts_iter.next()"},{"line_number":521,"context_line":"        ts_data \u003d ts_iter.next()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_45b21c08","line":518,"in_reply_to":"ba3cc151_23525ede","updated":"2015-07-10 15:57:30.000000000","message":"good point, will change comment","commit_id":"81fae958f170e5211c4735f420b9392753a10446"}]}