)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"c7c76795ddd6596e8fb5b77fa3eaad0692174602","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add CORS unit tests to base"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In swift 2.3.0 when a request was made with an existing origin, but"},{"line_number":10,"context_line":"without any CORS settings in the container, it was possible to get"},{"line_number":11,"context_line":"an unhandled exception due to a method call on the \"None\" return of"},{"line_number":12,"context_line":"cors.get(\u0027allow_origin\u0027, \u0027\u0027)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_ee03050c","line":9,"updated":"2015-07-06 15:28:48.000000000","message":"2.3.0 or 2.2.0?","commit_id":"9bbcbdf7354ccb8f35299798aa784a6f56d463a8"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"6706b76f3e74a3b847ddda1ce3e3f27a67d3917a","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            # The user agent won\u0027t process the response if the Allow-Origin"},{"line_number":252,"context_line":"            # header isn\u0027t included"},{"line_number":253,"context_line":"            if \u0027Access-Control-Allow-Origin\u0027 not in resp.headers:"},{"line_number":254,"context_line":"                if cors_info[\u0027allow_origin\u0027] and \\"},{"line_number":255,"context_line":"                        cors_info[\u0027allow_origin\u0027].strip() \u003d\u003d \u0027*\u0027:"},{"line_number":256,"context_line":"                    resp.headers[\u0027Access-Control-Allow-Origin\u0027] \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_51051312","line":253,"updated":"2015-07-05 06:52:35.000000000","message":"Now that you fixed the default, should this test be removed? Or is this some kind of live migration issues with old stuff in memcached?","commit_id":"29fe34843be5317caa34b92da144bf9f87987870"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"4f85eaf79067a83fdf683dd7734f12bfbc2f7dca","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            # The user agent won\u0027t process the response if the Allow-Origin"},{"line_number":252,"context_line":"            # header isn\u0027t included"},{"line_number":253,"context_line":"            if \u0027Access-Control-Allow-Origin\u0027 not in resp.headers:"},{"line_number":254,"context_line":"                if cors_info[\u0027allow_origin\u0027] and \\"},{"line_number":255,"context_line":"                        cors_info[\u0027allow_origin\u0027].strip() \u003d\u003d \u0027*\u0027:"},{"line_number":256,"context_line":"                    resp.headers[\u0027Access-Control-Allow-Origin\u0027] \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_41a53eb3","line":253,"in_reply_to":"ba3cc151_51051312","updated":"2015-07-06 00:27:49.000000000","message":"Will be uploading a new patch that uses the conditionals instead of changing the default \u0027allow_origin\u0027.","commit_id":"29fe34843be5317caa34b92da144bf9f87987870"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"6706b76f3e74a3b847ddda1ce3e3f27a67d3917a","unresolved":false,"context_lines":[{"line_number":1616,"context_line":"            allow_headers.update("},{"line_number":1617,"context_line":"                list_from_csv(req.headers[\u0027Access-Control-Request-Headers\u0027]))"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"        # Populate the response with the CORS preflight headers"},{"line_number":1620,"context_line":"        if cors.get(\u0027allow_origin\u0027, \u0027\u0027).strip() \u003d\u003d \u0027*\u0027:"},{"line_number":1621,"context_line":"            headers[\u0027access-control-allow-origin\u0027] \u003d \u0027*\u0027"},{"line_number":1622,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b1081f2f","line":1619,"updated":"2015-07-05 06:52:35.000000000","message":"Why is it that you preferred the fix to default rather than adding a test here like done at line 254 in cors_validation.wrapped()?","commit_id":"29fe34843be5317caa34b92da144bf9f87987870"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"4f85eaf79067a83fdf683dd7734f12bfbc2f7dca","unresolved":false,"context_lines":[{"line_number":1616,"context_line":"            allow_headers.update("},{"line_number":1617,"context_line":"                list_from_csv(req.headers[\u0027Access-Control-Request-Headers\u0027]))"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"        # Populate the response with the CORS preflight headers"},{"line_number":1620,"context_line":"        if cors.get(\u0027allow_origin\u0027, \u0027\u0027).strip() \u003d\u003d \u0027*\u0027:"},{"line_number":1621,"context_line":"            headers[\u0027access-control-allow-origin\u0027] \u003d \u0027*\u0027"},{"line_number":1622,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_e1a9f291","line":1619,"in_reply_to":"ba3cc151_b1081f2f","updated":"2015-07-06 00:27:49.000000000","message":"I had simply applied the suggested fix in the bug report.  I do think that adding the check is more consistent, however.  Will upload a new patch.","commit_id":"29fe34843be5317caa34b92da144bf9f87987870"}]}