)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"90a62cfc5c3dd9abb2d3f57f6b792f4a40ecf57d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the local drive at the location where the drive was mounted."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are two suggested solutions for this issue:"},{"line_number":14,"context_line":"  1) Set the permissions for /srv/../ to root:root 655"},{"line_number":15,"context_line":"  2) Mount the drives elsewhere and symlink the drives to /srv/../"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The first method ensures that only root and not the swift user"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_98fa3e76","line":14,"updated":"2015-07-08 18:18:45.000000000","message":"Nit: use \"...\" instead of \"..\", as /srv/../ \u003d /","commit_id":"ee224a6ecb5773a21c87d251faadbeb83994db69"},{"author":{"_account_id":12974,"name":"Ben Martin","email":"blmartin@us.ibm.com","username":"blmartin"},"change_message_id":"68da24ca9897e18d8bdd12357d254b1e16138bb0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the local drive at the location where the drive was mounted."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are two suggested solutions for this issue:"},{"line_number":14,"context_line":"  1) Set the permissions for /srv/../ to root:root 655"},{"line_number":15,"context_line":"  2) Mount the drives elsewhere and symlink the drives to /srv/../"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The first method ensures that only root and not the swift user"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_be036b41","line":14,"in_reply_to":"ba3cc151_98fa3e76","updated":"2015-07-10 00:34:49.000000000","message":"ahh, I did not see that, thanks!","commit_id":"ee224a6ecb5773a21c87d251faadbeb83994db69"}],"doc/source/admin_guide.rst":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"90a62cfc5c3dd9abb2d3f57f6b792f4a40ecf57d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"then it is just best to replace the drive, format it, remount it, and let"},{"line_number":155,"context_line":"replication fill it up."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Before unmounting the drive, make sure the directory containing the mount point"},{"line_number":158,"context_line":"is owned by root (root:root 655). This ensures that rsync will not try to"},{"line_number":159,"context_line":"replicate into the root drive once the failed drive is unmounted."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_f8090a96","line":157,"updated":"2015-07-08 18:18:45.000000000","message":"I\u0027m not quite sure how to word this one, but \"directory containing the mount point\" doesn\u0027t seem like it.\n\nIf I have /srv/node/d0 as a mount point, then the \"directory containing the mount point\" makes me think of /srv/node, not /srv/node/d0 on the root filesystem.","commit_id":"ee224a6ecb5773a21c87d251faadbeb83994db69"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"23ef5352e605aa8ab4d1847355ee8257c559ae39","unresolved":false,"context_lines":[{"line_number":154,"context_line":"then it is just best to replace the drive, format it, remount it, and let"},{"line_number":155,"context_line":"replication fill it up."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Before unmounting the drive, make sure the mount point is owned by root"},{"line_number":158,"context_line":"(root:root 655). This ensures that rsync will not try to replicate into the"},{"line_number":159,"context_line":"root drive once the failed drive is unmounted."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_829673ee","line":157,"updated":"2015-07-28 00:55:48.000000000","message":"Should this be *after* unmounting? I don\u0027t think you can get to the mount point on the root FS while it\u0027s still mounted.","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":17276,"name":"Carlos Cavanna","email":"ccavanna@ca.ibm.com","username":"ccavanna"},"change_message_id":"676e30a7689b8f06f7f95ea758e7ea6d25259676","unresolved":false,"context_lines":[{"line_number":154,"context_line":"then it is just best to replace the drive, format it, remount it, and let"},{"line_number":155,"context_line":"replication fill it up."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Before unmounting the drive, make sure the mount point is owned by root"},{"line_number":158,"context_line":"(root:root 655). This ensures that rsync will not try to replicate into the"},{"line_number":159,"context_line":"root drive once the failed drive is unmounted."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_b8a8dbdc","line":157,"in_reply_to":"3a50d1a3_829673ee","updated":"2015-07-30 20:18:04.000000000","message":"I think you can check the permissions on the mount point from its parent.","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":12974,"name":"Ben Martin","email":"blmartin@us.ibm.com","username":"blmartin"},"change_message_id":"36d23f9de0d29e8be8cb1171bd38ad518df34025","unresolved":false,"context_lines":[{"line_number":154,"context_line":"then it is just best to replace the drive, format it, remount it, and let"},{"line_number":155,"context_line":"replication fill it up."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Before unmounting the drive, make sure the mount point is owned by root"},{"line_number":158,"context_line":"(root:root 655). This ensures that rsync will not try to replicate into the"},{"line_number":159,"context_line":"root drive once the failed drive is unmounted."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_5bd0b1f7","line":157,"in_reply_to":"3a50d1a3_b8a8dbdc","updated":"2015-07-30 21:21:50.000000000","message":"I spoke with torgomatic about this and he pointed out that if the permission is changed while the drive is mounted, it affects the drive\u0027s root filesystem. Once the drive is unmounted, it reverts permissions to whatever the mounting directory\u0027s permissions were prior to mounting. I will amend my edits to state as such.","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"dcb19516dd28b8b65446762e113b1d2e8f8132c7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"replication fill it up."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"After the drive is unmounted, make sure the mount point is owned by root"},{"line_number":158,"context_line":"(root:root 655). This ensures that rsync will not try to replicate into the"},{"line_number":159,"context_line":"root drive once the failed drive is unmounted."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"If the drive can\u0027t be replaced immediately, then it is best to leave it"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_783b06d2","line":158,"updated":"2015-08-04 23:08:05.000000000","message":"755? I mean, I guess you could leave off the owner\u0027s execute bit, but it wouldn\u0027t help.","commit_id":"c435df02279ee1763ff14ef4c595bb80b649161f"}],"doc/source/development_saio.rst":[{"author":{"_account_id":17276,"name":"Carlos Cavanna","email":"ccavanna@ca.ibm.com","username":"ccavanna"},"change_message_id":"676e30a7689b8f06f7f95ea758e7ea6d25259676","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a50d1a3_b8853b08","updated":"2015-07-30 20:18:04.000000000","message":"In the \"Link to the mount point\" comment, maybe you can clarity that rsync will not sync files to the local drive because /srv will have been created as root:root 655 in the previous step.\n\nSince you mention this in four places, this could be something you can point out generically after:\n\"Create the mount point and the individualized links\" at the start of this section.","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":12974,"name":"Ben Martin","email":"blmartin@us.ibm.com","username":"blmartin"},"change_message_id":"36d23f9de0d29e8be8cb1171bd38ad518df34025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a50d1a3_c6fdc809","in_reply_to":"3a50d1a3_b8853b08","updated":"2015-07-30 21:21:50.000000000","message":"Thanks for reviewing! It looks like the saio documentation does not change the ownership to root:root 655 but rather \u003cuser\u003e:\u003cuser\u003e. Instead it uses links to avoid the issue (causing, I believe, a broken link error if accessed when unmounted). If instead of the comment we just added a warning after both sections, I\u0027m not sure where to put it. It does not seem like it would go in common post device setup. I\u0027m not opposed to the idea at all though. Currently, it seems a little out of place in the code section.","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":17276,"name":"Carlos Cavanna","email":"ccavanna@ca.ibm.com","username":"ccavanna"},"change_message_id":"ea05d16fbc96f1db640713c4bd43dee2f1207c0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a50d1a3_6c7267e5","in_reply_to":"3a50d1a3_c6fdc809","updated":"2015-07-31 18:18:24.000000000","message":"(Sorry for the long reply)\n\nI mentioned /srv in my original post, but we actually care about the symlinks and the ownership of the /mnt/sdb1/* directories. My bad.\n\nI re-read your comment and now I understand better what you are trying to say and yes, it seems you\u0027ll get a broken link, indeed.\n\nI agree this seems a little out of place in the code section. This seems to be a generic issue that may be interesting to address separately. In particular, when you install SAIO, you are most likely starting with Swift (something I\u0027m going through right now). Maybe the code section can remain as-is and maybe you could explain this under \"Create the mount point [...]\" , in a .. Note:: section.\n\nI know the commands are self-documenting :-), but I think the point you are trying to address is important to point out. I post my proposed text (for the .. Note:: section) below:\n\nWe create the mount points and mount the storage disk under /mnt/sdb1. This disk will contain one directory per object server, which will be owned by the current swift user.\n\nThen, we create symlinks to these directories under /srv. Notice that if the disk in /mnt/sdb1 is unmounted, files will not be written under /srv/*, because the symbolic link destination /mnt/sdb1/* will not exist. This prevents disk operations from occurring in the current root partition.\n\nYou can do the same thing for the other documentation file.\nDoes that make sense? :-)","commit_id":"889691092a4771a5554d13fe2a470df595bdf0c9"},{"author":{"_account_id":12974,"name":"Ben Martin","email":"blmartin@us.ibm.com","username":"blmartin"},"change_message_id":"c73620ace9a25576e38ed580c8fb4fd1cd788352","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        sudo chown ${USER}:${USER} /mnt/sdb1/*"},{"line_number":87,"context_line":"        sudo mkdir /srv"},{"line_number":88,"context_line":"        # Link to the mount point so rsync cannot sync files to the local drive"},{"line_number":89,"context_line":"        #  in the case that a drive is unmounted"},{"line_number":90,"context_line":"        for x in {1..4}; do sudo ln -s /mnt/sdb1/$x /srv/$x; done"},{"line_number":91,"context_line":"        sudo mkdir -p /srv/1/node/sdb1 /srv/1/node/sdb5 \\"},{"line_number":92,"context_line":"                      /srv/2/node/sdb2 /srv/2/node/sdb6 \\"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_4262f4ae","line":89,"updated":"2015-08-04 14:48:24.000000000","message":"forgot to remove this. will do so now.","commit_id":"c435df02279ee1763ff14ef4c595bb80b649161f"}]}