)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9878,"name":"Zack M. Davis","email":"zdavis@swiftstack.com","username":"zackmdavis"},"change_message_id":"0fe15f0897a5c2a1a0d4825aca9defebbcd7ed14","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using these modules from six.moves."},{"line_number":10,"context_line":"There were 2 choices for replacement:"},{"line_number":11,"context_line":"*input() could be used instead of raw_input()"},{"line_number":12,"context_line":"*input from six.moves.builtins could be used"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Second approach is used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_e7a8a822","line":11,"updated":"2015-07-14 19:08:59.000000000","message":"It seems wrong to speak of replacing `raw_input` with with `input` as if it were a viable alternative solution, given that we also have to support Python 2 for some years to come, and Python 2\u0027s `input` evals the inputted string as code.\n\n(I do apologize for nitpicking about non-code, since the patch actually does of course use six, but I thought it was worth mentioning this in passing on the grounds that it\u0027s desirable for commit messages to be as accurate as possible.)","commit_id":"3938b4c5416f30a5a942675cca646ee63ed33fea"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"79fa2cc75e4656534e2e70a6589f4ed50081ebda","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using these modules from six.moves."},{"line_number":10,"context_line":"There were 2 choices for replacement:"},{"line_number":11,"context_line":"*input() could be used instead of raw_input()"},{"line_number":12,"context_line":"*input from six.moves.builtins could be used"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Second approach is used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_0a8cb17d","line":11,"in_reply_to":"9a41bdd9_e7a8a822","updated":"2015-07-15 14:46:44.000000000","message":"No , it\u0027s ok thanks for comment. :) I\u0027ll make changes as soon as possible.","commit_id":"3938b4c5416f30a5a942675cca646ee63ed33fea"}],"swift/cli/ringbuilder.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"e5db0bbc8f486300819cb502402fc6eafcc51f4d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from time import time"},{"line_number":27,"context_line":"import optparse"},{"line_number":28,"context_line":"import math"},{"line_number":29,"context_line":"from six.moves.builtins import input"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from swift.common import exceptions"},{"line_number":32,"context_line":"from swift.common.ring import RingBuilder, Ring"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_08f022fd","line":29,"updated":"2015-07-15 07:37:40.000000000","message":"Found the reason - use the following to make the code work:\n\n from six.moves import input","commit_id":"3938b4c5416f30a5a942675cca646ee63ed33fea"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"270d2f30d62de6c235ef1565736b490069965c8b","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            if raw_input(\u0027Are you sure you want to remove these %s \u0027"},{"line_number":735,"context_line":"                         \u0027devices? (y/N) \u0027 % len(devs)) !\u003d \u0027y\u0027:"},{"line_number":736,"context_line":"                print(\u0027Aborting device removals\u0027)"},{"line_number":737,"context_line":"                exit(EXIT_ERROR)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        for dev in devs:"},{"line_number":740,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_2326d316","side":"PARENT","line":737,"updated":"2015-07-24 21:59:43.000000000","message":"why you removed this exit?","commit_id":"f3f1f1cab9c9cf1f713f773b060f4ac2054566b3"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"eb8a09883cff1f5ec9c7be4fd66a7a3cb718be06","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            if raw_input(\u0027Are you sure you want to remove these %s \u0027"},{"line_number":735,"context_line":"                         \u0027devices? (y/N) \u0027 % len(devs)) !\u003d \u0027y\u0027:"},{"line_number":736,"context_line":"                print(\u0027Aborting device removals\u0027)"},{"line_number":737,"context_line":"                exit(EXIT_ERROR)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        for dev in devs:"},{"line_number":740,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_e9b51bd0","side":"PARENT","line":737,"in_reply_to":"3a50d1a3_2326d316","updated":"2015-07-26 16:18:06.000000000","message":"It\u0027s my mistake, i didn\u0027t noticed. This was a different local change which was not related to it. Thanks i\u0027ll make changes.","commit_id":"f3f1f1cab9c9cf1f713f773b060f4ac2054566b3"}],"test/unit/cli/test_recon.py":[{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"bb43131938277ff5e07083ffd727c024d23bd10d","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        # We need any_order\u003dTrue because the order of calls depends on the dict"},{"line_number":706,"context_line":"        # that is returned from the recon middleware, thus can\u0027t rely on it"},{"line_number":707,"context_line":"        mock_print.assert_has_calls(default_calls, any_order\u003dTrue)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    @mock.patch(\u0027__builtin__.print\u0027)"},{"line_number":710,"context_line":"    @mock.patch(\u0027time.time\u0027)"},{"line_number":711,"context_line":"    def test_time_check(self, mock_now, mock_print):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_8241c53b","line":708,"updated":"2015-09-03 04:15:34.000000000","message":"s/__builtin__/six.moves.builtins","commit_id":"91ac5a02e2dbe485ee25915df987d37943b26ed9"},{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"bb43131938277ff5e07083ffd727c024d23bd10d","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        # We need any_order\u003dTrue because the order of calls depends on the dict"},{"line_number":738,"context_line":"        # that is returned from the recon middleware, thus can\u0027t rely on it"},{"line_number":739,"context_line":"        mock_print.assert_has_calls(default_calls, any_order\u003dTrue)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    @mock.patch(\u0027__builtin__.print\u0027)"},{"line_number":742,"context_line":"    @mock.patch(\u0027time.time\u0027)"},{"line_number":743,"context_line":"    def test_time_check_mismatch(self, mock_now, mock_print):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_a23c09c0","line":740,"updated":"2015-09-03 04:15:34.000000000","message":"s/__builtin__/six.moves.builtins","commit_id":"91ac5a02e2dbe485ee25915df987d37943b26ed9"}]}
