)]}'
{"swift/common/swob.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"da3dbfa925594b7640420d2c21778d642cca65e8","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        \"\"\""},{"line_number":1328,"context_line":"        You may call this once you have set the content_length to the whole"},{"line_number":1329,"context_line":"        object length and body or app_iter to reset the content_length"},{"line_number":1330,"context_line":"        properties on the request."},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"        It is ok to not call this method, the conditional resposne will be"},{"line_number":1333,"context_line":"        maintained for you when you __call__ the response."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a9244f5f","line":1330,"updated":"2015-07-23 16:30:03.000000000","message":"i\u0027m wondering if there\u0027s any other optional __init__ params that are actually required properties for this method to work?  (I\u0027m thinking self.request)\n\nThis method probably needs some tests.","commit_id":"99d052772a9585e0befdfd292fd03aefde77180a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b32ab21a860388d5297707bfb99f5e29d827439f","unresolved":false,"context_lines":[{"line_number":1386,"context_line":"        self.environ \u003d env"},{"line_number":1387,"context_line":""},{"line_number":1388,"context_line":"        if not self.response_iter:"},{"line_number":1389,"context_line":"            self.response_iter \u003d self._response_iter(self.app_iter, self._body)"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"        if \u0027location\u0027 in self.headers and \\"},{"line_number":1392,"context_line":"                not env.get(\u0027swift.leave_relative_location\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a808b02e","line":1389,"updated":"2015-07-24 04:05:34.000000000","message":"The fact this line is exactly the same as the line in the new \u0027fix_conditional_response\u0027 method makes we wonder if rather then duplicating it (yes I know it\u0027s only a line) we should just all the new method here:\n\n  if not self.response_iter:\n      fix_conditional_response()\n\nAlthough I guess, if we ever need to add more to fix_conditional_response then it\u0027s better to leave this as it is. Plus the name might confuse people... hmm  maybe just leave it as it is.","commit_id":"99d052772a9585e0befdfd292fd03aefde77180a"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d36e83233c8a60ddb2c6a06268a376595422eb70","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        if source_resp.content_length \u003e constraints.MAX_FILE_SIZE:"},{"line_number":504,"context_line":"            raise HTTPRequestEntityTooLarge(request\u003dreq)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        data_source \u003d iter(app_iter)"},{"line_number":507,"context_line":"        sink_req.content_length \u003d source_resp.content_length"},{"line_number":508,"context_line":"        sink_req.etag \u003d source_resp.etag"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_81452d18","line":506,"updated":"2015-07-14 08:06:33.000000000","message":"You could move defining app_iter down to just above this line, so it\u0027s closer to where it\u0027s used and so the above set of \u0027if\u0027 statements would short circuit quicker, but that\u0027s just a Nit, in fact less then a nit. A bit of a nit.","commit_id":"7b7b872e5285758934ea7786ed36d9485b1a86fc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"da3dbfa925594b7640420d2c21778d642cca65e8","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"        resp.headers[\u0027Etag\u0027] \u003d resp.headers.get("},{"line_number":2215,"context_line":"            \u0027X-Object-Sysmeta-Ec-Etag\u0027)"},{"line_number":2216,"context_line":"        resp.headers[\u0027Content-Length\u0027] \u003d resp.headers.get("},{"line_number":2217,"context_line":"            \u0027X-Object-Sysmeta-Ec-Content-Length\u0027)"},{"line_number":2218,"context_line":""},{"line_number":2219,"context_line":"        return resp"},{"line_number":2220,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_c99afb61","side":"PARENT","line":2217,"updated":"2015-07-23 16:30:03.000000000","message":"Maybe we shouldn\u0027t ever change the content-length on anything except but 2XX series GET/HEAD responses?","commit_id":"2f9053b6287d841911b807182eb0054862b7919d"}]}