)]}'
{"id":"openstack%2Fswift~204785","triplet_id":"openstack%2Fswift~master~I2d46c9969d41207a89e01017b4c2bc533c3d744f","project":"openstack/swift","branch":"master","topic":"p-assert-false-when-not-true","hashtags":[],"change_id":"I2d46c9969d41207a89e01017b4c2bc533c3d744f","subject":"functests: use assertIn and assertNotIn","status":"MERGED","created":"2015-07-22 23:06:13.000000000","updated":"2015-07-28 17:17:41.000000000","submitted":"2015-07-28 12:26:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8d7bd8b1f15ad3393f7d6d0990159e3af20e5236","_number":204785,"virtual_id_number":204785,"owner":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},{"value":2,"date":"2015-07-28 12:26:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":2,"date":"2015-07-28 11:23:57.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2015-07-28 11:23:57.000000000","_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":2,"date":"2015-07-28 11:25:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":1,"date":"2015-07-28 11:23:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"value":1,"date":"2015-07-28 11:25:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-23 00:46:31.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2015-07-23 14:20:59.000000000","updated_by":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"reviewer":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"state":"REVIEWER"},{"updated":"2015-07-27 22:30:41.000000000","updated_by":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"reviewer":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"state":"REVIEWER"},{"updated":"2015-07-28 11:25:45.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2015-07-28 12:26:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"aa860bd56bbf863de88a414330eb6c7793274108","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2015-07-22 23:06:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b00ebbe25dd1cc44b9e43a2dd3e5328002e2a0da","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2015-07-23 00:46:31.000000000","message":"Patch Set 1: Code-Review+2\n\nit\u0027s even testtools-proof this time","accounts_in_message":[],"_revision_number":1},{"id":"d99bf0db9bf93bac26bc81389bac7852d9760a0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-23 04:52:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-swift-pep8 http://logs.openstack.org/85/204785/1/check/gate-swift-pep8/8b9d594/ : SUCCESS in 2m 06s\n- gate-swift-docs http://docs-draft.openstack.org/85/204785/1/check/gate-swift-docs/2faeb5b//doc/build/html/ : SUCCESS in 2m 42s\n- gate-swift-python27 http://logs.openstack.org/85/204785/1/check/gate-swift-python27/ba4aac5/ : SUCCESS in 4m 30s\n- gate-swift-tox-func http://logs.openstack.org/85/204785/1/check/gate-swift-tox-func/17692fb/ : SUCCESS in 5m 16s (non-voting)\n- gate-swift-python34 http://logs.openstack.org/85/204785/1/check/gate-swift-python34/9a8c268/ : FAILURE in 2m 39s (non-voting)\n- gate-tempest-dsvm-full http://logs.openstack.org/85/204785/1/check/gate-tempest-dsvm-full/842762c/ : SUCCESS in 54m 24s\n- gate-grenade-dsvm http://logs.openstack.org/85/204785/1/check/gate-grenade-dsvm/b5930e8/ : SUCCESS in 53m 59s\n- gate-swift-dsvm-functional http://logs.openstack.org/85/204785/1/check/gate-swift-dsvm-functional/c9c540b/ : SUCCESS in 36m 07s","accounts_in_message":[],"_revision_number":1},{"id":"58d8025d6a52f17e2617fd9671b04efdb7ef75c5","author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"date":"2015-07-23 14:20:59.000000000","message":"Patch Set 1: Code-Review+1\n\nCool, That\u0027s good.","accounts_in_message":[],"_revision_number":1},{"id":"bd8613b9c9f2e2d89e415dd1fee7e910adc393e1","author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"date":"2015-07-27 22:30:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"dded05b78dcc285b4f0ffd6960b0b36b19a8e0ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 08:57:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0ac09f1d751644ecf485fcd2203df080db4d43aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 10:28:16.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"0eff58083ae855fdaa9a5202207a652c2999d4a3","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-07-28 11:23:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7679e26fb1f2e0264acd9fd94d4c5098c5b4f485","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2015-07-28 11:25:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nRebased (depended on patch that failed to merge)","accounts_in_message":[],"_revision_number":2},{"id":"0b10a381ff8fff3d339bd4e5b1cef0034faffc24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 11:25:52.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"6d1b8b3edba437c3c0f3d1bd6ad275b5cfb724ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 12:26:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-swift-docs http://docs-draft.openstack.org/85/204785/2/gate/gate-swift-docs/684c80f//doc/build/html/ : SUCCESS in 2m 45s\n- gate-swift-pep8 http://logs.openstack.org/85/204785/2/gate/gate-swift-pep8/07413a2/ : SUCCESS in 2m 28s\n- gate-swift-python27 http://logs.openstack.org/85/204785/2/gate/gate-swift-python27/4009a2a/ : SUCCESS in 4m 11s\n- gate-tempest-dsvm-full http://logs.openstack.org/85/204785/2/gate/gate-tempest-dsvm-full/69e4925/ : SUCCESS in 57m 54s\n- gate-grenade-dsvm http://logs.openstack.org/85/204785/2/gate/gate-grenade-dsvm/e5c6b47/ : SUCCESS in 58m 03s\n- gate-swift-dsvm-functional http://logs.openstack.org/85/204785/2/gate/gate-swift-dsvm-functional/4398040/ : SUCCESS in 37m 32s","accounts_in_message":[],"_revision_number":2},{"id":"cb3017f72689d1949b419508af34a3bb2fd391a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 12:26:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"ba8fa7c010f5bcbb229301dc51f63194aea48b46","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-28 17:17:41.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- gate-swift-pep8 http://logs.openstack.org/85/204785/2/check/gate-swift-pep8/9f3b525/ : SUCCESS in 2m 10s\n- gate-swift-docs http://docs-draft.openstack.org/85/204785/2/check/gate-swift-docs/9100265//doc/build/html/ : SUCCESS in 3m 12s\n- gate-swift-python27 http://logs.openstack.org/85/204785/2/check/gate-swift-python27/93f9448/ : SUCCESS in 4m 45s\n- gate-swift-tox-func http://logs.openstack.org/85/204785/2/check/gate-swift-tox-func/362eddb/ : SUCCESS in 5m 20s (non-voting)\n- gate-swift-python34 http://logs.openstack.org/85/204785/2/check/gate-swift-python34/45d10a1/ : FAILURE in 3m 08s (non-voting)\n- gate-tempest-dsvm-full http://logs.openstack.org/85/204785/2/check/gate-tempest-dsvm-full/16103c1/ : SUCCESS in 45m 59s\n- gate-grenade-dsvm http://logs.openstack.org/85/204785/2/check/gate-grenade-dsvm/c9bc77d/ : SUCCESS in 52m 29s\n- gate-swift-dsvm-functional http://logs.openstack.org/85/204785/2/check/gate-swift-dsvm-functional/6081bb1/ : SUCCESS in 34m 23s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"117b61976fbf14d8a0d2157256f9a3230421ee72","revisions":{"9fc4fa2b552a533e3aa7b4a7b797b89ea9c8a129":{"kind":"REWORK","_number":1,"created":"2015-07-22 23:06:13.000000000","uploader":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"ref":"refs/changes/85/204785/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/85/204785/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/85/204785/1"}}},"commit":{"parents":[{"commit":"947e9a274fba67a0e9eea91780e9e765e58419b2","subject":"test/(functional, probe): Replace \"self.assert_\" by \"self.assertTrue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/947e9a274fba67a0e9eea91780e9e765e58419b2"}]}],"author":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2015-07-22 22:40:55.000000000","tz":-420},"committer":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2015-07-22 22:51:04.000000000","tz":-420},"subject":"functests: use assertIn and assertNotIn","message":"functests: use assertIn and assertNotIn\n\nWe have a bunch of assertions like\n\n    self.assertTrue(resp.status in (200, 204))\n\nSometimes we get smart about failure messages and have something like\n\n    self.assertTrue(resp.status in (200, 204), resp.status)\n\nso we can see what the status was when it failed.\n\nSince we don\u0027t have to support Python 2.6 any more, we can use\nassertIn/assertNotIn and get nice failure messages for free.\n\nChange-Id: I2d46c9969d41207a89e01017b4c2bc533c3d744f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9fc4fa2b552a533e3aa7b4a7b797b89ea9c8a129"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9fc4fa2b552a533e3aa7b4a7b797b89ea9c8a129"}]},"branch":"refs/heads/master"},"117b61976fbf14d8a0d2157256f9a3230421ee72":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-07-28 11:23:57.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/85/204785/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/85/204785/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/85/204785/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/85/204785/2"}}},"commit":{"parents":[{"commit":"8fe8bee7e0c5c9d34d7a8e6ab090c8d65c5ca78e","subject":"test/(functional, probe): Replace \"self.assert_\" by \"self.assertTrue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8fe8bee7e0c5c9d34d7a8e6ab090c8d65c5ca78e"}]}],"author":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2015-07-22 22:40:55.000000000","tz":-420},"committer":{"name":"Alistair Coles","email":"alistair.coles@hp.com","date":"2015-07-28 11:23:14.000000000","tz":60},"subject":"functests: use assertIn and assertNotIn","message":"functests: use assertIn and assertNotIn\n\nWe have a bunch of assertions like\n\n    self.assertTrue(resp.status in (200, 204))\n\nSometimes we get smart about failure messages and have something like\n\n    self.assertTrue(resp.status in (200, 204), resp.status)\n\nso we can see what the status was when it failed.\n\nSince we don\u0027t have to support Python 2.6 any more, we can use\nassertIn/assertNotIn and get nice failure messages for free.\n\nChange-Id: I2d46c9969d41207a89e01017b4c2bc533c3d744f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/117b61976fbf14d8a0d2157256f9a3230421ee72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/117b61976fbf14d8a0d2157256f9a3230421ee72"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}