)]}'
{"swift/common/swob.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c58660c7026723ae9b528696be851c08ccd5993e","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                (self.token if typ \u003d\u003d \u0027*\u0027 else re.escape(typ)) + \u0027/\u0027 + \\"},{"line_number":712,"context_line":"                (self.token if subtype \u003d\u003d \u0027*\u0027 else re.escape(subtype)) + \u0027$\u0027"},{"line_number":713,"context_line":"            specificity \u003d \\"},{"line_number":714,"context_line":"                (1 if all(name \u003d\u003d \u0027q\u0027 for n, _ in parms) else 0) + \\"},{"line_number":715,"context_line":"                (2 if subtype \u003d\u003d \u0027*\u0027 else 0) + \\"},{"line_number":716,"context_line":"                (4 if typ \u003d\u003d \u0027*\u0027 else 0)"},{"line_number":717,"context_line":"            types.append((re.compile(pattern), quality, specificity))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_314ad184","line":714,"updated":"2015-11-03 21:11:20.000000000","message":"n \u003d\u003d \u0027q\u0027 ?\n\nThis *can\u0027t* be the least obfuscated way to write this...","commit_id":"d6520c122a9a1ef04a3d4766ceb7f63adfdbc7fa"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a606133a2dc83f9bb43ee83f6e401b338ce39fa1","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                (self.token if typ \u003d\u003d \u0027*\u0027 else re.escape(typ)) + \u0027/\u0027 + \\"},{"line_number":712,"context_line":"                (self.token if subtype \u003d\u003d \u0027*\u0027 else re.escape(subtype)) + \u0027$\u0027"},{"line_number":713,"context_line":"            specificity \u003d \\"},{"line_number":714,"context_line":"                (1 if all(name \u003d\u003d \u0027q\u0027 for n, _ in parms) else 0) + \\"},{"line_number":715,"context_line":"                (2 if subtype \u003d\u003d \u0027*\u0027 else 0) + \\"},{"line_number":716,"context_line":"                (4 if typ \u003d\u003d \u0027*\u0027 else 0)"},{"line_number":717,"context_line":"            types.append((re.compile(pattern), quality, specificity))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_15b0cfdc","line":714,"in_reply_to":"fa80f949_314ad184","updated":"2015-11-04 04:18:34.000000000","message":"Good catch. Fixed.\n\nI added a bunch of comments and broke it out to a tuple of bools instead of a single int. Maybe it\u0027s better?\n\nBasically I just need a way of saying, \"text/plain is more specific than */*, so as I\u0027m going through the server\u0027s available options, use text/plain\u0027s q value if it matches\".","commit_id":"d6520c122a9a1ef04a3d4766ceb7f63adfdbc7fa"}],"test/unit/common/test_swob.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c58660c7026723ae9b528696be851c08ccd5993e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            acc \u003d swift.common.swob.Accept(accept)"},{"line_number":332,"context_line":"            match \u003d acc.best_match([\u0027text/plain\u0027, \u0027application/json\u0027,"},{"line_number":333,"context_line":"                                    \u0027application/xml\u0027, \u0027text/xml\u0027])"},{"line_number":334,"context_line":"            self.assertEquals(match, \u0027text/plain\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_accept_xml(self):"},{"line_number":337,"context_line":"        for accept in (\u0027application/xml\u0027, \u0027application/xml;q\u003d1.0,*/*;q\u003d0.9\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_91037d0f","side":"PARENT","line":334,"updated":"2015-11-03 21:11:20.000000000","message":"rather than this hodgepodge we probably need just a single test that iterates over a list:\n\n    for accept_header, server_options, expected in expectations:\n        ...\n\n... then we just keep adding to thethe list (over and over and over)","commit_id":"5fda35c0b484db54a7bb24e9c86c8a4723cc7cb1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a606133a2dc83f9bb43ee83f6e401b338ce39fa1","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            acc \u003d swift.common.swob.Accept(accept)"},{"line_number":332,"context_line":"            match \u003d acc.best_match([\u0027text/plain\u0027, \u0027application/json\u0027,"},{"line_number":333,"context_line":"                                    \u0027application/xml\u0027, \u0027text/xml\u0027])"},{"line_number":334,"context_line":"            self.assertEquals(match, \u0027text/plain\u0027)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_accept_xml(self):"},{"line_number":337,"context_line":"        for accept in (\u0027application/xml\u0027, \u0027application/xml;q\u003d1.0,*/*;q\u003d0.9\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_b8177aec","side":"PARENT","line":334,"in_reply_to":"fa80f949_91037d0f","updated":"2015-11-04 04:18:34.000000000","message":"Done, though I don\u0027t really like the one-giant-test-case approach as a general rule. You see one test failure which 9/10 times doesn\u0027t include enough information to determine what went wrong, when often what\u0027s useful is seeing the similarities between a bunch of test failures.\n\n(Not that it\u0027ll happen any time soon, but one more reason to get off of Python 2: unittest TestCases get subTest managers in 3.4 https://docs.python.org/3/library/unittest.html#distinguishing-test-iterations-using-subtests)","commit_id":"5fda35c0b484db54a7bb24e9c86c8a4723cc7cb1"}]}