)]}'
{"test/unit/container/test_updater.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f6808f86fc7ff93f669a1ee0c7cbb491f0e5b7e3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        containers_dir \u003d os.path.join(self.sda1, DATADIR)"},{"line_number":92,"context_line":"        os.mkdir(containers_dir)"},{"line_number":93,"context_line":"        cu.run_once()"},{"line_number":94,"context_line":"        self.assertTrue(os.path.exists(containers_dir))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        cu \u003d container_updater.ContainerUpdater({"},{"line_number":97,"context_line":"            \u0027devices\u0027: self.devices_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_aadda615","line":94,"updated":"2015-08-11 08:47:31.000000000","message":"I\u0027m not sure what shall be tested here. The directory always exists, because of the os.mkdir? And run_once() never removes any directory; thus no matter what this test will succeed. It also succeeds if cu.run_once() does nothing at all.","commit_id":"76457e35fa6a1f1d2ff5cd8757906f0c0ecad1d5"},{"author":{"_account_id":15932,"name":"Bill Huber","email":"wbhuber@us.ibm.com","username":"wbhuber"},"change_message_id":"450b4d93a8214ac6a7c0ae0d770734c9f61f23ee","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        containers_dir \u003d os.path.join(self.sda1, DATADIR)"},{"line_number":92,"context_line":"        os.mkdir(containers_dir)"},{"line_number":93,"context_line":"        cu.run_once()"},{"line_number":94,"context_line":"        self.assertTrue(os.path.exists(containers_dir))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        cu \u003d container_updater.ContainerUpdater({"},{"line_number":97,"context_line":"            \u0027devices\u0027: self.devices_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f78649da","line":94,"in_reply_to":"1a4dcd0f_aadda615","updated":"2015-08-18 22:37:10.000000000","message":"That was more of a sanity check.  Otherwise, I can take that out and move on.","commit_id":"76457e35fa6a1f1d2ff5cd8757906f0c0ecad1d5"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f6808f86fc7ff93f669a1ee0c7cbb491f0e5b7e3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        cu.logger \u003d FakeLogger()"},{"line_number":109,"context_line":"        cu.run_once()"},{"line_number":110,"context_line":"        self.assertTrue(os.path.exists(containers_dir))"},{"line_number":111,"context_line":"        self.assertTrue(os.path.exists(bad_dir))  # skipped - not mounted!"},{"line_number":112,"context_line":"        log_lines \u003d cu.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":113,"context_line":"        self.assertTrue(len(log_lines) \u003e 0)"},{"line_number":114,"context_line":"        msg \u003d \u0027sda1 is not mounted\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8a0f8a87","line":111,"updated":"2015-08-11 08:47:31.000000000","message":"Same here; checking os.path.exists on previously created directories looks not very useful to me - the directory won\u0027t be removed by cu.run_once() (unless I missed something important when going over the code of ContainerUpdater).","commit_id":"76457e35fa6a1f1d2ff5cd8757906f0c0ecad1d5"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f6808f86fc7ff93f669a1ee0c7cbb491f0e5b7e3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        log_lines \u003d cu.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":113,"context_line":"        self.assertTrue(len(log_lines) \u003e 0)"},{"line_number":114,"context_line":"        msg \u003d \u0027sda1 is not mounted\u0027"},{"line_number":115,"context_line":"        self.assertEqual(log_lines[0], msg)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_run_once(self):"},{"line_number":118,"context_line":"        cu \u003d container_updater.ContainerUpdater({"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ea4e4ec0","line":115,"updated":"2015-08-11 08:47:31.000000000","message":"These two self.assert* seem to be the only that actually ensure something. However, the asserts are even True without the bad_dir?","commit_id":"76457e35fa6a1f1d2ff5cd8757906f0c0ecad1d5"},{"author":{"_account_id":15932,"name":"Bill Huber","email":"wbhuber@us.ibm.com","username":"wbhuber"},"change_message_id":"450b4d93a8214ac6a7c0ae0d770734c9f61f23ee","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        log_lines \u003d cu.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":113,"context_line":"        self.assertTrue(len(log_lines) \u003e 0)"},{"line_number":114,"context_line":"        msg \u003d \u0027sda1 is not mounted\u0027"},{"line_number":115,"context_line":"        self.assertEqual(log_lines[0], msg)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_run_once(self):"},{"line_number":118,"context_line":"        cu \u003d container_updater.ContainerUpdater({"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_da356c46","line":115,"in_reply_to":"1a4dcd0f_ea4e4ec0","updated":"2015-08-18 22:37:10.000000000","message":"Good point","commit_id":"76457e35fa6a1f1d2ff5cd8757906f0c0ecad1d5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"db7901c8487f2788d84077eb0081f774d539b210","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        containers_dir \u003d os.path.join(self.sda1, DATADIR)"},{"line_number":91,"context_line":"        os.mkdir(containers_dir)"},{"line_number":92,"context_line":"        cu.run_once()"},{"line_number":93,"context_line":"        self.assertTrue(os.path.exists(containers_dir))  # sanity check"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        cu \u003d container_updater.ContainerUpdater({"},{"line_number":96,"context_line":"            \u0027devices\u0027: self.devices_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ec80dc8d","line":93,"updated":"2015-09-02 12:53:01.000000000","message":"nit: this first part of the test doesn\u0027t seem to do much - it could have asserted that no warnings were logged, in contrast to the next part of test...","commit_id":"5b01c5eadc3a13607d2581a55007700fca0b00af"}]}