)]}'
{"test/functional/test_access_control.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2790,"context_line":"]"},{"line_number":2791,"context_line":""},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"# http_method           : HTTP methods such as PUT, GET, POST, HEAD and so on"},{"line_number":2794,"context_line":"# header                : headers for a request"},{"line_number":2795,"context_line":"# source                : source information for copy"},{"line_number":2796,"context_line":"# dest                  : destination information for copy"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_6e62973f","line":2793,"updated":"2016-04-28 06:04:46.000000000","message":"Nits)Is this only for *COPY* tests? we might be able to remove this http_method key from here.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":2790,"context_line":"]"},{"line_number":2791,"context_line":""},{"line_number":2792,"context_line":""},{"line_number":2793,"context_line":"# http_method           : HTTP methods such as PUT, GET, POST, HEAD and so on"},{"line_number":2794,"context_line":"# header                : headers for a request"},{"line_number":2795,"context_line":"# source                : source information for copy"},{"line_number":2796,"context_line":"# dest                  : destination information for copy"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_676f2c2b","line":2793,"in_reply_to":"1a122d0e_6e62973f","updated":"2016-04-29 22:36:58.000000000","message":"If there is only this patch, I know we don\u0027t need to have COPY here but there are many http methods in test_access_control.py so it\u0027s better to put here.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2793,"context_line":"# http_method           : HTTP methods such as PUT, GET, POST, HEAD and so on"},{"line_number":2794,"context_line":"# header                : headers for a request"},{"line_number":2795,"context_line":"# source                : source information for copy"},{"line_number":2796,"context_line":"# dest                  : destination information for copy"},{"line_number":2797,"context_line":"# auth_user_name        : a user name which is used for getting a token for"},{"line_number":2798,"context_line":"#                         X-Auth_Token"},{"line_number":2799,"context_line":"# service_user_name     : a user name which is used for getting a token for"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_4ef35b73","line":2796,"updated":"2016-04-28 06:04:46.000000000","message":"alright, the description for source, dest is a few lines below. They must be a tuple(or list) with 6 items.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2795,"context_line":"# source                : source information for copy"},{"line_number":2796,"context_line":"# dest                  : destination information for copy"},{"line_number":2797,"context_line":"# auth_user_name        : a user name which is used for getting a token for"},{"line_number":2798,"context_line":"#                         X-Auth_Token"},{"line_number":2799,"context_line":"# service_user_name     : a user name which is used for getting a token for"},{"line_number":2800,"context_line":"#                         X-Service-Token"},{"line_number":2801,"context_line":"# expected              : expected status code"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_b15530fb","line":2798,"range":{"start_line":2798,"start_character":26,"end_line":2798,"end_character":38},"updated":"2016-04-28 06:04:46.000000000","message":"nits) X-Auth-Token (not under score but hyphen)","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":2795,"context_line":"# source                : source information for copy"},{"line_number":2796,"context_line":"# dest                  : destination information for copy"},{"line_number":2797,"context_line":"# auth_user_name        : a user name which is used for getting a token for"},{"line_number":2798,"context_line":"#                         X-Auth_Token"},{"line_number":2799,"context_line":"# service_user_name     : a user name which is used for getting a token for"},{"line_number":2800,"context_line":"#                         X-Service-Token"},{"line_number":2801,"context_line":"# expected              : expected status code"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_c73560f7","line":2798,"range":{"start_line":2798,"start_character":26,"end_line":2798,"end_character":38},"in_reply_to":"1a122d0e_b15530fb","updated":"2016-04-29 22:36:58.000000000","message":"thanks. I will fix it in patch #253371.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2804,"context_line":""},{"line_number":2805,"context_line":"# the definition for \u0027source\u0027 and \u0027dest\u0027 in TEST_CASE_COPY_FORMAT"},{"line_number":2806,"context_line":"# account_name          : Account name. Usually the name will be automatically"},{"line_number":2807,"context_line":"#                         created by keystone"},{"line_number":2808,"context_line":"# container_name        : Container name. If \u0027UUID\u0027 is specified, a container"},{"line_number":2809,"context_line":"#                         name will be created automatically"},{"line_number":2810,"context_line":"# object_name           : Object name. If \u0027UUID\u0027 is specified, a container"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_ee04e74a","line":2807,"updated":"2016-04-28 06:04:46.000000000","message":"I\u0027d like to add a guide like \"If None is specified an account_name will be the account name in the strage_url from keystone\" yeah, i know the previous patch says as same as current here though.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":2804,"context_line":""},{"line_number":2805,"context_line":"# the definition for \u0027source\u0027 and \u0027dest\u0027 in TEST_CASE_COPY_FORMAT"},{"line_number":2806,"context_line":"# account_name          : Account name. Usually the name will be automatically"},{"line_number":2807,"context_line":"#                         created by keystone"},{"line_number":2808,"context_line":"# container_name        : Container name. If \u0027UUID\u0027 is specified, a container"},{"line_number":2809,"context_line":"#                         name will be created automatically"},{"line_number":2810,"context_line":"# object_name           : Object name. If \u0027UUID\u0027 is specified, a container"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_eaeae10d","line":2807,"in_reply_to":"1a122d0e_ee04e74a","updated":"2016-04-29 22:36:58.000000000","message":"OK,  I will add it in patch #253371. If there is other place similar to this one, I also will update it.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2814,"context_line":"#                         Can be AUTH or SERVICE to select the user account"},{"line_number":2815,"context_line":"#                         prefix or the service prefix respectively"},{"line_number":2816,"context_line":"# target_user_name      : a user name which is used for getting the project id"},{"line_number":2817,"context_line":"#                         of the target"},{"line_number":2818,"context_line":"TARGET_INFO_FORMAT \u003d (\u0027account_name\u0027, \u0027container_name\u0027, \u0027object_name\u0027,"},{"line_number":2819,"context_line":"                      \u0027prep_container_header\u0027, \u0027reseller_prefix\u0027,"},{"line_number":2820,"context_line":"                      \u0027target_user_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_3133e0f7","line":2817,"updated":"2016-04-28 06:04:46.000000000","message":"nits) \"if None is specified for target_user_name, the user name of source url will be used.\"","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":2814,"context_line":"#                         Can be AUTH or SERVICE to select the user account"},{"line_number":2815,"context_line":"#                         prefix or the service prefix respectively"},{"line_number":2816,"context_line":"# target_user_name      : a user name which is used for getting the project id"},{"line_number":2817,"context_line":"#                         of the target"},{"line_number":2818,"context_line":"TARGET_INFO_FORMAT \u003d (\u0027account_name\u0027, \u0027container_name\u0027, \u0027object_name\u0027,"},{"line_number":2819,"context_line":"                      \u0027prep_container_header\u0027, \u0027reseller_prefix\u0027,"},{"line_number":2820,"context_line":"                      \u0027target_user_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_caed6526","line":2817,"in_reply_to":"1a122d0e_3133e0f7","updated":"2016-04-29 22:36:58.000000000","message":"OK,  I will add it in patch #253371. If there is other place similar to this one, I also will update it.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                      \u0027target_user_name\u0027)"},{"line_number":2821,"context_line":""},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"RBAC_COPY \u003d ["},{"line_number":2824,"context_line":"    (\u0027COPY\u0027, None, (None, \u0027UUID\u0027, \u0027UUID\u0027, None,"},{"line_number":2825,"context_line":"     \u0027AUTH\u0027, \u0027tester\u0027), (None, \u0027UUID\u0027, \u0027UUID\u0027, None,"},{"line_number":2826,"context_line":"     \u0027AUTH\u0027, \u0027tester\u0027), \u0027tester\u0027, None, 201),"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_8e6e13fe","line":2823,"updated":"2016-04-28 06:04:46.000000000","message":"Could you try to make some comments like Christian did in follow-up [1] on the previous patch.\n\nI don\u0027t like to force you to do it but if you could do, it would be really helpful to know each test case statement.\n\n1: https://review.openstack.org/#/c/279015/","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                      \u0027target_user_name\u0027)"},{"line_number":2821,"context_line":""},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"RBAC_COPY \u003d ["},{"line_number":2824,"context_line":"    (\u0027COPY\u0027, None, (None, \u0027UUID\u0027, \u0027UUID\u0027, None,"},{"line_number":2825,"context_line":"     \u0027AUTH\u0027, \u0027tester\u0027), (None, \u0027UUID\u0027, \u0027UUID\u0027, None,"},{"line_number":2826,"context_line":"     \u0027AUTH\u0027, \u0027tester\u0027), \u0027tester\u0027, None, 201),"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_aae58938","line":2823,"in_reply_to":"1a122d0e_8e6e13fe","updated":"2016-04-29 22:36:58.000000000","message":"Will do in patch #253371. Because it is easy to check consistency for the whole tests.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e27eea4343a322eba08c041ffe554cd9d9e483b5","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"            source_info[\u0027reseller_prefix\u0027])"},{"line_number":3466,"context_line":""},{"line_number":3467,"context_line":"        headers \u003d ({} if test_case[\u0027header\u0027] is None"},{"line_number":3468,"context_line":"                   else test_case[\u0027header\u0027].copy())"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        created_resource_url \u003d self._create_resource_url("},{"line_number":3471,"context_line":"            dest_storage_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_11b3444e","line":3468,"updated":"2016-04-28 06:04:46.000000000","message":"I am probably missing something (need to play with code change) but I wonder why don\u0027t you set the empty dict to the test case tuple? If test_case[\u0027header\u0027] is {} in default, it seems we don\u0027t need this assignment.\n\nI know empty dict for method default args (e.g. def method(a\u003d{})) is dangerous but in this case the empty dict is set once and then it seems safety...","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"def22733bab7d2e510826bf3dec9e5ee64d61eca","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"            source_info[\u0027reseller_prefix\u0027])"},{"line_number":3466,"context_line":""},{"line_number":3467,"context_line":"        headers \u003d ({} if test_case[\u0027header\u0027] is None"},{"line_number":3468,"context_line":"                   else test_case[\u0027header\u0027].copy())"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        created_resource_url \u003d self._create_resource_url("},{"line_number":3471,"context_line":"            dest_storage_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_aa7589fa","line":3468,"in_reply_to":"1a122d0e_11b3444e","updated":"2016-04-29 22:36:58.000000000","message":"I created the format and used None in test cases if there is no data for keys. I thought it\u0027s better to not use default args for this test framework because it might introduce additional effort to understand code deeply.","commit_id":"51f3e45523299cf570f74a7a2eff13659bd93298"}]}