)]}'
{"swift/common/bufferedhttp.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"23a82e1154f0688eb24bde610d2e84508deb7ac7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            path \u003d path.encode(\"utf-8\")"},{"line_number":132,"context_line":"        except UnicodeError, e:"},{"line_number":133,"context_line":"            logging.exception(_(\u0027Errors happen in the process of encoding path\\"},{"line_number":134,"context_line":"                                to utf8: %s\u0027 % e.message))"},{"line_number":135,"context_line":"    path \u003d quote(\u0027/\u0027 + device + \u0027/\u0027 + str(partition) + path)"},{"line_number":136,"context_line":"    return http_connect_raw("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2B7E%3D","line":133,"updated":"2013-02-12 15:31:18.000000000","message":"May I suggest a more concise message like\n\n  \u0027Error encoding to UTF-8: %s\u0027\n\nOr at least change \"Errors happen\" to \"Error happened\".","commit_id":"417118b7ec3831071b0238ff52749a0e28a9b49f"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"5d59eece52af40daee01d1d5ca55a0de8e110680","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            path \u003d path.encode(\"utf-8\")"},{"line_number":132,"context_line":"        except UnicodeError, e:"},{"line_number":133,"context_line":"            logging.exception(_(\u0027Error encoding to UTF-8: %s\u0027 % e.message))"},{"line_number":134,"context_line":"    path \u003d quote(\u0027/\u0027 + device + \u0027/\u0027 + str(partition) + path)"},{"line_number":135,"context_line":"    return http_connect_raw("},{"line_number":136,"context_line":"        ipaddr, port, method, path, headers, query_string, ssl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BHY%3D","line":133,"updated":"2013-02-12 21:23:11.000000000","message":"I think the _(), which I guess is some string localization thingie, should only wrap the static string, and not the result of interpolation of e.message.\n\nSomething like this:\n\n  logging.exception(_(\u0027Error encoding to UTF-8: %s\u0027), e.message)","commit_id":"75fb70fe958b2754d7fb660d9925997bda8ea304"}]}