)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"699f1b8e408110e324b89ab4927f189e6e79ece7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"If we observe any duplicates - we raise an error."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Many unittests did not meet the criteria #1, and the fix was straight"},{"line_number":37,"context_line":"forward after adding the pigeon hold check.  However, at least a few"},{"line_number":38,"context_line":"just seemed to hit #2 (different seed seemed to work).  I\u0027m terrified"},{"line_number":39,"context_line":"that many existing rings may similarly be failing to meet #2, but I feel"},{"line_number":40,"context_line":"pretty strongly that as an operator it\u0027d be better to know it than not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_1ccf7c80","line":37,"updated":"2015-09-15 09:47:31.000000000","message":"(nits) pigeon *hole* check?","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0b10560e1c8a9321fe567f701036ea4c1125289e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"If we observe any duplicates - we raise an error."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Many unittests did not meet the criteria #1, and the fix was straight"},{"line_number":37,"context_line":"forward after adding the pigeon hold check.  However, at least a few"},{"line_number":38,"context_line":"just seemed to hit #2 (different seed seemed to work).  I\u0027m terrified"},{"line_number":39,"context_line":"that many existing rings may similarly be failing to meet #2, but I feel"},{"line_number":40,"context_line":"pretty strongly that as an operator it\u0027d be better to know it than not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_3b9d9859","line":37,"in_reply_to":"ba15a1d1_1ccf7c80","updated":"2015-09-15 10:33:43.000000000","message":"#willfix","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"}],"swift/common/ring/builder.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"699f1b8e408110e324b89ab4927f189e6e79ece7","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        int_replicas \u003d int(math.ceil(self.replicas))"},{"line_number":576,"context_line":"        # check the assignments of each part\u0027s replicas"},{"line_number":577,"context_line":"        for part in range(self.parts):"},{"line_number":578,"context_line":"            devs_for_part \u003d []"},{"line_number":579,"context_line":"            for replica in range(int_replicas):"},{"line_number":580,"context_line":"                if len(self._replica2part2dev[replica]) \u003c\u003d part:"},{"line_number":581,"context_line":"                    # last replica may be short on parts because of floating"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_9c794cff","line":578,"updated":"2015-09-15 09:47:31.000000000","message":"(Nits) Should we use just set() from the start?","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"699f1b8e408110e324b89ab4927f189e6e79ece7","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                len(self._replica2part2dev[replica]),"},{"line_number":590,"context_line":"                                len(self.parts),"},{"line_number":591,"context_line":"                            ))"},{"line_number":592,"context_line":"                    break"},{"line_number":593,"context_line":"                try:"},{"line_number":594,"context_line":"                    dev_id \u003d self._replica2part2dev[replica][part]"},{"line_number":595,"context_line":"                except IndexError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_fce2c89e","line":592,"updated":"2015-09-15 09:47:31.000000000","message":"If we don\u0027t maintain the last replica in floating replica count with this break, no IndexError will occur, I guess.\n\n(now thinking whether or not I\u0027m sure for this comment)","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0b10560e1c8a9321fe567f701036ea4c1125289e","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                    dev_id \u003d self._replica2part2dev[replica][part]"},{"line_number":595,"context_line":"                except IndexError:"},{"line_number":596,"context_line":"                    import pdb"},{"line_number":597,"context_line":"                    pdb.set_trace()"},{"line_number":598,"context_line":"                if dev_id \u003e\u003d dev_len or not self.devs[dev_id]:"},{"line_number":599,"context_line":"                    raise exceptions.RingValidationError("},{"line_number":600,"context_line":"                        \"Partition %d, replica %d was not allocated \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_fbcac06d","line":597,"updated":"2015-09-15 10:33:43.000000000","message":"oops - this shouldn\u0027t have been left here!","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0b10560e1c8a9321fe567f701036ea4c1125289e","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                        \"to a device.\" %"},{"line_number":602,"context_line":"                        (part, replica))"},{"line_number":603,"context_line":"                devs_for_part.append(dev_id)"},{"line_number":604,"context_line":"            if len(devs_for_part) !\u003d len(set(devs_for_part)):"},{"line_number":605,"context_line":"                raise exceptions.RingValidationError("},{"line_number":606,"context_line":"                    \"The partition %s has been assigned to \""},{"line_number":607,"context_line":"                    \"duplicate devices %r\" % ("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_bb9be871","line":604,"updated":"2015-09-15 10:33:43.000000000","message":"I\u0027m open to using a set from the start - but what is the validation here to know if there\u0027s duplicates?  I can\u0027t say \u003c replicas because of floating point replicas.","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"abf866b428735aa96917ef75bba1864336e88a64","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                        \"to a device.\" %"},{"line_number":602,"context_line":"                        (part, replica))"},{"line_number":603,"context_line":"                devs_for_part.append(dev_id)"},{"line_number":604,"context_line":"            if len(devs_for_part) !\u003d len(set(devs_for_part)):"},{"line_number":605,"context_line":"                raise exceptions.RingValidationError("},{"line_number":606,"context_line":"                    \"The partition %s has been assigned to \""},{"line_number":607,"context_line":"                    \"duplicate devices %r\" % ("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_b74e7494","line":604,"in_reply_to":"ba15a1d1_bb9be871","updated":"2015-09-16 01:51:34.000000000","message":"I see. I thought we could validate it compareing with int_replicas but...it might be worse than current one considering with floating point replicas on my second thought. Nice catch.","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"27c25ec6b7a7913895373c11304a230b98ae029b","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        for part in range(self.parts):"},{"line_number":578,"context_line":"            devs_for_part \u003d []"},{"line_number":579,"context_line":"            for replica in range(int_replicas):"},{"line_number":580,"context_line":"                if len(self._replica2part2dev[replica]) \u003c\u003d part:"},{"line_number":581,"context_line":"                    # last replica may be short on parts because of floating"},{"line_number":582,"context_line":"                    # replica count"},{"line_number":583,"context_line":"                    if replica + 1 \u003c int_replicas:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_847687a2","line":580,"updated":"2015-09-29 05:18:14.000000000","message":"on line 547/8 there is a comment saying the len method showed up too many times in profiling. So they rolled it out. We might want to think about doing the same thing here. because we are getting the len() of all partitions in each replica potentially self.parts * replica times.\n\nMaybe we need to do something like: http://paste.openstack.org/show/474579/","commit_id":"6bec0e22f28c76cf0488b7cd83c0ab331714867a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"74454adc4b0e4050a20ab6b5676726b68452646f","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        for part in range(self.parts):"},{"line_number":578,"context_line":"            devs_for_part \u003d []"},{"line_number":579,"context_line":"            for replica in range(int_replicas):"},{"line_number":580,"context_line":"                if len(self._replica2part2dev[replica]) \u003c\u003d part:"},{"line_number":581,"context_line":"                    # last replica may be short on parts because of floating"},{"line_number":582,"context_line":"                    # replica count"},{"line_number":583,"context_line":"                    if replica + 1 \u003c int_replicas:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_1a7ef569","line":580,"in_reply_to":"9a1a9d01_847687a2","updated":"2015-09-30 20:09:07.000000000","message":"yeah that doesn\u0027t look too bad, a function call is going to be a bit more expensive than a dict lookup - although the comment was changing a function call to a *local* which would be tons faster.\n\nI think actually I can change the call to range(replica) to enumerate rep2part_len and get even a bit more.\n\nI\u0027ll run it over some datasets I have and see if it speeds things u noticeably - thanks for pointing it out.","commit_id":"6bec0e22f28c76cf0488b7cd83c0ab331714867a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"27c25ec6b7a7913895373c11304a230b98ae029b","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                            \"only happen for the last replica\" % ("},{"line_number":588,"context_line":"                                replica,"},{"line_number":589,"context_line":"                                len(self._replica2part2dev[replica]),"},{"line_number":590,"context_line":"                                len(self.parts),"},{"line_number":591,"context_line":"                            ))"},{"line_number":592,"context_line":"                    break"},{"line_number":593,"context_line":"                dev_id \u003d self._replica2part2dev[replica][part]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_290af479","line":590,"updated":"2015-09-29 05:18:14.000000000","message":"self.parts is an int, so we shouldn\u0027t be getting a len() of it.","commit_id":"6bec0e22f28c76cf0488b7cd83c0ab331714867a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"74454adc4b0e4050a20ab6b5676726b68452646f","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                            \"only happen for the last replica\" % ("},{"line_number":588,"context_line":"                                replica,"},{"line_number":589,"context_line":"                                len(self._replica2part2dev[replica]),"},{"line_number":590,"context_line":"                                len(self.parts),"},{"line_number":591,"context_line":"                            ))"},{"line_number":592,"context_line":"                    break"},{"line_number":593,"context_line":"                dev_id \u003d self._replica2part2dev[replica][part]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_da94fd8b","line":590,"in_reply_to":"9a1a9d01_290af479","updated":"2015-09-30 20:09:07.000000000","message":"yup, definitely missing a test.\n\n#willfix","commit_id":"6bec0e22f28c76cf0488b7cd83c0ab331714867a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"74454adc4b0e4050a20ab6b5676726b68452646f","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                raise exceptions.RingValidationError("},{"line_number":602,"context_line":"                    \"The partition %s has been assigned to \""},{"line_number":603,"context_line":"                    \"duplicate devices %r\" % ("},{"line_number":604,"context_line":"                        part, devs_for_part))"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        if stats:"},{"line_number":607,"context_line":"            weight_of_one_part \u003d self.weight_of_one_part()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_9a8a0563","line":604,"updated":"2015-09-30 20:09:07.000000000","message":"missing a test for this one too.\n\n#willfix","commit_id":"6bec0e22f28c76cf0488b7cd83c0ab331714867a"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"327f789d5652e3dee4409826864b57e693952acc","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            random.seed(seed)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self._effective_overload \u003d self.overload"},{"line_number":415,"context_line":"        if self.overload and self.dispersion \u003c\u003d 0:"},{"line_number":416,"context_line":"            # iff we\u0027re fully dispersed we want to bring in overload"},{"line_number":417,"context_line":"            self._effective_overload \u003d min(self.overload,"},{"line_number":418,"context_line":"                                           self.get_required_overload())"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_68be18d6","line":415,"updated":"2015-10-01 21:16:07.000000000","message":"Not very important, but can dispersion ever get smaller then 0?","commit_id":"3d76f153fca6cbb16cec90ec86f5132481618360"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"13f19893a984ebe954d33c6055cf9bd5508eaaac","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            random.seed(seed)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self._effective_overload \u003d self.overload"},{"line_number":415,"context_line":"        if self.overload and self.dispersion \u003c\u003d 0:"},{"line_number":416,"context_line":"            # iff we\u0027re fully dispersed we want to bring in overload"},{"line_number":417,"context_line":"            self._effective_overload \u003d min(self.overload,"},{"line_number":418,"context_line":"                                           self.get_required_overload())"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_66088992","line":415,"in_reply_to":"9a1a9d01_68be18d6","updated":"2015-10-01 22:05:19.000000000","message":"no, it\u0027s just defensive.","commit_id":"3d76f153fca6cbb16cec90ec86f5132481618360"},{"author":{"_account_id":11317,"name":"Eran Rom","email":"eran@itsonlyme.name","username":"eranr"},"change_message_id":"327f789d5652e3dee4409826864b57e693952acc","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"                            # anything is better than the alternative"},{"line_number":1366,"context_line":"                            subtier \u003d random.choice(unused_sibling_tiers)"},{"line_number":1367,"context_line":"                        else:"},{"line_number":1368,"context_line":"                            warnings.warn(RingValidationWarning("},{"line_number":1369,"context_line":"                                \"All devices in tier %r already \""},{"line_number":1370,"context_line":"                                \"contain a replica\" % (tier,)))"},{"line_number":1371,"context_line":"                    tier \u003d subtier"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_08dc3c45","line":1368,"updated":"2015-10-01 21:16:07.000000000","message":"I wonder if this one makes the validation in line 615 redundant. One can ask the opposite question, but having it here seems better as it happens earlier and not dependent on a call to validate after rebalance.","commit_id":"3d76f153fca6cbb16cec90ec86f5132481618360"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"13f19893a984ebe954d33c6055cf9bd5508eaaac","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"                            # anything is better than the alternative"},{"line_number":1366,"context_line":"                            subtier \u003d random.choice(unused_sibling_tiers)"},{"line_number":1367,"context_line":"                        else:"},{"line_number":1368,"context_line":"                            warnings.warn(RingValidationWarning("},{"line_number":1369,"context_line":"                                \"All devices in tier %r already \""},{"line_number":1370,"context_line":"                                \"contain a replica\" % (tier,)))"},{"line_number":1371,"context_line":"                    tier \u003d subtier"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_e63b3937","line":1368,"in_reply_to":"9a1a9d01_08dc3c45","updated":"2015-10-01 22:05:19.000000000","message":"you might have existing parts doubled up that don\u0027t get reassigned so the validate is still valid.  Also this check will probably go away in the long run.  It\u0027d be better to just never head down into this tier than get here and end up sad.","commit_id":"3d76f153fca6cbb16cec90ec86f5132481618360"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"023a8c51acd8bf252e7bb35beb068dd0528cb24a","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                \"than %(num_devices)s devices (%(quip)s)\" % {"},{"line_number":405,"context_line":"                    \u0027replicas\u0027: self.replicas,"},{"line_number":406,"context_line":"                    \u0027num_devices\u0027: num_devices,"},{"line_number":407,"context_line":"                    \u0027quip\u0027: \"http://lmgtfy.com/?q\u003dpigeonhole+principle\","},{"line_number":408,"context_line":"                }))"},{"line_number":409,"context_line":"        old_replica2part2dev \u003d copy.deepcopy(self._replica2part2dev)"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a1a9d01_2b38ec3c","line":407,"updated":"2015-10-02 20:23:07.000000000","message":"Cool Link.!!","commit_id":"1a577c623b65f0d5b0e44fa6a79794cf61deef04"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"087f001b9899ba2d39fffd990d16ca3179d4ead8","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self._effective_overload \u003d self.overload"},{"line_number":414,"context_line":"        if self.overload and self.dispersion \u003c\u003d 0:"},{"line_number":415,"context_line":"            # iff we\u0027re fully dispersed we want to bring in overload"},{"line_number":416,"context_line":"            self._effective_overload \u003d min(self.overload,"},{"line_number":417,"context_line":"                                           self.get_required_overload())"},{"line_number":418,"context_line":"        self.logger.debug(\"Using effective overload of %f\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_92fcc53f","line":415,"updated":"2015-10-03 00:12:59.000000000","message":"NIT: s/iff/if/ in comment","commit_id":"5070869ac0e6a2d577dd4054ffbcbffd06db3c5b"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a09d336225b33f13746a5d7c1d52425099a7477d","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self._effective_overload \u003d self.overload"},{"line_number":414,"context_line":"        if self.overload and self.dispersion \u003c\u003d 0:"},{"line_number":415,"context_line":"            # iff we\u0027re fully dispersed we want to bring in overload"},{"line_number":416,"context_line":"            self._effective_overload \u003d min(self.overload,"},{"line_number":417,"context_line":"                                           self.get_required_overload())"},{"line_number":418,"context_line":"        self.logger.debug(\"Using effective overload of %f\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_fa49538f","line":415,"in_reply_to":"9a1a9d01_92fcc53f","updated":"2015-10-03 08:24:16.000000000","message":"iff \u003d\u003d \"if and only if\" [1]\n\n1. https://en.wikipedia.org/wiki/If_and_only_if","commit_id":"5070869ac0e6a2d577dd4054ffbcbffd06db3c5b"}],"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"699f1b8e408110e324b89ab4927f189e6e79ece7","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        self.assertRaises(SystemExit, ringbuilder.main, argv)"},{"line_number":1006,"context_line":"        ring \u003d RingBuilder.load(self.tmpfile)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        # Check that second device in ring is not affected"},{"line_number":1009,"context_line":"        dev \u003d ring.devs[0]"},{"line_number":1010,"context_line":"        self.assertEqual(dev[\u0027ip\u0027], \u0027127.0.0.1\u0027)"},{"line_number":1011,"context_line":"        self.assertEqual(dev[\u0027port\u0027], 6000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_f73181ed","line":1008,"updated":"2015-09-15 09:47:31.000000000","message":"(Nits) not related to this change, but seems \"first device\".","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0b10560e1c8a9321fe567f701036ea4c1125289e","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        self.assertRaises(SystemExit, ringbuilder.main, argv)"},{"line_number":1006,"context_line":"        ring \u003d RingBuilder.load(self.tmpfile)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        # Check that second device in ring is not affected"},{"line_number":1009,"context_line":"        dev \u003d ring.devs[0]"},{"line_number":1010,"context_line":"        self.assertEqual(dev[\u0027ip\u0027], \u0027127.0.0.1\u0027)"},{"line_number":1011,"context_line":"        self.assertEqual(dev[\u0027port\u0027], 6000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_9bae2484","line":1008,"in_reply_to":"ba15a1d1_f73181ed","updated":"2015-09-15 10:33:43.000000000","message":"#willfix","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"699f1b8e408110e324b89ab4927f189e6e79ece7","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"            ringbuilder.main(argv)"},{"line_number":1738,"context_line":"        except SystemExit as e:"},{"line_number":1739,"context_line":"            err \u003d e"},{"line_number":1740,"context_line":"        self.assertEqual(err.code, 0)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_invalid_device_name(self):"},{"line_number":1743,"context_line":"        self.create_sample_ring()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_bdcf607e","line":1740,"updated":"2015-09-15 09:47:31.000000000","message":"My tox (and gerrit) failed here with imbalance warning but just nosetests sitll works well.\n\nThe diffs are:\n\nnose:\n\n[{\u0027replication_port\u0027: 6000, \u0027weight\u0027: 10, \u0027zone\u0027: 0, \u0027ip\u0027: \u0027127.0.0.1\u0027, \u0027region\u0027: 0, \u0027port\u0027: 6000, \u0027replication_ip\u0027: \u0027127.0.0.1\u0027, \u0027parts\u0027: 6, \u0027meta\u0027: \u0027some meta data\u0027, \u0027device\u0027: \u0027sda1\u0027, \u0027parts_wanted\u0027: 1, \u0027id\u0027: 0}, {\u0027replication_port\u0027: 6001, \u0027weight\u0027: 100.0, \u0027zone\u0027: 1, \u0027ip\u0027: \u0027127.0.0.2\u0027, \u0027region\u0027: 1, \u0027port\u0027: 6001, \u0027replication_ip\u0027: \u0027127.0.0.2\u0027, \u0027parts\u0027: 62, \u0027meta\u0027: \u0027\u0027, \u0027device\u0027: \u0027sda2\u0027, \u0027parts_wanted\u0027: 0, \u0027id\u0027: 1}, {\u0027replication_port\u0027: 6002, \u0027weight\u0027: 100.0, \u0027zone\u0027: 2, \u0027ip\u0027: \u0027127.0.0.3\u0027, \u0027region\u0027: 2, \u0027port\u0027: 6002, \u0027replication_ip\u0027: \u0027127.0.0.3\u0027, \u0027parts\u0027: 62, \u0027meta\u0027: \u0027\u0027, \u0027device\u0027: \u0027sdc3\u0027, \u0027parts_wanted\u0027: 0, \u0027id\u0027: 2}, {\u0027replication_port\u0027: 6003, \u0027weight\u0027: 100.0, \u0027zone\u0027: 3, \u0027ip\u0027: \u0027127.0.0.4\u0027, \u0027region\u0027: 3, \u0027port\u0027: 6003, \u0027replication_ip\u0027: \u0027127.0.0.4\u0027, \u0027parts\u0027: 62, \u0027meta\u0027: \u0027\u0027, \u0027device\u0027: \u0027sdd4\u0027, \u0027parts_wanted\u0027: 0, \u0027id\u0027: 3}]\n\ntox:\n\n[{\u0027id\u0027: 0, \u0027replication_port\u0027: 6000, \u0027port\u0027: 6000, \u0027meta\u0027: \u0027some meta data\u0027, \u0027zone\u0027: 0, \u0027parts\n_wanted\u0027: 0, \u0027parts\u0027: 7, \u0027ip\u0027: \u0027127.0.0.1\u0027, \u0027device\u0027: \u0027sda1\u0027, \u0027weight\u0027: 10, \u0027replication_ip\u0027: \n\u0027127.0.0.1\u0027, \u0027region\u0027: 0}, {\u0027id\u0027: 1, \u0027replication_port\u0027: 6001, \u0027port\u0027: 6001, \u0027meta\u0027: \u0027\u0027, \u0027zone\n\u0027: 1, \u0027parts_wanted\u0027: 0, \u0027parts\u0027: 62, \u0027ip\u0027: \u0027127.0.0.2\u0027, \u0027device\u0027: \u0027sda2\u0027, \u0027weight\u0027: 100.0, \u0027r\neplication_ip\u0027: \u0027127.0.0.2\u0027, \u0027region\u0027: 1}, {\u0027id\u0027: 2, \u0027replication_port\u0027: 6002, \u0027port\u0027: 6002, \u0027\nmeta\u0027: \u0027\u0027, \u0027zone\u0027: 2, \u0027parts_wanted\u0027: 1, \u0027parts\u0027: 61, \u0027ip\u0027: \u0027127.0.0.3\u0027, \u0027device\u0027: \u0027sdc3\u0027, \u0027we\night\u0027: 100.0, \u0027replication_ip\u0027: \u0027127.0.0.3\u0027, \u0027region\u0027: 2}, {\u0027id\u0027: 3, \u0027replication_port\u0027: 6003,\n \u0027port\u0027: 6003, \u0027meta\u0027: \u0027\u0027, \u0027zone\u0027: 3, \u0027parts_wanted\u0027: 0, \u0027parts\u0027: 62, \u0027ip\u0027: \u0027127.0.0.4\u0027, \u0027devi\nce\u0027: \u0027sdd4\u0027, \u0027weight\u0027: 100.0, \u0027replication_ip\u0027: \u0027127.0.0.4\u0027, \u0027region\u0027: 3}]\n\n\nI\u0027m not sure why just only tox failed but absolutely the setting about seeds to be 2 seems to cause to assign 7 partitions to device 0 and it makes tox failure on gate.","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0b10560e1c8a9321fe567f701036ea4c1125289e","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"            ringbuilder.main(argv)"},{"line_number":1738,"context_line":"        except SystemExit as e:"},{"line_number":1739,"context_line":"            err \u003d e"},{"line_number":1740,"context_line":"        self.assertEqual(err.code, 0)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_invalid_device_name(self):"},{"line_number":1743,"context_line":"        self.create_sample_ring()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_dbd25c00","line":1740,"in_reply_to":"ba15a1d1_bdcf607e","updated":"2015-09-15 10:33:43.000000000","message":"ah good, i\u0027ll try to reproduce with tox - maybe there is a seed that will work with both test runners (weird that they\u0027re different?)","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"abf866b428735aa96917ef75bba1864336e88a64","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"            ringbuilder.main(argv)"},{"line_number":1738,"context_line":"        except SystemExit as e:"},{"line_number":1739,"context_line":"            err \u003d e"},{"line_number":1740,"context_line":"        self.assertEqual(err.code, 0)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_invalid_device_name(self):"},{"line_number":1743,"context_line":"        self.create_sample_ring()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_77d53cb7","line":1740,"in_reply_to":"ba15a1d1_dbd25c00","updated":"2015-09-16 01:51:34.000000000","message":"Yup, that\u0027s odd thing. The seeds should make a same behavior for test runners.\n\nI thought another idea[1] to prevent the possibility for different behavior of the environment but still not sure why they behaves as different.\n(both local env and tox env, random.seed seemed to cause same randomization :()\n\n1: https://review.openstack.org/#/c/223422/","commit_id":"88c8f8142d9aaad0388dc40ffc27f1205518d445"}]}
