)]}'
{"swift/common/middleware/fake_footers.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9fea67f01b843de3d17df03879c67cac49c5c658","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        mod_resp_headers \u003d ["},{"line_number":155,"context_line":"            (h, v) for h, v in self._response_headers"},{"line_number":156,"context_line":"            if h.lower() not in footers.keys()]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for pair in footers.items():"},{"line_number":159,"context_line":"            mod_resp_headers.append(pair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0a443272","line":156,"updated":"2015-09-14 12:46:17.000000000","message":"We don\u0027t know that footers keys are lower case. I guess they are in practice or you would not have proposed this, but there is no requirement in the callback \u0027contract\u0027.\n\nnit: \"in footers\" is sufficient, don\u0027t need \"keys()\"","commit_id":"ef047b0a43c76ef6569a0a33fc6214c80d05c546"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b829ef84e18832ccdbcd8d78ff319fb0fd4e6294","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        footers \u003d self.retrieve_footers(env)"},{"line_number":153,"context_line":"        mod_resp_headers \u003d []"},{"line_number":154,"context_line":"        for h, v in self._response_headers:"},{"line_number":155,"context_line":"            if h.lower() in [f.lower() for f in footers.keys()]:"},{"line_number":156,"context_line":"                # Do not add if h will be a duplicate"},{"line_number":157,"context_line":"                self.logger.error(\"Replacing Remnant header: %s\" % h.lower())"},{"line_number":158,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_98c5c33e","line":155,"updated":"2015-09-22 08:12:53.000000000","message":"nit: construct the list of lower case keys once before the loop","commit_id":"17fb851e6eb1aabca09013c5c7f6463738880259"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b829ef84e18832ccdbcd8d78ff319fb0fd4e6294","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        for h, v in self._response_headers:"},{"line_number":155,"context_line":"            if h.lower() in [f.lower() for f in footers.keys()]:"},{"line_number":156,"context_line":"                # Do not add if h will be a duplicate"},{"line_number":157,"context_line":"                self.logger.error(\"Replacing Remnant header: %s\" % h.lower())"},{"line_number":158,"context_line":"            else:"},{"line_number":159,"context_line":"                # Add the existing headers"},{"line_number":160,"context_line":"                mod_resp_headers.append((h, v))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_98cce362","line":157,"updated":"2015-09-22 08:12:53.000000000","message":"warning level maybe? IDK, change it back if you prefer error :)","commit_id":"17fb851e6eb1aabca09013c5c7f6463738880259"},{"author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"change_message_id":"0193dadb5f1c7562c8ebe5ecd5e317bb5b05f02d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            env[\u0027wsgi.input\u0027] \u003d self.ReaderWrapper(env, callback, self)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        resp \u003d self._app_call(env)"},{"line_number":152,"context_line":"        footers \u003d self.retrieve_footers(env)"},{"line_number":153,"context_line":"        footer_keys \u003d [f.lower() for f in footers.keys()]"},{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d6dd3815","line":152,"updated":"2015-09-22 14:47:56.000000000","message":"Maybe consider adding a comment explaining the ordering (that is that we\u0027re removing any keys we received from the obj server that are contained in the fake footers as opposed to the other way around).","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"eff4fe58dd09895a72e1e8c4fbacc24c57d89514","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            env[\u0027wsgi.input\u0027] \u003d self.ReaderWrapper(env, callback, self)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        resp \u003d self._app_call(env)"},{"line_number":152,"context_line":"        footers \u003d self.retrieve_footers(env)"},{"line_number":153,"context_line":"        footer_keys \u003d [f.lower() for f in footers.keys()]"},{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_3d99e56e","line":152,"in_reply_to":"ba15a1d1_d6dd3815","updated":"2015-09-22 19:20:46.000000000","message":"will add a comment here.","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"},{"author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"change_message_id":"0193dadb5f1c7562c8ebe5ecd5e317bb5b05f02d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        resp \u003d self._app_call(env)"},{"line_number":152,"context_line":"        footers \u003d self.retrieve_footers(env)"},{"line_number":153,"context_line":"        footer_keys \u003d [f.lower() for f in footers.keys()]"},{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"},{"line_number":156,"context_line":"            if h.lower() in footer_keys:"},{"line_number":157,"context_line":"                # Do not add if h will be a duplicate"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_968340cc","line":154,"updated":"2015-09-22 14:47:56.000000000","message":"NIT - Could you do this with 1 loop over \u0027_response_headers\u0027 where you append directly to \u0027footer_keys\u0027 IFF _response_header KEY value is not contained in the footers key.  Then just return the new footers list ?","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"eff4fe58dd09895a72e1e8c4fbacc24c57d89514","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        resp \u003d self._app_call(env)"},{"line_number":152,"context_line":"        footers \u003d self.retrieve_footers(env)"},{"line_number":153,"context_line":"        footer_keys \u003d [f.lower() for f in footers.keys()]"},{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"},{"line_number":156,"context_line":"            if h.lower() in footer_keys:"},{"line_number":157,"context_line":"                # Do not add if h will be a duplicate"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_5d44d919","line":154,"in_reply_to":"ba15a1d1_968340cc","updated":"2015-09-22 19:20:46.000000000","message":"the footers key list is only used here for the comparison.  the product of the loop is really the list of pairs that we need to include in the response.","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"},{"author":{"_account_id":17156,"name":"Hamdi Roumani","email":"roumani@ca.ibm.com","username":"hroumani"},"change_message_id":"0193dadb5f1c7562c8ebe5ecd5e317bb5b05f02d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"},{"line_number":156,"context_line":"            if h.lower() in footer_keys:"},{"line_number":157,"context_line":"                # Do not add if h will be a duplicate"},{"line_number":158,"context_line":"                self.logger.warn(\"Replacing Remnant header: %s\" % h.lower())"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                # Add the existing headers"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_aba861dc","line":157,"updated":"2015-09-22 14:47:56.000000000","message":"NIT - I think it may be more clear if you move this comment up above the IF statement (~156) and you can get rid of the comment in the ELSE statement as its essentially implied.","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"eff4fe58dd09895a72e1e8c4fbacc24c57d89514","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        mod_resp_headers \u003d []"},{"line_number":155,"context_line":"        for h, v in self._response_headers:"},{"line_number":156,"context_line":"            if h.lower() in footer_keys:"},{"line_number":157,"context_line":"                # Do not add if h will be a duplicate"},{"line_number":158,"context_line":"                self.logger.warn(\"Replacing Remnant header: %s\" % h.lower())"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                # Add the existing headers"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_7d8f5d23","line":157,"in_reply_to":"ba15a1d1_aba861dc","updated":"2015-09-22 19:20:46.000000000","message":"I sort of like the simple statements here next to the action.  But I might change this slightly.","commit_id":"00fba1eed35958c6090954ff84980f1f04a6d17d"}]}
