)]}'
{"test/functional/test_object.py":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"7b8c5343a70bf399ddeb7514903aa43136482761","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                parsed.path,"},{"line_number":1095,"context_line":"                self.container,"},{"line_number":1096,"context_line":"                object_name), \u0027test\u0027, {\u0027X-Auth-Token\u0027: token})"},{"line_number":1097,"context_line":"            return check_response(conn)"},{"line_number":1098,"context_line":"        resp \u003d retry(put)"},{"line_number":1099,"context_line":"        self.assertEqual(resp.read(), \u0027\u0027)"},{"line_number":1100,"context_line":"        self.assertEqual(resp.status, 201)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_17c1672e","line":1097,"updated":"2015-09-15 21:35:10.000000000","message":"I see that you define \"put\" several times in these tests, with the same contents except for possibly the object name string.  It might be better maintenance-wise to have one put_name method that accepted an object name argument.  (sort of like the \u0027put_obj\u0027 method somewhere else in this file)","commit_id":"bb3ca11a85498a053e523b743265913402f8c601"},{"author":{"_account_id":7433,"name":"Richard Hawkins","email":"richard.hawkins@rackspace.com","username":"hurricanerix"},"change_message_id":"0544cc00ddb58c47a924ad59cc29e16d7c1c6435","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                parsed.path,"},{"line_number":1095,"context_line":"                self.container,"},{"line_number":1096,"context_line":"                object_name), \u0027test\u0027, {\u0027X-Auth-Token\u0027: token})"},{"line_number":1097,"context_line":"            return check_response(conn)"},{"line_number":1098,"context_line":"        resp \u003d retry(put)"},{"line_number":1099,"context_line":"        self.assertEqual(resp.read(), \u0027\u0027)"},{"line_number":1100,"context_line":"        self.assertEqual(resp.status, 201)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a21b8272","line":1097,"in_reply_to":"ba15a1d1_17c1672e","updated":"2015-09-16 12:15:22.000000000","message":"I thought the same thing, but the put method is passed to retry, which calls it, so I wasn\u0027t sure if passing the object name was possible.  I guess I can look at the retry method closer to see what is there.","commit_id":"bb3ca11a85498a053e523b743265913402f8c601"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f9c9079be96a27b6edc2e04169c60346347f8a9f","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                parsed.path,"},{"line_number":1095,"context_line":"                self.container,"},{"line_number":1096,"context_line":"                object_name), \u0027test\u0027, {\u0027X-Auth-Token\u0027: token})"},{"line_number":1097,"context_line":"            return check_response(conn)"},{"line_number":1098,"context_line":"        resp \u003d retry(put)"},{"line_number":1099,"context_line":"        self.assertEqual(resp.read(), \u0027\u0027)"},{"line_number":1100,"context_line":"        self.assertEqual(resp.status, 201)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c1bc63de","line":1097,"in_reply_to":"ba15a1d1_a21b8272","updated":"2015-09-16 18:57:51.000000000","message":"well you could make a factory for the put method\n\n    def make_put(object_name):\n        def put(url, token, parsed, conn):\n            ...\n        return put","commit_id":"bb3ca11a85498a053e523b743265913402f8c601"}]}