)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"106d7e8aa3dd373b7990bd1253f01612acd8051f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch add a test to figure out the failure case behavior of"},{"line_number":10,"context_line":"object-server when the connection from proxy-server disconnected"},{"line_number":11,"context_line":"during commit phase. Especially, this patch was made to focus on"},{"line_number":12,"context_line":"making sure whether or not contaienr updates occurs in the situation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In the process of working on that test we made the behavior of the"},{"line_number":15,"context_line":"object-server when the connection from the proxy-server disconnected"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_801a3316","line":12,"updated":"2015-09-22 02:54:14.000000000","message":"s/contaienr/container\n\nBut that\u0027s just a NIT, and seeing as there is already a +2, I\u0027m happy to let it through with it.","commit_id":"d4aaaa3e320a88828143e709ff9b9bed72c9318b"}],"test/unit/obj/test_server.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"52243204ee751b53b92b2169bfef6c2c656e618a","unresolved":false,"context_lines":[{"line_number":5318,"context_line":"        container_update \u003d \\"},{"line_number":5319,"context_line":"            \u0027swift.obj.server.ObjectController.container_update\u0027"},{"line_number":5320,"context_line":"        with nested(mock.patch(read_commit), mock.patch(container_update)) as \\"},{"line_number":5321,"context_line":"                (_read_commit_call, _container_update):"},{"line_number":5322,"context_line":"            _read_commit_call.side_effect \u003d HTTPClientDisconnect()"},{"line_number":5323,"context_line":"            conn \u003d bufferedhttp.http_connect("},{"line_number":5324,"context_line":"                \u0027127.0.0.1\u0027, self.port, \u0027sda1\u0027, \u00270\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_61af612a","line":5321,"updated":"2015-09-17 22:40:24.000000000","message":"in py2.7+ land we have native multiple with statement syntax [1] which is better than nested [2].\n\n1. https://docs.python.org/2/reference/compound_stmts.html#the-with-statement \u003c\u003d note Changed in version 2.7\n\n2. https://docs.python.org/2/library/contextlib.html#contextlib.nested \u003c\u003d note the deprecation warning","commit_id":"030e6b52aaae70bda9fa28f10a5319198593af42"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"e489ed5596ec215301b0b358cda33d6a874d6478","unresolved":false,"context_lines":[{"line_number":5547,"context_line":"            expect_headers \u003d context[\u0027expect_headers\u0027]"},{"line_number":5548,"context_line":"            self.assertEqual(expect_headers[\u0027X-Obj-Multiphase-Commit\u0027], \u0027yes\u0027)"},{"line_number":5549,"context_line":"            # N.B. no X-Obj-Metadata-Footer header"},{"line_number":5550,"context_line":"            self.assertNotIn(\u0027X-Obj-Metadata-Footer\u0027, expect_headers)"},{"line_number":5551,"context_line":""},{"line_number":5552,"context_line":"            conn \u003d context[\u0027conn\u0027]"},{"line_number":5553,"context_line":"            # send commit confirmation to start phase2"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_138b3f20","line":5550,"updated":"2015-09-18 10:35:20.000000000","message":"Actually, I\u0027m wondering why replicated request will make a multiphase commit but it seems okay to keep this because we can always make sure with this if object-server could be acceptable the multiphase.","commit_id":"d4aaaa3e320a88828143e709ff9b9bed72c9318b"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5eaac748bc21e19351d01b7ed4f8588a3761f8a3","unresolved":false,"context_lines":[{"line_number":5547,"context_line":"            expect_headers \u003d context[\u0027expect_headers\u0027]"},{"line_number":5548,"context_line":"            self.assertEqual(expect_headers[\u0027X-Obj-Multiphase-Commit\u0027], \u0027yes\u0027)"},{"line_number":5549,"context_line":"            # N.B. no X-Obj-Metadata-Footer header"},{"line_number":5550,"context_line":"            self.assertNotIn(\u0027X-Obj-Metadata-Footer\u0027, expect_headers)"},{"line_number":5551,"context_line":""},{"line_number":5552,"context_line":"            conn \u003d context[\u0027conn\u0027]"},{"line_number":5553,"context_line":"            # send commit confirmation to start phase2"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_97c60515","line":5550,"in_reply_to":"ba15a1d1_138b3f20","updated":"2015-09-21 19:34:10.000000000","message":"it\u0027s kind of just a continuation/extrapolation of test_expect_on_multiphase_put - but I think it\u0027s fine to assert the behavior.  \n\nI\u0027d hope that if the behavior in this case ever needed to change it should be clear that adjusting *this* test would be ok.  I had originally named it something like \"test-multiphase-put-no-metadata-oddly-replicated\"- so maybe having a comment to indicate the current implementation doesn\u0027t depend on this behavior would be welcome if it\u0027s not already obvious...","commit_id":"d4aaaa3e320a88828143e709ff9b9bed72c9318b"}]}