)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb679817c864964a02712bc0f189acebb7368b08","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"                    dev[\u0027parts_wanted\u0027] +\u003d 1"},{"line_number":1050,"context_line":"                    dev[\u0027parts\u0027] -\u003d 1"},{"line_number":1051,"context_line":"                    removed_dev_parts[part].append(replica)"},{"line_number":1052,"context_line":"                    break"},{"line_number":1053,"context_line":"                dev_ids_for_part.add(dev_id)"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        # Now we gather partitions that are \"at risk\" because they aren\u0027t"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_5d3847a0","line":1052,"updated":"2015-09-23 08:11:20.000000000","message":"because dispersion doesn\u0027t like to pick up parts if it doesn\u0027t have a device with parts_wanted to eat them we special case duplicate assignments and make sure they\u0027re always picked up (just liked removed_dev_parts)\n\nthe break is debatable, if you have multiple replicas of the part with duplicate device assignment it\u0027s probably better to move multiple replicas of the part in the same rebalance than to leave the duplicated.","commit_id":"9d4e9656b3b7c735d63031603fab21e6eddf070c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb679817c864964a02712bc0f189acebb7368b08","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"                            (d[\u0027region\u0027], d[\u0027zone\u0027], d[\u0027ip\u0027], d[\u0027id\u0027])"},{"line_number":1363,"context_line":"                            not in occupied_tiers_by_tier_len[4]"},{"line_number":1364,"context_line":"                            for d in tier2devs[tier]):"},{"line_number":1365,"context_line":"                        print \"You\u0027re going to have a bad time\""},{"line_number":1366,"context_line":"                    depth +\u003d 1"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"                dev \u003d tier2devs[tier][-1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_7dd66b50","line":1365,"updated":"2015-09-23 08:11:20.000000000","message":"so the idea here to is refactor the selection of tier (roomiest, fudgiest) into something that instead of max will iterate over the sorted tiers with room/fudge and just ignore tiers that don\u0027t have un-used devices for this part.\n\nOne idea is to do a closure so I can bail out early if there\u0027s a tier with room and no replicas of the part already.","commit_id":"9d4e9656b3b7c735d63031603fab21e6eddf070c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eb679817c864964a02712bc0f189acebb7368b08","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"        def walk_tree(tier, replica_count):"},{"line_number":1475,"context_line":"            if len(tier) \u003d\u003d 4:"},{"line_number":1476,"context_line":"                # devices only get one replica"},{"line_number":1477,"context_line":"                mr \u003d {tier: 1}"},{"line_number":1478,"context_line":"            else:"},{"line_number":1479,"context_line":"                mr \u003d {tier: replica_count}"},{"line_number":1480,"context_line":"            if tier in tier2children:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1d55efc0","line":1477,"updated":"2015-09-23 08:11:20.000000000","message":"servers with less than max_replica_at_tier[server] devices have this weird property where it thinks you can a device that \"shouldn\u0027t hold more than 2 replicas\" - but the truth is no device \"should hold more than 2 replica\" - make the dispersion reporting get this right.","commit_id":"9d4e9656b3b7c735d63031603fab21e6eddf070c"}]}
