)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"response is sent and read successfully by the client, you simply have to"},{"line_number":16,"context_line":"set keepalive to False when you create a wsgi server."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Add a parameter to take advantage of the new(ish) eventlet socket timeout"},{"line_number":19,"context_line":"behaviour. Allows closing idle client connections after a period of"},{"line_number":20,"context_line":"time."},{"line_number":21,"context_line":"eg:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_a593cdf9","line":18,"updated":"2015-11-09 11:48:27.000000000","message":"this is not true now","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"45772cc2584f14601c2f6ec460ece65cf528ed71","unresolved":false,"context_lines":[{"line_number":25,"context_line":"for swift configuration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DocImpact:"},{"line_number":28,"context_line":"Added wsgi_keep_alive option (default\u003dFalse)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"SecurityImpact"},{"line_number":31,"context_line":"Closes-Bug: #1361360"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_72f3519f","line":28,"updated":"2015-11-09 19:38:30.000000000","message":"option in the code is keepalive, should update the commit message to match","commit_id":"886e6ccb340c34622eb3e31e997e988ee22becfb"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"5c8d43849e7a52fff54d3023ebd3d584c132b124","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Eventlet green threads not released back to pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Presently, the wsgi server allows persist connections hence even after"},{"line_number":10,"context_line":"the response is sent to the client, it doesn\u0027t close the client socket"},{"line_number":11,"context_line":"connection."},{"line_number":12,"context_line":"Because of this problem, the green thread is not released back to the pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_dbcbe951","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":59},"updated":"2016-07-19 19:32:27.000000000","message":"missing punctuation: connections hence -\u003e connections; hence *or* connections. Hence,","commit_id":"0e4ee8d9a0ce658c90f675535b9acd9af2fd14b1"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"5c8d43849e7a52fff54d3023ebd3d584c132b124","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Presently, the wsgi server allows persist connections hence even after"},{"line_number":10,"context_line":"the response is sent to the client, it doesn\u0027t close the client socket"},{"line_number":11,"context_line":"connection."},{"line_number":12,"context_line":"Because of this problem, the green thread is not released back to the pool."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In order to close the client socket connection explicitly after the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_bbf43587","line":11,"updated":"2016-07-19 19:32:27.000000000","message":"Blank line between paragraphs or move following sentence onto this line?","commit_id":"0e4ee8d9a0ce658c90f675535b9acd9af2fd14b1"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"5c8d43849e7a52fff54d3023ebd3d584c132b124","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In order to close the client socket connection explicitly after the"},{"line_number":15,"context_line":"response is sent and read successfully by the client, you simply have to"},{"line_number":16,"context_line":"set keepalive to False when you create a wsgi server."},{"line_number":17,"context_line":"Allows closing idle client connections after a period of"},{"line_number":18,"context_line":"time."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_fb450db3","line":16,"updated":"2016-07-19 19:32:27.000000000","message":"ditto: blank line or move following sentence onto this line","commit_id":"0e4ee8d9a0ce658c90f675535b9acd9af2fd14b1"}],"etc/account-server.conf-sample":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# Keep Alive is set to False, all connections will be closed"},{"line_number":20,"context_line":"# after serving one request."},{"line_number":21,"context_line":"keepalive \u003d False"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# You can specify default log routing here if you want:"},{"line_number":24,"context_line":"# log_name \u003d swift"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_e53f9523","line":21,"updated":"2015-11-09 11:48:27.000000000","message":"/keepalive/# keepalive/\n\nbecause it\u0027s default.","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"}],"etc/container-server.conf-sample":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# Keep Alive is set to False by default all connections will be closed"},{"line_number":20,"context_line":"# after serving one request."},{"line_number":21,"context_line":"keepalive \u003d False"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# This is a comma separated list of hosts allowed in the X-Container-Sync-To"},{"line_number":24,"context_line":"# field for containers. This is the old-style of using container sync. It is"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_8517a9a2","line":21,"updated":"2015-11-09 11:48:27.000000000","message":"/keepalive/# keepalive/\n\nbecause it\u0027s default.","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"}],"etc/object-server.conf-sample":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# Keep Alive is False by default all connections will be closed"},{"line_number":29,"context_line":"# after serving one request."},{"line_number":30,"context_line":"keepalive \u003d False"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# You can specify default log routing here if you want:"},{"line_number":33,"context_line":"# log_name \u003d swift"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_a520adf8","line":30,"updated":"2015-11-09 11:48:27.000000000","message":"/keepalive/# keepalive/\n\nbecause it\u0027s default.","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"}],"etc/proxy-server.conf-sample":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Maximum concurrent requests per worker"},{"line_number":32,"context_line":"# max_clients \u003d 1024"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Keep Alive is set to False ,all connections will be closed after"},{"line_number":35,"context_line":"# serving one request."},{"line_number":36,"context_line":"keepalive \u003d False"},{"line_number":37,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_a5774d01","line":34,"updated":"2015-11-09 11:48:27.000000000","message":"nit: /\\s,/,\\s/","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Keep Alive is set to False ,all connections will be closed after"},{"line_number":35,"context_line":"# serving one request."},{"line_number":36,"context_line":"keepalive \u003d False"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# Set the following two lines to enable SSL. This is for testing only."},{"line_number":39,"context_line":"# cert_file \u003d /etc/swift/proxy.crt"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da85f559_4588e1e7","line":36,"updated":"2015-11-09 11:48:27.000000000","message":"/keepalive/# keepalive/\n\nbecause it\u0027s default.","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"2aab5bb128304c7df191b305ac24ed316179693e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Keep Alive is False by default, all connections will be closed after serving"},{"line_number":35,"context_line":"# one request when set to False."},{"line_number":36,"context_line":"# keepalive \u003d False"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# Set the following two lines to enable SSL. This is for testing only."},{"line_number":39,"context_line":"# cert_file \u003d /etc/swift/proxy.crt"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7a740942_56381aa0","line":36,"updated":"2015-12-12 13:49:54.000000000","message":"this is not true. Keeplive is set to True in your code (common/wsgi.py)\n\nYou should change swift/proxy/server.py and set keepalive explicitly to False to match this comment","commit_id":"75ccb89734685d1faf0676728fe0ff332e7ef03e"}],"swift/common/wsgi.py":[{"author":{"_account_id":18015,"name":"Peter Lisák","email":"peter.lisak@gmail.com","username":"peter.lisak"},"change_message_id":"30f13ff08408e625eb48a5b079367fb554a7c83f","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_c2bd0fd9","line":426,"updated":"2015-09-30 12:27:12.000000000","message":"Default value is True in sample configs.","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"7306f1793ff4d685ce6f72771a3b5acef3be21de","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_ed7b5abc","line":426,"in_reply_to":"9a1a9d01_c2bd0fd9","updated":"2015-09-30 15:48:14.000000000","message":"Yes, for now only these are set to true . But i am not 100% sure if it needs to be done for every server so left it as it is.","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"b94f6dc4bbe54ff006d9ba8983d628977e7d2e07","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_d2a6140e","line":426,"in_reply_to":"9a1a9d01_ed7b5abc","updated":"2015-10-01 07:59:48.000000000","message":"i think commented config line should be default at all times. it\u0027s really confusing for admins if this simple rule is broken.","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":18639,"name":"Marek Kaleta","email":"mk@m1k.cz","username":"mara"},"change_message_id":"4e8879dc62124ddf3a96570e91e4f8c5293d5ea6","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"},{"line_number":430,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a2ad7b9c","line":427,"updated":"2015-09-30 12:28:35.000000000","message":"Option client_socket_timeout is not mentioned in conf-samples","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"b94f6dc4bbe54ff006d9ba8983d628977e7d2e07","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"},{"line_number":430,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b27a8075","line":427,"in_reply_to":"9a1a9d01_4d8286c9","updated":"2015-10-01 07:59:48.000000000","message":"again, i think every configurable option should be in config. really confusing if this is not true. and this new options is not mention in doc.","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"7306f1793ff4d685ce6f72771a3b5acef3be21de","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    socket_timeout \u003d conf.get(\u0027client_socket_timeout\u0027)"},{"line_number":428,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":429,"context_line":"    try:"},{"line_number":430,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_4d8286c9","line":427,"in_reply_to":"9a1a9d01_a2ad7b9c","updated":"2015-09-30 15:48:14.000000000","message":"Yes you are right, i havn\u0027t made any changes to that . i added this change so that these values could be changed later if needed else value of none by default.","commit_id":"3b34655593bdbca976d9281008ca0cb8c64aeb10"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"ae63e26a93f257ee6a44b41e1424cd34ef36ffcd","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keep_alive\u0027, False)"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_85cc8936","line":426,"updated":"2015-11-09 11:48:27.000000000","message":"in conf you have \"keepalive\", not \"keep_alive\"","commit_id":"1d7a8b4134d889c44f38a62eab4ae600f5d84c48"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63f67c934a5fcb34443fd1528dc3f27b833e3596","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keepalive\u0027, True)"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_59f8dbe5","line":426,"range":{"start_line":426,"start_character":17,"end_line":426,"end_character":44},"updated":"2015-12-17 08:31:35.000000000","message":"Can\u0027t we use config_true_value (in swift.common.utils) here?","commit_id":"bcd74fa946cdc4b9645cbafc1af2a9202a1b6c77"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2c94b0db5e8c35afef61bc51945886615c4fc65f","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keepalive\u0027, True)"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_bf93dff9","line":426,"range":{"start_line":426,"start_character":17,"end_line":426,"end_character":44},"in_reply_to":"3a7e1126_24c28686","updated":"2015-12-17 09:01:29.000000000","message":"As you say, keepalive parameter should take True or False, but It\u0027s internal thing.\n\nconfig_true_value is generally used in swift to parse True/False parameters in configrations, and swift accepts true/false values(like 1, True, yes) from outside and regard them as True/False inside swift.\nI think we had better to standardize the way to accept True/False values in configurations.","commit_id":"bcd74fa946cdc4b9645cbafc1af2a9202a1b6c77"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"0e50a4af0d1982b87b4224a3658915c6c6e0ee35","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keepalive\u0027, True)"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_24c28686","line":426,"range":{"start_line":426,"start_character":17,"end_line":426,"end_character":44},"in_reply_to":"3a7e1126_59f8dbe5","updated":"2015-12-17 08:42:41.000000000","message":"Sure we could, but the parameter keepalive takes True or False only in wsgi server but config_true_value makes all possibilities of True i.e 1/true etc which might not be needed in this case. \n\n:param keepalive: If set to False, disables keepalives on the server; all connections will be closed after serving one request.","commit_id":"bcd74fa946cdc4b9645cbafc1af2a9202a1b6c77"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"359a73fed1eb619d18f843dd9b62e0cb8fdcc3ca","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d conf.get(\u0027keepalive\u0027, True)"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_45b6ac8b","line":426,"range":{"start_line":426,"start_character":17,"end_line":426,"end_character":44},"in_reply_to":"3a7e1126_bf93dff9","updated":"2015-12-17 09:24:25.000000000","message":"Okay,i was thinking of being more specific but it\u0027s ok to go with swift convention then, I will push up a patch for it. :)","commit_id":"bcd74fa946cdc4b9645cbafc1af2a9202a1b6c77"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2927568cf9f177df912890b18326e43aec8c2e99","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        global_conf \u003d {\u0027log_name\u0027: log_name}"},{"line_number":424,"context_line":"    app \u003d loadapp(conf[\u0027__file__\u0027], global_conf\u003dglobal_conf)"},{"line_number":425,"context_line":"    max_clients \u003d int(conf.get(\u0027max_clients\u0027, \u00271024\u0027))"},{"line_number":426,"context_line":"    keep_alive \u003d config_true_value(conf.get(\u0027keepalive\u0027, True))"},{"line_number":427,"context_line":"    pool \u003d RestrictedGreenPool(size\u003dmax_clients)"},{"line_number":428,"context_line":"    try:"},{"line_number":429,"context_line":"        # Disable capitalizing headers in Eventlet if possible.  This is"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_7aeee223","line":426,"range":{"start_line":426,"start_character":57,"end_line":426,"end_character":61},"updated":"2015-12-17 09:38:25.000000000","message":"The commit message says False is the default value, but I\u0027m afraid you set True as the default value here.","commit_id":"61c014c4099a931e49892866940e51ae7c75a87d"}]}