)]}'
{"swift/common/middleware/slo.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d35bc48c944e0078e8ebe59b8311823ea86f27fe","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                isinstance(seg_dict[\u0027etag\u0027], basestring)):"},{"line_number":235,"context_line":"            errors.append("},{"line_number":236,"context_line":"                \"Index %d: \\\"etag\\\" must be a string or null\" % seg_index)"},{"line_number":237,"context_line":"            continue"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":240,"context_line":"            errors.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_401652f2","line":237,"updated":"2015-09-27 22:29:26.000000000","message":"Should we add\n\n    if seg_dict[\u0027size_bytes\u0027] is not None:\n        try:\n            seg_dict[\u0027size_bytes\u0027] \u003d int(seg_dict[\u0027size_bytes\u0027])\n        except (ValueError, TypeError):\n            errors.append(\n                \"Index %d: \\\"size_bytes\\\" must be an int or null\" % seg_index)\n            continue\n\nhere? I think it will simplify how we use the size down in StaticLargeObject.handle_multipart_put.","commit_id":"456a61a8e70a9ea08a66b0556a162d48dd396f3c"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"030129c395f4c4af6630ad5923c6327516cd44d2","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                isinstance(seg_dict[\u0027etag\u0027], basestring)):"},{"line_number":235,"context_line":"            errors.append("},{"line_number":236,"context_line":"                \"Index %d: \\\"etag\\\" must be a string or null\" % seg_index)"},{"line_number":237,"context_line":"            continue"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":240,"context_line":"            errors.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2251c262","line":237,"in_reply_to":"9a1a9d01_401652f2","updated":"2015-09-28 17:27:44.000000000","message":"Agree with Tim, seems like we are moving the \"fast\" validation to parse_input, so shouldn\u0027t the size check and the \"manifest object name in the manifest\" check also be moved here?","commit_id":"456a61a8e70a9ea08a66b0556a162d48dd396f3c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d35bc48c944e0078e8ebe59b8311823ea86f27fe","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":240,"context_line":"            errors.append("},{"line_number":241,"context_line":"                \"Index %d: path does not refer to an object\" % seg_index)"},{"line_number":242,"context_line":"            continue"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        if seg_dict.get(\u0027range\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a0ddee43","line":241,"updated":"2015-09-27 22:29:26.000000000","message":"I feel like we should make it clear that we think they\u0027ve specified a container here. Maybe something like\n\n path should be of the form \"\u003ccontainer\u003e/\u003cobject\u003e\"\n\nor\n\n path does not include container","commit_id":"456a61a8e70a9ea08a66b0556a162d48dd396f3c"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"030129c395f4c4af6630ad5923c6327516cd44d2","unresolved":false,"context_lines":[{"line_number":694,"context_line":"            out_content_type \u003d \u0027text/plain\u0027"},{"line_number":695,"context_line":"        data_for_storage \u003d []"},{"line_number":696,"context_line":"        slo_etag \u003d md5()"},{"line_number":697,"context_line":"        last_obj_path \u003d None"},{"line_number":698,"context_line":"        for index, seg_dict in enumerate(parsed_data):"},{"line_number":699,"context_line":"            obj_name \u003d seg_dict[\u0027path\u0027]"},{"line_number":700,"context_line":"            if isinstance(obj_name, unicode):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a2995221","line":697,"updated":"2015-09-28 17:27:44.000000000","message":"maybe move code from line 699-719 to parse_input??","commit_id":"456a61a8e70a9ea08a66b0556a162d48dd396f3c"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _range_is_satisfiable(range_object, length):"},{"line_number":193,"context_line":"    # XXX rename this function? inline it?"},{"line_number":194,"context_line":"    ranges \u003d range_object.ranges_for_length(length)"},{"line_number":195,"context_line":"    return len(ranges) \u003d\u003d 1"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_742f0f3f","line":193,"updated":"2015-09-30 16:59:19.000000000","message":"LOL, I always leave these comments thinking that there\u0027s no way I\u0027ll be forgetful enough to submit code with them in it. Apparently I\u0027m forgetful enough that I can\u0027t remember that I can\u0027t remember to take these out.","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15874b335520b11ffab7ac46e58ec78621b63666","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":253,"context_line":"            errors.append("},{"line_number":254,"context_line":"                \"Index %d: path does not refer to an object\" % seg_index)"},{"line_number":255,"context_line":"            continue"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        seg_size \u003d seg_dict[\u0027size_bytes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_548eaf79","line":254,"updated":"2015-09-30 00:32:15.000000000","message":"I still feel like this should state what we *do* think it refers to. If I hit this error as a user, in all likelihood I was trying to refer to an object in the same container. Just telling me \"that isn\u0027t an object\" when it\u0027s exactly what I *think* should be an object is just frustrating.","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":253,"context_line":"            errors.append("},{"line_number":254,"context_line":"                \"Index %d: path does not refer to an object\" % seg_index)"},{"line_number":255,"context_line":"            continue"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        seg_size \u003d seg_dict[\u0027size_bytes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_547e8b6a","line":254,"in_reply_to":"9a1a9d01_548eaf79","updated":"2015-09-30 16:59:19.000000000","message":"Done","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15874b335520b11ffab7ac46e58ec78621b63666","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if seg_size is not None:"},{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                seg_size \u003d int(seg_size)"},{"line_number":261,"context_line":"            except ValueError:"},{"line_number":262,"context_line":"                errors.append(\"Index %d: invalid size_bytes\" % seg_index)"},{"line_number":263,"context_line":"                continue"},{"line_number":264,"context_line":"            if (seg_size \u003c min_segment_size and seg_index \u003c num_segs - 1):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_b4f86bc4","line":261,"updated":"2015-09-30 00:32:15.000000000","message":"int() could raise TypeError if size_bytes is a list or None or something screwy like that.","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if seg_size is not None:"},{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                seg_size \u003d int(seg_size)"},{"line_number":261,"context_line":"            except ValueError:"},{"line_number":262,"context_line":"                errors.append(\"Index %d: invalid size_bytes\" % seg_index)"},{"line_number":263,"context_line":"                continue"},{"line_number":264,"context_line":"            if (seg_size \u003c min_segment_size and seg_index \u003c num_segs - 1):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_14957385","line":261,"in_reply_to":"9a1a9d01_b4f86bc4","updated":"2015-09-30 16:59:19.000000000","message":"Done","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15874b335520b11ffab7ac46e58ec78621b63666","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # fail that validation later."},{"line_number":292,"context_line":"            if (seg_dict[\u0027size_bytes\u0027] is not None and not"},{"line_number":293,"context_line":"                    _range_is_satisfiable(seg_dict[\u0027range\u0027],"},{"line_number":294,"context_line":"                                          int(seg_dict[\u0027size_bytes\u0027]))):"},{"line_number":295,"context_line":"                errors.append(\"Index %d: unsatisfiable range\" % seg_index)"},{"line_number":296,"context_line":"                continue"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_143917a4","line":294,"updated":"2015-09-30 00:32:15.000000000","message":"We\u0027ve already got a seg_size variable now, right? Why not use it?","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # fail that validation later."},{"line_number":292,"context_line":"            if (seg_dict[\u0027size_bytes\u0027] is not None and not"},{"line_number":293,"context_line":"                    _range_is_satisfiable(seg_dict[\u0027range\u0027],"},{"line_number":294,"context_line":"                                          int(seg_dict[\u0027size_bytes\u0027]))):"},{"line_number":295,"context_line":"                errors.append(\"Index %d: unsatisfiable range\" % seg_index)"},{"line_number":296,"context_line":"                continue"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_74ecef29","line":294,"in_reply_to":"9a1a9d01_143917a4","updated":"2015-09-30 16:59:19.000000000","message":"Done","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15874b335520b11ffab7ac46e58ec78621b63666","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            else:"},{"line_number":756,"context_line":"                # validated as integer by parse_and_validate_input, so"},{"line_number":757,"context_line":"                # there\u0027s no chance of ValueError here"},{"line_number":758,"context_line":"                seg_size \u003d int(seg_dict[\u0027size_bytes\u0027])"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            new_env \u003d req.environ.copy()"},{"line_number":761,"context_line":"            new_env[\u0027PATH_INFO\u0027] \u003d obj_path"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_b41f0b07","line":758,"updated":"2015-09-30 00:32:15.000000000","message":"Would it be better to just have parse_and_validate_input stuff the int()ed size_bytes back into seg_dict?","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            else:"},{"line_number":756,"context_line":"                # validated as integer by parse_and_validate_input, so"},{"line_number":757,"context_line":"                # there\u0027s no chance of ValueError here"},{"line_number":758,"context_line":"                seg_size \u003d int(seg_dict[\u0027size_bytes\u0027])"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            new_env \u003d req.environ.copy()"},{"line_number":761,"context_line":"            new_env[\u0027PATH_INFO\u0027] \u003d obj_path"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_74d38f60","line":758,"in_reply_to":"9a1a9d01_b41f0b07","updated":"2015-09-30 16:59:19.000000000","message":"Yep, it would. I also documented the transformations made; it was getting confusing to me to have some values go through verbatim but others get mangled, but once it was written down there were only 4 things, so no big deal.","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15874b335520b11ffab7ac46e58ec78621b63666","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                    elif ranges \u003d\u003d [(0, seg_dict[\u0027size_bytes\u0027])]:"},{"line_number":788,"context_line":"                        # Just one range, and it exactly matches the object."},{"line_number":789,"context_line":"                        # Why\u0027d we do this again?"},{"line_number":790,"context_line":"                        del seg_dict[\u0027range\u0027]"},{"line_number":791,"context_line":"                        segment_length \u003d head_seg_resp.content_length"},{"line_number":792,"context_line":"                    else:"},{"line_number":793,"context_line":"                        rng \u003d ranges[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_54ef8fe8","line":790,"updated":"2015-09-30 00:32:15.000000000","message":"Thanks! I forgot to do that when I was following up on Matt\u0027s suggestion.","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0498dc857a91d1b546293afac9816739a1bb1afc","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                    elif ranges \u003d\u003d [(0, seg_dict[\u0027size_bytes\u0027])]:"},{"line_number":788,"context_line":"                        # Just one range, and it exactly matches the object."},{"line_number":789,"context_line":"                        # Why\u0027d we do this again?"},{"line_number":790,"context_line":"                        del seg_dict[\u0027range\u0027]"},{"line_number":791,"context_line":"                        segment_length \u003d head_seg_resp.content_length"},{"line_number":792,"context_line":"                    else:"},{"line_number":793,"context_line":"                        rng \u003d ranges[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_b454c7c9","line":790,"in_reply_to":"9a1a9d01_54ef8fe8","updated":"2015-09-30 16:59:19.000000000","message":"(I tried to put a thumbs-up emoji here, but Gerrit 500-ed on form submission, so use your imagination.)","commit_id":"ca46786dfb59c6412000dc93f12839f008c31553"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"a18427957965e7f64bdf69350dd0b5db6f571f49","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def parse_and_validate_input(req_body, req_path, min_segment_size):"},{"line_number":193,"context_line":"    \"\"\""},{"line_number":194,"context_line":"    Given a request body, parses it and returns a list of dictionaries."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    The output structure is nearly the same as the input structure, but it"},{"line_number":197,"context_line":"    is not an exact copy. Given a valid input dictionary `d_in`, its"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_5f645fb7","line":194,"updated":"2015-09-30 19:10:06.000000000","message":"nit: parse it and return a list","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cb38a782d17b24b970ef98663ecb3be35defdc2a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      * d_in[\u0027size_bytes\u0027] can be a string (\"12\") or an integer (12), but"},{"line_number":205,"context_line":"        d_out[\u0027size_bytes\u0027] is an integer."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"      * d_in[\u0027range\u0027] is a string of the form \"M-N\", \"M-\", or \"-N\", where M"},{"line_number":208,"context_line":"        and N are non-negative integers. d_out[\u0027range\u0027] is the corresponding"},{"line_number":209,"context_line":"        swob.Range object."},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_6f7c1aec","line":207,"updated":"2015-09-30 17:40:52.000000000","message":"nit: may be worth noting that d_in[\u0027range\u0027] is optional and d_out[\u0027range\u0027] will only be present if d_in[\u0027range\u0027] is present.","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cb38a782d17b24b970ef98663ecb3be35defdc2a","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                    if not ranges:"},{"line_number":790,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":791,"context_line":"                                                 \u0027Unsatisfiable Range\u0027])"},{"line_number":792,"context_line":"                    elif ranges \u003d\u003d [(0, seg_dict[\u0027size_bytes\u0027])]:"},{"line_number":793,"context_line":"                        # Just one range, and it exactly matches the object."},{"line_number":794,"context_line":"                        # Why\u0027d we do this again?"},{"line_number":795,"context_line":"                        del seg_dict[\u0027range\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_cb119953","line":792,"updated":"2015-09-30 17:40:52.000000000","message":"Oh, hey! As long as you\u0027re here, mind making this head_seg_resp.content_length instead of seg_dict[\u0027size_bytes\u0027]? That\u0027s my bad.","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"de88eea65cb03ad0afa90b0708d0a75f2a25a16d","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                    if not ranges:"},{"line_number":790,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":791,"context_line":"                                                 \u0027Unsatisfiable Range\u0027])"},{"line_number":792,"context_line":"                    elif ranges \u003d\u003d [(0, seg_dict[\u0027size_bytes\u0027])]:"},{"line_number":793,"context_line":"                        # Just one range, and it exactly matches the object."},{"line_number":794,"context_line":"                        # Why\u0027d we do this again?"},{"line_number":795,"context_line":"                        del seg_dict[\u0027range\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_12fd4b6e","line":792,"in_reply_to":"9a1a9d01_cb119953","updated":"2015-10-01 20:30:30.000000000","message":"I\u0027ll do it in a followup patch. That\u0027s changing (for the better) what\u0027s stored on disk in certain cases, so I\u0027d rather not mix that in with a bunch of error-message improvements.","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cb38a782d17b24b970ef98663ecb3be35defdc2a","unresolved":false,"context_lines":[{"line_number":805,"context_line":"                        [quote(obj_name),"},{"line_number":806,"context_line":"                         \u0027Too small; each segment, except the last, must be \u0027"},{"line_number":807,"context_line":"                         \u0027at least %d bytes.\u0027 % self.min_segment_size])"},{"line_number":808,"context_line":"                total_size +\u003d segment_length"},{"line_number":809,"context_line":"                if seg_size is not None and \\"},{"line_number":810,"context_line":"                        seg_size !\u003d head_seg_resp.content_length:"},{"line_number":811,"context_line":"                    problem_segments.append([quote(obj_name), \u0027Size Mismatch\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_ef7a6abc","line":808,"updated":"2015-09-30 17:40:52.000000000","message":"This seems to be the only place we\u0027re using seg_size in this function; would it be better to just use seg_dict[\u0027size_bytes\u0027] instead and get rid of seg_size? That would mimic what we do with seg_dict[\u0027etag\u0027] below...","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"de88eea65cb03ad0afa90b0708d0a75f2a25a16d","unresolved":false,"context_lines":[{"line_number":805,"context_line":"                        [quote(obj_name),"},{"line_number":806,"context_line":"                         \u0027Too small; each segment, except the last, must be \u0027"},{"line_number":807,"context_line":"                         \u0027at least %d bytes.\u0027 % self.min_segment_size])"},{"line_number":808,"context_line":"                total_size +\u003d segment_length"},{"line_number":809,"context_line":"                if seg_size is not None and \\"},{"line_number":810,"context_line":"                        seg_size !\u003d head_seg_resp.content_length:"},{"line_number":811,"context_line":"                    problem_segments.append([quote(obj_name), \u0027Size Mismatch\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_7264c748","line":808,"in_reply_to":"9a1a9d01_ef7a6abc","updated":"2015-10-01 20:30:30.000000000","message":"Yeah, now that seg_dict[\u0027size_bytes\u0027] is guaranteed integer, that\u0027s probably worth doing.","commit_id":"ef1af41c00ffb0be1e4d9509638690688a8b0039"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6b91d37af654c5ce68b2f992ba9fc38c25b1340d","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":790,"context_line":"                                                 \u0027Unsatisfiable Range\u0027])"},{"line_number":791,"context_line":"                    elif len(ranges) \u003e 1:"},{"line_number":792,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":793,"context_line":"                                                 \u0027Multiple Ranges\u0027])"},{"line_number":794,"context_line":"                    elif ranges \u003d\u003d [(0, head_seg_resp.content_length)]:"},{"line_number":795,"context_line":"                        # Just one range, and it exactly matches the object."}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_8be1c8d2","line":792,"updated":"2015-10-07 21:08:33.000000000","message":"We aren\u0027t dropping this anymore? It should still be covered by parse_and_validate_input, right?","commit_id":"12d2e55215689342e83f6e009bfb86c92d70218d"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"7b190c9538e2d16e07b45f67252dfead3fc1933d","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":790,"context_line":"                                                 \u0027Unsatisfiable Range\u0027])"},{"line_number":791,"context_line":"                    elif len(ranges) \u003e 1:"},{"line_number":792,"context_line":"                        problem_segments.append([quote(obj_name),"},{"line_number":793,"context_line":"                                                 \u0027Multiple Ranges\u0027])"},{"line_number":794,"context_line":"                    elif ranges \u003d\u003d [(0, head_seg_resp.content_length)]:"},{"line_number":795,"context_line":"                        # Just one range, and it exactly matches the object."}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_2bd2f4d2","line":792,"in_reply_to":"7a2fa921_8be1c8d2","updated":"2015-10-07 21:13:43.000000000","message":"Yep, it must have been resurrected by the rebase. Fixing.","commit_id":"12d2e55215689342e83f6e009bfb86c92d70218d"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f454fe80b2d49554709b1cd291ccd79c8e75021d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                \"Index %d: \\\"etag\\\" must be a string or null\" % seg_index)"},{"line_number":260,"context_line":"            continue"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if \u0027/\u0027 not in seg_dict[\u0027path\u0027].lstrip(\u0027/\u0027):"},{"line_number":263,"context_line":"            errors.append("},{"line_number":264,"context_line":"                \"Index %d: path does not refer to an object. Path must be of \""},{"line_number":265,"context_line":"                \"the form /container/object.\" % seg_index)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_a3bcdd06","line":262,"updated":"2015-10-08 06:59:01.000000000","message":"This doesn\u0027t catch container-only paths with a trailing slash like \"/cont/\". How about using just strip(\u0027/\u0027) instead of lstrip for this check?\n\n /cont/     -\u003e cont\n /cont/obj  -\u003e cont/obj\n /cont/obj/ -\u003e cont/obj\n\nThus we can ensure it\u0027s really an object.","commit_id":"84faabe7e7825b5a7ea2006b589edf8be8a56a9a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"21505e884a3254ba18175bae8d940dc4d62db43b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                \"Index %d: extraneous keys %s\""},{"line_number":248,"context_line":"                % (seg_index,"},{"line_number":249,"context_line":"                   \", \".join(\u0027\"%s\"\u0027 % (ek,)"},{"line_number":250,"context_line":"                             for ek in sorted(extraneous_keys))))"},{"line_number":251,"context_line":"            continue"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if not isinstance(seg_dict[\u0027path\u0027], basestring):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a2ca52d_dc36ef02","line":250,"updated":"2015-10-14 10:49:22.000000000","message":"oh good they are sorted so the test won\u0027t randomly fail :)","commit_id":"c0866ceaac2f69ae01345a795520141f59ec64f5"}],"test/unit/common/middleware/test_slo.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f454fe80b2d49554709b1cd291ccd79c8e75021d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \"form /container/object.\\n\","},{"line_number":184,"context_line":"            self._put_bogus_slo(json.dumps("},{"line_number":185,"context_line":"                [{\u0027path\u0027: \u0027/cont\u0027, \u0027etag\u0027: \u0027etagoftheobjectsegment\u0027,"},{"line_number":186,"context_line":"                  \u0027size_bytes\u0027: 100}])))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_bogus_input_multiple(self):"},{"line_number":189,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_c3bf99a8","line":186,"updated":"2015-10-08 06:59:01.000000000","message":"Please also check \"/cont/\" here","commit_id":"84faabe7e7825b5a7ea2006b589edf8be8a56a9a"}]}
