)]}'
{"swift/common/manager.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"584d1011d6aae9d9a68e6d3c90ba0f579cc103c5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    : param sig: signal to send"},{"line_number":170,"context_line":"    \"\"\""},{"line_number":171,"context_line":"    # Negative PID means process group"},{"line_number":172,"context_line":"    os.kill(-pid, sig)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class UnknownCommandError(Exception):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_700c5d3b","line":172,"updated":"2016-01-05 05:32:22.000000000","message":"In my testing of this patch, there is a chance that an OSError is raised if process stops between the timeout and the new signal, I got this when I ran:\n\n  swift-init stop all --kill-wait\u003d0 --kill-after-timeout\n\nWhich resulted in a stack trace:\n\n  Waited 0 seconds for container-auditor to die; killing\n  Signal container-auditor  pid: 30220  signal: 9\n  Signal container-auditor  pid: 30221  signal: 9\n  Traceback (most recent call last):\n    File \"/usr/local/bin/swift-init\", line 6, in \u003cmodule\u003e\n      exec(compile(open(__file__).read(), __file__, \u0027exec\u0027))\n    File \"/home/matt/swift/bin/swift-init\", line 111, in \u003cmodule\u003e\n      sys.exit(main())\n    File \"/home/matt/swift/bin/swift-init\", line 101, in main\n      status \u003d manager.run_command(command,   **options.__dict__)\n    File \"/home/matt/swift/swift/common/manager.py\", line 398, in run_command\n      return f(**kwargs)\n    File \"/home/matt/swift/swift/common/manager.py\", line 100, in wrapped\n      rv \u003d func(*a, **kw)\n    File \"/home/matt/swift/swift/common/manager.py\", line 310, in stop\n      kill_group(pid, signal.SIGKILL)\n    File \"/home/matt/swift/swift/common/manager.py\", line 172, in kill_group\n      os.kill(-pid, sig)\n  OSError: [Errno 3] No such process\n\nI recommend adding a try/except block to clean this up as users wont like random stack traces.","commit_id":"77366ca4c1bf6e6d2ac1363874c0894791344699"}]}