)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed46a0a153f70e1225b88cb8e43193a1da855c5f","unresolved":false,"context_lines":[{"line_number":988,"context_line":"    monkey_patch_mimetools()"},{"line_number":989,"context_line":"    return (conf, logger, log_name)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"def init_request_processor(conf_path, app_section, *args, **kwargs):"},{"line_number":993,"context_line":"    \"\"\""},{"line_number":994,"context_line":"    Loads common settings from conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_5fd5b5b6","line":991,"updated":"2015-10-07 18:13:14.000000000","message":"^ well what about this one?","commit_id":"b7ee052e702d64f6f5c0f1bdc09ec425c9b92c34"},{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"7cbc3f90d50b53ec0f5dd1ef01de9b8645ce4485","unresolved":false,"context_lines":[{"line_number":988,"context_line":"    monkey_patch_mimetools()"},{"line_number":989,"context_line":"    return (conf, logger, log_name)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"def init_request_processor(conf_path, app_section, *args, **kwargs):"},{"line_number":993,"context_line":"    \"\"\""},{"line_number":994,"context_line":"    Loads common settings from conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_439ce95c","line":991,"in_reply_to":"7a2fa921_5fd5b5b6","updated":"2015-10-08 06:58:26.000000000","message":"yes, we need to remove *args here.","commit_id":"b7ee052e702d64f6f5c0f1bdc09ec425c9b92c34"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c9a049deec76406f4775623899298c59dc09918b","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            sock.close()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"def run_wsgi(conf_path, app_section, *args, **kwargs):"},{"line_number":849,"context_line":"    \"\"\""},{"line_number":850,"context_line":"    Runs the server according to some strategy.  The default strategy runs a"},{"line_number":851,"context_line":"    specified number of workers in pre-fork model.  The object-server (only)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_c91c016d","line":848,"updated":"2015-10-12 19:32:08.000000000","message":"this is the main entry point, and since it\u0027s not passing *args down to _initrp anymore probably pull it out here too?","commit_id":"2c6ee4e7644910195ce08eb8308eaad2c09e3f07"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c9a049deec76406f4775623899298c59dc09918b","unresolved":false,"context_lines":[{"line_number":989,"context_line":"    return (conf, logger, log_name)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"def init_request_processor(conf_path, app_section, **kwargs):"},{"line_number":993,"context_line":"    \"\"\""},{"line_number":994,"context_line":"    Loads common settings from conf"},{"line_number":995,"context_line":"    Sets the logger"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_89fe0904","line":992,"updated":"2015-10-12 19:32:08.000000000","message":"So this function is only used by apache apparently [1].  Although I don\u0027t think I fully grok the rational for the move to _initrp vs. fixing the existing interface [2].\n\n1. http://docs.openstack.org/developer/swift/apache_deployment_guide.html#apache2-setup\n\n2. https://review.openstack.org/#/c/31075/","commit_id":"2c6ee4e7644910195ce08eb8308eaad2c09e3f07"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"49a9dad9f92f693df89d132c75d1f056503c7806","unresolved":false,"context_lines":[{"line_number":989,"context_line":"    return (conf, logger, log_name)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"def init_request_processor(conf_path, app_section, **kwargs):"},{"line_number":993,"context_line":"    \"\"\""},{"line_number":994,"context_line":"    Loads common settings from conf"},{"line_number":995,"context_line":"    Sets the logger"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_22ecb9c6","line":992,"updated":"2015-10-13 17:17:05.000000000","message":"Dropping *args from _initrp is one thing -- it is by definition internal. But dropping it from init_request_processor() is another thing. This thing was created on behest of people running Swift under Apache. We need to consult with them and make sure they do not pass some useless parameters here which we\u0027re supposed to ignore.","commit_id":"c5d8c6c3bf4eba65a9e2f1a6025ec996f568a85b"},{"author":{"_account_id":15701,"name":"venkatesh","email":"p.venkatesh551@gmail.com","username":"venkatesh"},"change_message_id":"97a9ef9666d14a4f30391c5971cb167372db0dfb","unresolved":false,"context_lines":[{"line_number":989,"context_line":"    return (conf, logger, log_name)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"def init_request_processor(conf_path, app_section, **kwargs):"},{"line_number":993,"context_line":"    \"\"\""},{"line_number":994,"context_line":"    Loads common settings from conf"},{"line_number":995,"context_line":"    Sets the logger"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_550ec33b","line":992,"in_reply_to":"5a2ca52d_22ecb9c6","updated":"2015-10-16 10:39:24.000000000","message":"This is suggested by Clay Gerrard. Thats why I made this change.\nI will revert.","commit_id":"c5d8c6c3bf4eba65a9e2f1a6025ec996f568a85b"}]}