)]}'
{"swift/obj/replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b89fe36661cacf98f1243d56424f28fc56f96c1c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    responses.append(success)"},{"line_number":265,"context_line":"                for region, cand_objs in synced_remote_regions.iteritems():"},{"line_number":266,"context_line":"                    if delete_objs is None:"},{"line_number":267,"context_line":"                        delete_objs \u003d cand_objs"},{"line_number":268,"context_line":"                    else:"},{"line_number":269,"context_line":"                        delete_objs \u003d delete_objs.intersection(cand_objs)"},{"line_number":270,"context_line":"            if self.handoff_delete:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_3b8e94d0","side":"PARENT","line":267,"updated":"2015-10-08 18:30:31.000000000","message":"yeah I was thinking converting the list to a set here was the best thing to do and leaving the set.intersection(list) alone?","commit_id":"da428c4f5613e31c6aeec8dda9738e896dd91324"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ff5fa598722449d29ead973bfe182d75ce1d4685","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                            conn.getresponse().read()"},{"line_number":261,"context_line":"                        if node[\u0027region\u0027] !\u003d job[\u0027region\u0027]:"},{"line_number":262,"context_line":"                            synced_remote_regions[node[\u0027region\u0027]] \u003d \\"},{"line_number":263,"context_line":"                                set(candidates.keys())"},{"line_number":264,"context_line":"                    responses.append(success)"},{"line_number":265,"context_line":"                for region, cand_objs in synced_remote_regions.iteritems():"},{"line_number":266,"context_line":"                    if delete_objs is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_9b232858","line":263,"updated":"2015-10-08 18:23:13.000000000","message":"this introduces overhead of making a set even when it may not be needed i.e. just one remote region.","commit_id":"e0aee5487a2879d67ecd801db689e2e111922f48"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ff5fa598722449d29ead973bfe182d75ce1d4685","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                    if delete_objs is None:"},{"line_number":267,"context_line":"                        delete_objs \u003d cand_objs"},{"line_number":268,"context_line":"                    else:"},{"line_number":269,"context_line":"                        delete_objs \u003d delete_objs \u0026 cand_objs"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"            if self.handoff_delete:"},{"line_number":272,"context_line":"                # delete handoff if we have had handoff_delete successes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_3b6774b8","line":269,"updated":"2015-10-08 18:23:13.000000000","message":"create the sets here when we need them, *may* never happen:\n\ndelete_objs \u003d set(delete_objs) \u0026 set(cand_objs)\n\nand then its ok for delete_objs to remain a set. Could probably test its type first to avoid making a set from delete_objs that is already a set.","commit_id":"e0aee5487a2879d67ecd801db689e2e111922f48"}]}