)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"55411b62b6e04abf6699e2235e9c1a7073929e92","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            # if the difference in rowids between the two differs by"},{"line_number":437,"context_line":"            # more than 50% and the difference is greaten than per_diff,"},{"line_number":438,"context_line":"            # rsync then do a remote merge."},{"line_number":439,"context_line":"            # NOTE: difference \u003e per_diff stops us from droping to rsync"},{"line_number":440,"context_line":"            # on smaller containers, who have only a few rows to sync."},{"line_number":441,"context_line":"            difference \u003d info[\u0027max_row\u0027] - rinfo[\u0027max_row\u0027]"},{"line_number":442,"context_line":"            if rinfo[\u0027max_row\u0027] / float(info[\u0027max_row\u0027]) \u003c 0.5 and \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_e762733d","line":439,"updated":"2015-10-10 14:11:18.000000000","message":"nit: dropping","commit_id":"4991303ea1e8bff594f0daed7b607e28da5a4901"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"73f7a4d9f5cc1216cdbb9db69fa1b8e87c0b5325","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            # if the difference in rowids between the two differs by"},{"line_number":437,"context_line":"            # more than 50% and the difference is greaten than per_diff,"},{"line_number":438,"context_line":"            # rsync then do a remote merge."},{"line_number":439,"context_line":"            # NOTE: difference \u003e per_diff stops us from droping to rsync"},{"line_number":440,"context_line":"            # on smaller containers, who have only a few rows to sync."},{"line_number":441,"context_line":"            difference \u003d info[\u0027max_row\u0027] - rinfo[\u0027max_row\u0027]"},{"line_number":442,"context_line":"            if rinfo[\u0027max_row\u0027] / float(info[\u0027max_row\u0027]) \u003c 0.5 and \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_1cda5d18","line":439,"in_reply_to":"7a2fa921_e762733d","updated":"2015-10-11 23:30:43.000000000","message":"Done","commit_id":"4991303ea1e8bff594f0daed7b607e28da5a4901"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"55411b62b6e04abf6699e2235e9c1a7073929e92","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            # on smaller containers, who have only a few rows to sync."},{"line_number":441,"context_line":"            difference \u003d info[\u0027max_row\u0027] - rinfo[\u0027max_row\u0027]"},{"line_number":442,"context_line":"            if rinfo[\u0027max_row\u0027] / float(info[\u0027max_row\u0027]) \u003c 0.5 and \\"},{"line_number":443,"context_line":"                    difference \u003e self.per_diff:"},{"line_number":444,"context_line":"                self.stats[\u0027remote_merge\u0027] +\u003d 1"},{"line_number":445,"context_line":"                self.logger.increment(\u0027remote_merges\u0027)"},{"line_number":446,"context_line":"                return self._rsync_db(broker, node, http, info[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_87529f65","line":443,"updated":"2015-10-10 14:11:18.000000000","message":"why difference variable? it\u0027s not used anymore again so i would prefer to put it directly in if.","commit_id":"4991303ea1e8bff594f0daed7b607e28da5a4901"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"73f7a4d9f5cc1216cdbb9db69fa1b8e87c0b5325","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            # on smaller containers, who have only a few rows to sync."},{"line_number":441,"context_line":"            difference \u003d info[\u0027max_row\u0027] - rinfo[\u0027max_row\u0027]"},{"line_number":442,"context_line":"            if rinfo[\u0027max_row\u0027] / float(info[\u0027max_row\u0027]) \u003c 0.5 and \\"},{"line_number":443,"context_line":"                    difference \u003e self.per_diff:"},{"line_number":444,"context_line":"                self.stats[\u0027remote_merge\u0027] +\u003d 1"},{"line_number":445,"context_line":"                self.logger.increment(\u0027remote_merges\u0027)"},{"line_number":446,"context_line":"                return self._rsync_db(broker, node, http, info[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_bcb329e9","line":443,"in_reply_to":"7a2fa921_87529f65","updated":"2015-10-11 23:30:43.000000000","message":"Fair point, only put it in a variable for readability, I\u0027ll roll it in to the if and see what it looks like again. If it doesn\u0027t force another new line I\u0027ll push up a new patchset.","commit_id":"4991303ea1e8bff594f0daed7b607e28da5a4901"}]}
