)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1d18b1479a1f96582e06d50149bbb489daafe9e9","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        print(Commands.default.__doc__.strip())"},{"line_number":1148,"context_line":"        print()"},{"line_number":1149,"context_line":"        cmds \u003d [c for c, f in Commands.__dict__.items()"},{"line_number":1150,"context_line":"                if f.__doc__ and not c.startswith(\u0027_\u0027) and c !\u003d \u0027default\u0027]"},{"line_number":1151,"context_line":"        cmds.sort()"},{"line_number":1152,"context_line":"        for cmd in cmds:"},{"line_number":1153,"context_line":"            print(Commands.__dict__[cmd].__doc__.strip())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8ada6c16","line":1150,"updated":"2015-11-30 20:20:29.000000000","message":"The binding of not here can be ambiguous - it\u0027s less readable this way, IMHO.","commit_id":"635bc7fa8f9a442b39af4955e98fcd2e2acf1e0a"}],"swift/common/middleware/formpost.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1d18b1479a1f96582e06d50149bbb489daafe9e9","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                        hdrs[\u0027Content-Type\u0027] or \u0027application/octet-stream\u0027"},{"line_number":273,"context_line":"                status, subheaders, message \u003d \\"},{"line_number":274,"context_line":"                    self._perform_subrequest(env, attributes, fp, keys)"},{"line_number":275,"context_line":"                if not status.startswith(\u00272\u0027):"},{"line_number":276,"context_line":"                    break"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                data \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8af10c98","line":275,"updated":"2015-11-30 20:20:29.000000000","message":"I think the original code here was pretty stupid - the best I can think of is that maybe at one point it might have been something like:\n\n    if status[:3] !\u003d \u0027200\u0027:\n\nor\n\n    if status[:2] !\u003d \u002720\u0027:\n\ntrying to catch 202 and 200 or any 20X - either way startswith would have been better than slicing.\n\nIt looks pretty silly at this point, creating a new single character string via slicing - ick.\n\n    if not status.startswith(\u00272\u0027):\n\n... is fine, but\n\n    if status[0] !\u003d 2:\n\nwould have been just as good, IMHO.\n\ncommon.http.is_success would be best - but that method expects a int.  Actually it\u0027s somewhat unfortunate that formpost still rolls it\u0027s own subrequest handling when we things like common.wsgi.WSGIContext.  Porting formpost to use WSGIContext would be an example of a very welcome cleanup.","commit_id":"635bc7fa8f9a442b39af4955e98fcd2e2acf1e0a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"56328c894b442277b8a80869a701db2c68410aee","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                        hdrs[\u0027Content-Type\u0027] or \u0027application/octet-stream\u0027"},{"line_number":273,"context_line":"                status, subheaders, message \u003d \\"},{"line_number":274,"context_line":"                    self._perform_subrequest(env, attributes, fp, keys)"},{"line_number":275,"context_line":"                if not status.startswith(\u00272\u0027):"},{"line_number":276,"context_line":"                    break"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                data \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b2c5063d","line":275,"in_reply_to":"9a8ffd7b_8af10c98","updated":"2015-12-07 09:13:09.000000000","message":"I also agree Clay\u0027s idea that to use common.http.is_success is the best way to fix the stupid way, we need more cleanup to translate str into int tho.","commit_id":"635bc7fa8f9a442b39af4955e98fcd2e2acf1e0a"}],"swift/common/ring/utils.py":[{"author":{"_account_id":18015,"name":"Peter Lisák","email":"peter.lisak@gmail.com","username":"peter.lisak"},"change_message_id":"fe53974e483aa2ed9a8d2a72c2719e070a096f87","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    Return True if the provided hostname is a valid hostname"},{"line_number":223,"context_line":"    \"\"\""},{"line_number":224,"context_line":"    if len(hostname) \u003c 1 or len(hostname) \u003e 255:"},{"line_number":225,"context_line":"        return False"},{"line_number":226,"context_line":"    if hostname[-1] \u003d\u003d \".\":"},{"line_number":227,"context_line":"        # strip exactly one dot from the right, if present"},{"line_number":228,"context_line":"        hostname \u003d hostname[:-1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_79016805","line":225,"updated":"2015-10-16 16:48:59.000000000","message":"Here you missed one","commit_id":"977d4a9ea1134a3a87ee95f12c460f51135a6283"}],"swift/common/utils.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1d18b1479a1f96582e06d50149bbb489daafe9e9","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"def get_trans_id_time(trans_id):"},{"line_number":442,"context_line":"    if len(trans_id) \u003e\u003d 34 and \\"},{"line_number":443,"context_line":"       trans_id.startswith(\u0027tx\u0027) and trans_id[23] \u003d\u003d \u0027-\u0027:"},{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            return int(trans_id[24:34], 16)"},{"line_number":446,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ed36b2e6","line":443,"updated":"2015-11-30 20:20:29.000000000","message":"I like startswith here to replace the slicing - nice catch","commit_id":"635bc7fa8f9a442b39af4955e98fcd2e2acf1e0a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1d18b1479a1f96582e06d50149bbb489daafe9e9","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"                record.exc_text \u003d self.formatException("},{"line_number":1406,"context_line":"                    record.exc_info).replace(\u0027\\n\u0027, \u0027#012\u0027)"},{"line_number":1407,"context_line":"        if record.exc_text:"},{"line_number":1408,"context_line":"            if not msg.endswith(\u0027#012\u0027):"},{"line_number":1409,"context_line":"                msg \u003d msg + \u0027#012\u0027"},{"line_number":1410,"context_line":"            msg \u003d msg + record.exc_text"},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ad30aae9","line":1408,"updated":"2015-11-30 20:20:29.000000000","message":"here too!","commit_id":"635bc7fa8f9a442b39af4955e98fcd2e2acf1e0a"}]}
