)]}'
{"test/unit/proxy/controllers/test_base.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0e44db6cfe938c324c5f0b1436bd0bbe9945d282","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        base.account_name \u003d \u0027a\u0027"},{"line_number":458,"context_line":"        base.container_name \u003d \u0027c\u0027"},{"line_number":459,"context_line":"        origin \u003d \u0027http://m.com\u0027"},{"line_number":460,"context_line":"        self.app.cors_allow_origin \u003d [origin]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        def my_container_info(*args):"},{"line_number":463,"context_line":"            return {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_4ec0172b","line":460,"updated":"2015-10-23 16:15:55.000000000","message":"did you mean to delete this line so that the allow_origin from the container_info gets used?\n\notherwise...I\u0027m not sure what this test adds beyond test_options above? The additional lines don\u0027t seem to add anything to the outcome.","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"eed671d65a8754f7ff70dae38b3bd0efcca5e1f0","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        req \u003d Request.blank(\u0027/v1/a/c/o\u0027,"},{"line_number":470,"context_line":"                            environ\u003d{\u0027swift.cache\u0027: FakeCache()},"},{"line_number":471,"context_line":"                            headers\u003d{\u0027Origin\u0027: origin,"},{"line_number":472,"context_line":"                                     \u0027Access-Control-Request-Method\u0027: \u0027GET\u0027})"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        with patch(\u0027swift.proxy.controllers.base.\u0027"},{"line_number":475,"context_line":"                   \u0027http_connect\u0027, fake_http_connect(200)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_0052b5dd","line":472,"updated":"2015-10-27 01:32:32.000000000","message":"removing these headers in version 2 results in the response always being 200 regardless of allow_origin, see swift/proxy/controllers/base.py:1701","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0e44db6cfe938c324c5f0b1436bd0bbe9945d282","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        container_info \u003d \\"},{"line_number":540,"context_line":"            base.container_info(base.account_name,"},{"line_number":541,"context_line":"                                base.container_name)"},{"line_number":542,"context_line":"        self.assertTrue(container_info)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def test_headers_to_account_info_missing(self):"},{"line_number":545,"context_line":"        resp \u003d headers_to_account_info({}, 404)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_a93f6586","line":542,"updated":"2015-10-23 16:15:55.000000000","message":"nit: could be more precise e.g. assert what keys are expected","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0e44db6cfe938c324c5f0b1436bd0bbe9945d282","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        src_headers \u003d {\u0027x-remove-base-meta-owner\u0027: \u0027x\u0027,"},{"line_number":724,"context_line":"                       \u0027x-base-meta-size\u0027: \u0027151M\u0027,"},{"line_number":725,"context_line":"                       \u0027new-owner\u0027: \u0027Kun\u0027}"},{"line_number":726,"context_line":"        req \u003d Request.blank(\u0027/v1/a/c/o\u0027, headers\u003dsrc_headers)"},{"line_number":727,"context_line":"        dst_headers \u003d base.generate_request_headers(None,"},{"line_number":728,"context_line":"                                                    additional\u003dreq.headers)"},{"line_number":729,"context_line":"        expected_headers \u003d {\u0027x-base-meta-size\u0027: \u0027151M\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_493011e9","line":726,"updated":"2015-10-23 16:15:55.000000000","message":"don\u0027t think you need to create a Request, juts pass src_headers to base.generate_request_headers","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0e44db6cfe938c324c5f0b1436bd0bbe9945d282","unresolved":false,"context_lines":[{"line_number":728,"context_line":"                                                    additional\u003dreq.headers)"},{"line_number":729,"context_line":"        expected_headers \u003d {\u0027x-base-meta-size\u0027: \u0027151M\u0027,"},{"line_number":730,"context_line":"                            \u0027connection\u0027: \u0027close\u0027}"},{"line_number":731,"context_line":"        for k, v in expected_headers.items():"},{"line_number":732,"context_line":"            self.assertTrue(k in dst_headers)"},{"line_number":733,"context_line":"            self.assertEqual(v, dst_headers[k])"},{"line_number":734,"context_line":"        self.assertTrue(\u0027\u0027 in dst_headers[\u0027Referer\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_0903f90e","line":731,"updated":"2015-10-23 16:15:55.000000000","message":"nit: could use\n\n  self.assertDictContainsSubset(expected_headers, dst_headers)","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0e44db6cfe938c324c5f0b1436bd0bbe9945d282","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        for k, v in expected_headers.items():"},{"line_number":732,"context_line":"            self.assertTrue(k in dst_headers)"},{"line_number":733,"context_line":"            self.assertEqual(v, dst_headers[k])"},{"line_number":734,"context_line":"        self.assertTrue(\u0027\u0027 in dst_headers[\u0027Referer\u0027])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_client_chunk_size(self):"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_4919f178","line":734,"updated":"2015-10-23 16:15:55.000000000","message":"this will pass for *any* string in dst_header[\u0027Referer\u0027]. You need:\n\n  self.assertEqual(\u0027\u0027, dst_headers[\u0027Referer\u0027])","commit_id":"1a740a0eac3cb798f3f4881c24bba259a77cfca2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c5146dd5efce21a89bc5a7e74db5cce5d7bab599","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                    \u0027allow_origin\u0027: \u0027*\u0027,"},{"line_number":464,"context_line":"                }"},{"line_number":465,"context_line":"            }"},{"line_number":466,"context_line":"        base.container_info \u003d my_container_info"},{"line_number":467,"context_line":"        req \u003d Request.blank(\u0027/v1/a/c/o\u0027,"},{"line_number":468,"context_line":"                            environ\u003d{\u0027swift.cache\u0027: FakeCache()})"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_a02bc132","line":466,"updated":"2015-10-27 01:31:36.000000000","message":"This test still passes if I remove line 466 because you removed the Origin headers from the request wrt version 1 :(\n\nI think there is another test case that could be covered there (i.e OPTIONs request with no origin header), but it doesn\u0027t makes sense to define my_container_info for that test case, and I am guessing that wasn\u0027t your intention.","commit_id":"06a47a48d071fc885c74a6cf65c5c42549f0abee"}]}
