)]}'
{"test/unit/account/test_backend.py":[{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c0bbc87efcb1c616bc8f80b6a9cf14cae56fa8aa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_initialize_fail(self):"},{"line_number":69,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":72,"context_line":"        except ValueError as e:"},{"line_number":73,"context_line":"            self.assertEqual(str(e), \u0027Attempting to create a new database \u0027"},{"line_number":74,"context_line":"                                     \u0027with no account set\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_a4d03af7","line":71,"updated":"2015-11-06 15:54:33.000000000","message":"Why do you pass a timestamp? The test works fine without it.","commit_id":"0eaa2ccfd1a6747f10186f88f10ddd1ed96c4559"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"eeadb315b2dea5c47bf4b669933a66ad67a0cee3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_initialize_fail(self):"},{"line_number":69,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":72,"context_line":"        except ValueError as e:"},{"line_number":73,"context_line":"            self.assertEqual(str(e), \u0027Attempting to create a new database \u0027"},{"line_number":74,"context_line":"                                     \u0027with no account set\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_477f10ab","line":71,"in_reply_to":"fa80f949_a4d03af7","updated":"2015-11-06 15:59:00.000000000","message":"Aaah yeah. I passed the timestamp just to be consistent with the rest of the file.","commit_id":"0eaa2ccfd1a6747f10186f88f10ddd1ed96c4559"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c0bbc87efcb1c616bc8f80b6a9cf14cae56fa8aa","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"        with broker.get() as conn:"},{"line_number":1503,"context_line":"            with self.assertRaises(sqlite3.OperationalError):"},{"line_number":1504,"context_line":"                AccountBroker._migrate_add_storage_policy_index("},{"line_number":1505,"context_line":"                    broker, conn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_872898e3","line":1505,"updated":"2015-11-06 15:54:33.000000000","message":"Unusual calling style for an instance method. Any reason to do it this way?","commit_id":"0eaa2ccfd1a6747f10186f88f10ddd1ed96c4559"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"eeadb315b2dea5c47bf4b669933a66ad67a0cee3","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"        with broker.get() as conn:"},{"line_number":1503,"context_line":"            with self.assertRaises(sqlite3.OperationalError):"},{"line_number":1504,"context_line":"                AccountBroker._migrate_add_storage_policy_index("},{"line_number":1505,"context_line":"                    broker, conn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_67e01497","line":1505,"in_reply_to":"fa80f949_872898e3","updated":"2015-11-06 15:59:00.000000000","message":"Fixing this in the new patch. Thanks for the tip.","commit_id":"0eaa2ccfd1a6747f10186f88f10ddd1ed96c4559"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"5412a07d829c5fe6201cc0492e4eafa7e4d21595","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027, account\u003d\u0027a\u0027)"},{"line_number":1501,"context_line":"        broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":1502,"context_line":"        with broker.get() as conn:"},{"line_number":1503,"context_line":"            with self.assertRaises(sqlite3.OperationalError):"},{"line_number":1504,"context_line":"                broker._migrate_add_storage_policy_index(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_88e1b5d2","line":1503,"updated":"2015-11-10 15:38:50.000000000","message":"just curious (remember I\u0027m no python wiz) as to why you did the nested with instead of just this in the first with:\n            self.assertRaises(sqlite3.OperationalError,\n                broker._migrate_add_storage_policy_index, conn\u003dconn)","commit_id":"c8db8b92523837125b7dca6b66ec398c494460c3"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"518877667ca53a0be5ee5b77d9e87a75286a2d7b","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027, account\u003d\u0027a\u0027)"},{"line_number":1501,"context_line":"        broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":1502,"context_line":"        with broker.get() as conn:"},{"line_number":1503,"context_line":"            with self.assertRaises(sqlite3.OperationalError):"},{"line_number":1504,"context_line":"                broker._migrate_add_storage_policy_index(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9c4a5ac4","line":1503,"in_reply_to":"da85f559_88e1b5d2","updated":"2015-11-10 15:55:33.000000000","message":"Aaah, no specific reason other than just my python knowledge being more crude than yours. I can update the patch to do that. It definitely looks cleaner.","commit_id":"c8db8b92523837125b7dca6b66ec398c494460c3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b8a79460b5a08222d751db1c7f1cbf6ad64fc873","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":72,"context_line":"        except ValueError as e:"},{"line_number":73,"context_line":"            self.assertEqual(str(e), \u0027Attempting to create a new database \u0027"},{"line_number":74,"context_line":"                                     \u0027with no account set\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_4b419a0a","line":72,"updated":"2015-11-23 18:50:07.000000000","message":"this test will still pass if i remove the relevant code in the initialize() method so that no exception is raised.\n\nI suggest using the context manager version of self.assertRaises, e.g.:\n\n        with self.assertRaises(ValueError) as cm:\n            broker.initialize(Timestamp(\u00271\u0027).internal)\n        self.assertEqual(\n            \u0027Attempting to create a new database with no account set\u0027,\n            str(cm.exception))","commit_id":"423bda4eb9ab407fb8a31196ff46865cfb91eea0"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"802dfc29721204f009da5dd3ec66164c052522ec","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        broker \u003d AccountBroker(\u0027:memory:\u0027)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            broker.initialize(Timestamp(\u00271\u0027).internal)"},{"line_number":72,"context_line":"        except ValueError as e:"},{"line_number":73,"context_line":"            self.assertEqual(str(e), \u0027Attempting to create a new database \u0027"},{"line_number":74,"context_line":"                                     \u0027with no account set\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_0e0de03d","line":72,"in_reply_to":"ba8a016a_4b419a0a","updated":"2015-11-23 19:18:19.000000000","message":"Thanks. Didnt realize i am missing that as well. Will submit new patch fixing it as you have suggested.","commit_id":"423bda4eb9ab407fb8a31196ff46865cfb91eea0"}]}