)]}'
{"bin/swift-ring-builder":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"f95d43e8696071ed88325f4e30d624d0a1fa344f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            print Commands.add.__doc__.strip()"},{"line_number":372,"context_line":"            exit(EXIT_ERROR)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        for new_dev in _parse_add_values(argv[3:]):"},{"line_number":375,"context_line":"            for dev in builder.devs:"},{"line_number":376,"context_line":"                if dev is None:"},{"line_number":377,"context_line":"                    continue"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FjVY%3D","line":374,"updated":"2013-05-04 16:07:45.000000000","message":"You\u0027re constructing the parser twice (here and in _parse_add_values); could you just pass options and args into _parse_add_values?\n\nOr maybe just delete all the parser, options, args business here... except that it\u0027s nice having the add_option calls so close to the \"usage message\" for add.","commit_id":"46eaa0ae32678a6a8e2c11a2452432fb0cc72104"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"a9851c34c3f1e76ff2603ae85f1ddf2d339c2803","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            print Commands.add.__doc__.strip()"},{"line_number":372,"context_line":"            exit(EXIT_ERROR)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        for new_dev in _parse_add_values(argv[3:]):"},{"line_number":375,"context_line":"            for dev in builder.devs:"},{"line_number":376,"context_line":"                if dev is None:"},{"line_number":377,"context_line":"                    continue"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FdpU%3D","line":374,"in_reply_to":"AAAAOn%2F%2FjVY%3D","updated":"2013-05-08 21:25:48.000000000","message":"Yeesh. You\u0027re definitely right about doing too much work here. I go to all this trouble to construct the \u0027options\u0027 and \u0027args\u0027 variables, and then I never do a damn thing with them. WTF was I thinking? Maybe I moved stuff around and left a vestigial copy of this crap sitting here.\n\nWill fix.","commit_id":"46eaa0ae32678a6a8e2c11a2452432fb0cc72104"}],"doc/manpages/swift-ring-builder.1":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"56a2cc1294bf8a42d28c59193c931beac471b494","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".IP \"\\fBadd\\fR z\u003czone\u003e-\u003cip\u003e:\u003cport\u003e/\u003cdevice_name\u003e_\u003cmeta\u003e \u003cweight\u003e\""},{"line_number":118,"context_line":".IP \"\\fBadd\\fR r\u003cregion\u003ez\u003czone\u003e-\u003cip\u003e:\u003cport\u003e/\u003cdevice_name\u003e_\u003cmeta\u003e \u003cweight\u003e\""},{"line_number":119,"context_line":".IP \"\\fBadd\\fR -r \u003cregion\u003e -z \u003czone\u003e -i \u003cip\u003e -p \u003cport\u003e -d \u003cdevice_name\u003e -m \u003cmeta\u003e -w \u003cweight\u003e\""},{"line_number":120,"context_line":"Adds a device to the ring with the given information. No partitions will be "},{"line_number":121,"context_line":"assigned to the new device until after running \u0027rebalance\u0027. This is so you "},{"line_number":122,"context_line":"can make multiple device changes and rebalance them all just once."}],"source_content_type":"text/troff","patch_set":5,"id":"AAAAPX%2F%2FyGE%3D","line":119,"updated":"2013-06-10 19:15:42.000000000","message":"Does this format okay without the \".RS 5\"?  I\u0027m guessing not, but I haven\u0027t tried it...","commit_id":"d89cf5ba5a3a16c60765510105be326ff8534cb9"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"095591993dcd30f43f22ee5b3f21a07fa873ef7c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".IP \"\\fBadd\\fR z\u003czone\u003e-\u003cip\u003e:\u003cport\u003e/\u003cdevice_name\u003e_\u003cmeta\u003e \u003cweight\u003e\""},{"line_number":118,"context_line":".IP \"\\fBadd\\fR r\u003cregion\u003ez\u003czone\u003e-\u003cip\u003e:\u003cport\u003e/\u003cdevice_name\u003e_\u003cmeta\u003e \u003cweight\u003e\""},{"line_number":119,"context_line":".IP \"\\fBadd\\fR -r \u003cregion\u003e -z \u003czone\u003e -i \u003cip\u003e -p \u003cport\u003e -d \u003cdevice_name\u003e -m \u003cmeta\u003e -w \u003cweight\u003e\""},{"line_number":120,"context_line":"Adds a device to the ring with the given information. No partitions will be "},{"line_number":121,"context_line":"assigned to the new device until after running \u0027rebalance\u0027. This is so you "},{"line_number":122,"context_line":"can make multiple device changes and rebalance them all just once."}],"source_content_type":"text/troff","patch_set":5,"id":"AAAAPX%2F%2Fxz0%3D","line":119,"in_reply_to":"AAAAPX%2F%2FyGE%3D","updated":"2013-06-10 21:09:14.000000000","message":"Yeah, it makes the alignment a little off.\n\nI didn\u0027t actually mean to delete that, but the result looked okay when viewed through nroff, so I guess I just didn\u0027t notice. Will fix.","commit_id":"d89cf5ba5a3a16c60765510105be326ff8534cb9"}]}