)]}'
{"test/unit/cli/test_info.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"509abab7eafba0d2b1c2eb77b95530afa3191545","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # No account specified"},{"line_number":243,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":244,"context_line":"                          None, container\u003d\u0027con\u0027)"},{"line_number":245,"context_line":"        # No policy named xxx (unrecognized policy)"},{"line_number":246,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":247,"context_line":"                          None, obj\u003d\u0027object\u0027, policy_name\u003d\u0027xyz\u0027)"},{"line_number":248,"context_line":"        # No container specified"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_cf82c7c8","line":245,"updated":"2015-11-03 17:08:58.000000000","message":"nit: \u0027xxx\u0027 or \u0027xyz\u0027?","commit_id":"3469b10a150e690f6b8bcc285e15c551f44871ef"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"17e35be212884f711b69c1b6d8d226bca0204714","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # No account specified"},{"line_number":243,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":244,"context_line":"                          None, container\u003d\u0027con\u0027)"},{"line_number":245,"context_line":"        # No policy named xxx (unrecognized policy)"},{"line_number":246,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":247,"context_line":"                          None, obj\u003d\u0027object\u0027, policy_name\u003d\u0027xyz\u0027)"},{"line_number":248,"context_line":"        # No container specified"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_12565d5c","line":245,"in_reply_to":"fa80f949_cf82c7c8","updated":"2015-11-05 15:42:27.000000000","message":"good catch. fixed in patch4","commit_id":"3469b10a150e690f6b8bcc285e15c551f44871ef"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"faa9161e36a525ea57c7ce962bd28f7425378580","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_print_item_locations_ring_policy(self):"},{"line_number":254,"context_line":"        out \u003d StringIO()"},{"line_number":255,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":256,"context_line":"            objring \u003d ring.Ring(self.testdir, ring_name\u003d\u0027object\u0027)"},{"line_number":257,"context_line":"            # Test mismatch of ring and policy name (valid policy)"},{"line_number":258,"context_line":"            self.assertRaises(InfoSystemExit, print_item_locations,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_fe3e31d9","line":255,"updated":"2015-11-04 17:33:08.000000000","message":"Just curious on why you need to mock this? Is it to test the contents of the file later?","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"fd5491ef44ca7ca7cf7edf32916ded682bcb1d9c","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_print_item_locations_ring_policy(self):"},{"line_number":254,"context_line":"        out \u003d StringIO()"},{"line_number":255,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":256,"context_line":"            objring \u003d ring.Ring(self.testdir, ring_name\u003d\u0027object\u0027)"},{"line_number":257,"context_line":"            # Test mismatch of ring and policy name (valid policy)"},{"line_number":258,"context_line":"            self.assertRaises(InfoSystemExit, print_item_locations,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d43bd7cf","line":255,"in_reply_to":"fa80f949_fe3e31d9","updated":"2015-11-05 19:54:36.000000000","message":"Good catches. Clearly, I was asleep at the wheel.  Added in new patch.","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"faa9161e36a525ea57c7ce962bd28f7425378580","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_print_item_locations_policy_object(self):"},{"line_number":265,"context_line":"        out \u003d StringIO()"},{"line_number":266,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":267,"context_line":"            print_item_locations(None, partition\u003d\u00271\u0027, policy_name\u003d\u0027zero\u0027,"},{"line_number":268,"context_line":"                                 swift_dir\u003dself.testdir)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_5963d7dc","line":266,"updated":"2015-11-04 17:33:08.000000000","message":"Same as above. And for all the ones below.","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"fd5491ef44ca7ca7cf7edf32916ded682bcb1d9c","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_print_item_locations_policy_object(self):"},{"line_number":265,"context_line":"        out \u003d StringIO()"},{"line_number":266,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":267,"context_line":"            print_item_locations(None, partition\u003d\u00271\u0027, policy_name\u003d\u0027zero\u0027,"},{"line_number":268,"context_line":"                                 swift_dir\u003dself.testdir)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b43093e9","line":266,"in_reply_to":"fa80f949_5963d7dc","updated":"2015-11-05 19:54:36.000000000","message":"Added in new patch.","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"faa9161e36a525ea57c7ce962bd28f7425378580","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    def test_print_item_locations_ring_name_partition(self):"},{"line_number":271,"context_line":"        out \u003d StringIO()"},{"line_number":272,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":273,"context_line":"            print_item_locations(None, policy_name\u003d\u0027one\u0027,"},{"line_number":274,"context_line":"                                 ring_name\u003d\u0027object-1\u0027, partition\u003d\u00271\u0027,"},{"line_number":275,"context_line":"                                 swift_dir\u003dself.testdir)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_39861366","line":273,"updated":"2015-11-04 17:33:08.000000000","message":"This test will return something. Should we be checking that it works as expected?","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"fd5491ef44ca7ca7cf7edf32916ded682bcb1d9c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    def test_print_item_locations_ring_name_partition(self):"},{"line_number":271,"context_line":"        out \u003d StringIO()"},{"line_number":272,"context_line":"        with mock.patch(\u0027sys.stdout\u0027, out):"},{"line_number":273,"context_line":"            print_item_locations(None, policy_name\u003d\u0027one\u0027,"},{"line_number":274,"context_line":"                                 ring_name\u003d\u0027object-1\u0027, partition\u003d\u00271\u0027,"},{"line_number":275,"context_line":"                                 swift_dir\u003dself.testdir)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_7451cb0d","line":273,"in_reply_to":"fa80f949_39861366","updated":"2015-11-05 19:54:36.000000000","message":"Added in new patch.","commit_id":"522cd83c63a8cf9a96954b54bdf5fdb5dad0d512"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ecfbd805cdb07eb87882677682b5fcc1ac4e02dc","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        # No container specified"},{"line_number":249,"context_line":"        objring \u003d ring.Ring(self.testdir, ring_name\u003d\u0027object\u0027)"},{"line_number":250,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":251,"context_line":"                          objring, account\u003d\u0027account\u0027, obj\u003d\u0027object\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_print_item_locations_ring_policy_mismatch_no_target(self):"},{"line_number":254,"context_line":"        out \u003d StringIO()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_1445df6e","line":251,"updated":"2015-11-05 20:11:18.000000000","message":"if you use the context manager for of assertRaises I think you can validate the the error message too.","commit_id":"4bad5ff4ae9a314804e80463f5b323c2f86a969c"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b1b1b1c3f4b161bd2cc7959798167088e412d030","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        # No container specified"},{"line_number":249,"context_line":"        objring \u003d ring.Ring(self.testdir, ring_name\u003d\u0027object\u0027)"},{"line_number":250,"context_line":"        self.assertRaises(InfoSystemExit, print_item_locations,"},{"line_number":251,"context_line":"                          objring, account\u003d\u0027account\u0027, obj\u003d\u0027object\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_print_item_locations_ring_policy_mismatch_no_target(self):"},{"line_number":254,"context_line":"        out \u003d StringIO()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_ea3b9236","line":251,"in_reply_to":"fa80f949_1445df6e","updated":"2015-11-05 21:01:53.000000000","message":"thx for tip. I\u0027ll have to dig into that approach","commit_id":"4bad5ff4ae9a314804e80463f5b323c2f86a969c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ecfbd805cdb07eb87882677682b5fcc1ac4e02dc","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            print_item_locations(object_ring, ring_name\u003d\u0027object-1\u0027,"},{"line_number":391,"context_line":"                                 account\u003daccount, container\u003dcontainer,"},{"line_number":392,"context_line":"                                 obj\u003dobj)"},{"line_number":393,"context_line":"        exp_acct_msg \u003d \u0027Account  \\t%s\u0027 % account "},{"line_number":394,"context_line":"        exp_cont_msg \u003d \u0027Container\\t%s\u0027 % container"},{"line_number":395,"context_line":"        exp_obj_msg \u003d \u0027Object   \\t%s\u0027 % obj"},{"line_number":396,"context_line":"        self.assertTrue(exp_acct_msg in out.getvalue())"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_ef3644e6","line":393,"updated":"2015-11-05 20:11:18.000000000","message":"trailing white space here - you\u0027ll probably want to figure out how to make your editor highlight this - people tend to go bananas about trailing whitespace for some reason :\\","commit_id":"4bad5ff4ae9a314804e80463f5b323c2f86a969c"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b1b1b1c3f4b161bd2cc7959798167088e412d030","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            print_item_locations(object_ring, ring_name\u003d\u0027object-1\u0027,"},{"line_number":391,"context_line":"                                 account\u003daccount, container\u003dcontainer,"},{"line_number":392,"context_line":"                                 obj\u003dobj)"},{"line_number":393,"context_line":"        exp_acct_msg \u003d \u0027Account  \\t%s\u0027 % account "},{"line_number":394,"context_line":"        exp_cont_msg \u003d \u0027Container\\t%s\u0027 % container"},{"line_number":395,"context_line":"        exp_obj_msg \u003d \u0027Object   \\t%s\u0027 % obj"},{"line_number":396,"context_line":"        self.assertTrue(exp_acct_msg in out.getvalue())"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_caf9ee81","line":393,"in_reply_to":"fa80f949_ef3644e6","updated":"2015-11-05 21:01:53.000000000","message":"Thx. corrected in new patch","commit_id":"4bad5ff4ae9a314804e80463f5b323c2f86a969c"}]}
